[GR-24462] Remove obsolete TODO + fix guard completeness in ToIntNode & ToLongNode.

PullRequest: truffleruby/1743

Author: eregon

src/main/java/org/truffleruby/core/array/ArrayAppendOneNode.java

@@ -81,7 +81,6 @@ protected DynamicObject appendOneGeneralizeNonMutable(DynamicObject array, Objec
         final int newCapacity = newSize > oldCapacity
                 ? ArrayUtils.capacityForOneMore(getContext(), oldCapacity)
                 : oldCapacity;
-        // TODO (norswap, 03 Apr 2020): this is a performance warning (inlining a virtual call)
         final Object newStore = currentStores.allocateForNewValue(currentStore, value, newCapacity);
         currentStores.copyContents(currentStore, 0, newStore, 0, oldSize);
         propagateSharingNode.executePropagate(array, value);

src/main/java/org/truffleruby/core/cast/ToIntNode.java

@@ -108,7 +108,7 @@ protected long coerceNil(Nil value) {
                 coreExceptions().typeError("no implicit conversion from nil to integer", this));
     }
 
-    @Specialization(guards = { "!isRubyInteger(object)", "!isNil(object)" })
+    @Specialization(guards = { "!isRubyInteger(object)", "!isDouble(object)", "!isNil(object)" })
     protected int coerceObject(Object object,
             @Cached CallDispatchHeadNode toIntNode,
             @Cached ToIntNode fitNode) {

src/main/java/org/truffleruby/core/cast/ToLongNode.java

@@ -78,7 +78,7 @@ protected long coerceNil(Nil nil) {
                 coreExceptions().typeError("no implicit conversion from nil to integer", this));
     }
 
-    @Specialization(guards = { "!isRubyInteger(object)", "!isNil(object)" })
+    @Specialization(guards = { "!isRubyInteger(object)", "!isDouble(object)", "!isNil(object)" })
     protected long coerceObject(Object object,
             @Cached CallDispatchHeadNode toIntNode,
             @Cached ToLongNode fitNode) {