[GR-27459] Move setRope to RubyString

PullRequest: truffleruby/2178

Author: bjfish

src/main/java/org/truffleruby/cext/CExtNodes.java

@@ -501,7 +501,7 @@ protected RubyString clearCodeRange(RubyString string,
                 @Cached StringToNativeNode stringToNativeNode) {
             final NativeRope nativeRope = stringToNativeNode.executeToNative(string);
             nativeRope.clearCodeRange();
-            StringOperations.setRope(string, nativeRope);
+            string.setRope(nativeRope);
 
             return string;
         }
@@ -623,7 +623,7 @@ protected RubyString strSetLen(RubyString string, int newByteLength,
             }
 
             final NativeRope newNativeRope = nativeRope.withByteLength(newByteLength, newCharacterLength, newCodeRange);
-            StringOperations.setRope(string, newNativeRope);
+            string.setRope(newNativeRope);
 
             return string;
         }
@@ -648,7 +648,7 @@ protected RubyString rbStrResize(RubyString string, int newByteLength,
                 // Like MRI's rb_str_resize()
                 newRope.clearCodeRange();
 
-                StringOperations.setRope(string, newRope);
+                string.setRope(newRope);
                 return string;
             }
         }
@@ -1001,7 +1001,7 @@ protected NativeRope toNative(RubyString string,
                         currentRope.getEncoding(),
                         characterLengthNode.execute(currentRope),
                         codeRangeNode.execute(currentRope));
-                StringOperations.setRope(string, nativeRope);
+                string.setRope(nativeRope);
             }
 
             return nativeRope;
@@ -1102,7 +1102,7 @@ protected int write(RubyString string, int index, int value,
 
             final Rope newRope = setByteNode.executeSetByte(rope, index, value);
             if (newRopeProfile.profile(newRope != rope)) {
-                StringOperations.setRope(string, newRope);
+                string.setRope(newRope);
             }
 
             return value;

src/main/java/org/truffleruby/core/encoding/EncodingConverterNodes.java

@@ -46,7 +46,6 @@
 import org.truffleruby.core.string.EncodingUtils;
 import org.truffleruby.core.string.RubyString;
 import org.truffleruby.core.string.StringNodes;
-import org.truffleruby.core.string.StringOperations;
 import org.truffleruby.core.string.StringUtils;
 import org.truffleruby.core.symbol.RubySymbol;
 import org.truffleruby.language.Nil;
@@ -314,7 +313,7 @@ private Object primitiveConvertHelper(RubyEncodingConverter encodingConverter, O
 
                 if (nonNullSource) {
                     sourceRope = substringNode.executeSubstring(sourceRope, inPtr.p, sourceRope.byteLength() - inPtr.p);
-                    StringOperations.setRope((RubyString) source, sourceRope);
+                    ((RubyString) source).setRope(sourceRope);
                 }
 
                 if (growOutputBuffer && res == EConvResult.DestinationBufferFull) {
@@ -331,7 +330,7 @@ private Object primitiveConvertHelper(RubyEncodingConverter encodingConverter, O
                     outBytes.setEncoding(ec.destinationEncoding);
                 }
 
-                StringOperations.setRope(target, RopeOperations.ropeFromRopeBuilder(outBytes));
+                target.setRope(RopeOperations.ropeFromRopeBuilder(outBytes));
 
                 return getSymbol(res.symbolicName());
             }

src/main/java/org/truffleruby/core/string/RubyString.java

@@ -46,6 +46,10 @@ public RubyString(RubyClass rubyClass, Shape shape, boolean frozen, boolean tain
         this.rope = rope;
     }
 
+    public void setRope(Rope rope) {
+        this.rope = rope;
+    }
+
     /** should only be used for debugging */
     @Override
     public String toString() {