[GR-25977] Make LookupMethodNode return null for foreign objects, to speed up inlined node performance.

PullRequest: truffleruby/1974

Author: Nicolas Laurent

src/main/java/org/truffleruby/core/inlined/InlinedIsANode.java

@@ -28,10 +28,7 @@ public InlinedIsANode(RubyContext context, RubyCallNodeParameters callNodeParame
     }
 
     @Specialization(
-            guards = {
-                    "isRubyValue(self)",
-                    "lookupNode.lookupProtected(frame, self, METHOD) == coreMethods().KERNEL_IS_A",
-            },
+            guards = "lookupNode.lookupProtected(frame, self, METHOD) == coreMethods().KERNEL_IS_A",
             assumptions = "assumptions",
             limit = "1")
     protected boolean doIsA(VirtualFrame frame, Object self, RubyModule module,

src/main/java/org/truffleruby/core/inlined/InlinedIsNilNode.java

@@ -35,9 +35,7 @@ protected boolean nil(Nil self) {
     }
 
     @Specialization(
-            guards = {
-                    "isRubyValue(self)",
-                    "lookup.lookupProtected(frame, self, METHOD) == coreMethods().KERNEL_IS_NIL", },
+            guards = "lookup.lookupProtected(frame, self, METHOD) == coreMethods().KERNEL_IS_NIL",
             assumptions = "assumptions",
             limit = "1")
     protected boolean notNil(VirtualFrame frame, Object self,

src/main/java/org/truffleruby/core/inlined/InlinedKindOfNode.java

@@ -28,10 +28,7 @@ public InlinedKindOfNode(RubyContext context, RubyCallNodeParameters callNodePar
     }
 
     @Specialization(
-            guards = {
-                    "isRubyValue(self)",
-                    "lookupNode.lookupProtected(frame, self, METHOD) == coreMethods().KERNEL_KIND_OF",
-            },
+            guards = "lookupNode.lookupProtected(frame, self, METHOD) == coreMethods().KERNEL_KIND_OF",
             assumptions = "assumptions",
             limit = "1")
     protected boolean doKindOf(VirtualFrame frame, Object self, RubyModule module,

src/main/java/org/truffleruby/language/methods/LookupMethodNode.java

@@ -21,7 +21,6 @@
 import org.truffleruby.language.arguments.RubyArguments;
 import org.truffleruby.language.dispatch.DispatchConfiguration;
 import org.truffleruby.language.objects.MetaClassNode;
-import org.truffleruby.utils.Utils;
 
 import com.oracle.truffle.api.CompilerAsserts;
 import com.oracle.truffle.api.TruffleLanguage;
@@ -33,7 +32,6 @@
 import com.oracle.truffle.api.frame.Frame;
 import com.oracle.truffle.api.frame.FrameInstance.FrameAccess;
 import com.oracle.truffle.api.frame.VirtualFrame;
-import com.oracle.truffle.api.profiles.BranchProfile;
 import com.oracle.truffle.api.profiles.ConditionProfile;
 
 /** Caches {@link ModuleOperations#lookupMethodCached(RubyModule, String, DeclarationContext)} on an actual instance. */
@@ -85,7 +83,7 @@ protected InternalMethod lookupMethodUncached(
             @Cached MetaClassNode metaClassNode,
             @Cached ConditionProfile noCallerMethodProfile,
             @Cached ConditionProfile isSendProfile,
-            @Cached BranchProfile foreignProfile,
+            @Cached ConditionProfile foreignProfile,
             @Cached ConditionProfile noPrependedModulesProfile,
             @Cached ConditionProfile onMetaClassProfile,
             @Cached ConditionProfile hasRefinementsProfile,
@@ -98,9 +96,8 @@ protected InternalMethod lookupMethodUncached(
 
         // Actual lookup
 
-        if (metaClass == context.getCoreLibrary().truffleInteropForeignClass) {
-            foreignProfile.enter();
-            throw Utils.unsupportedOperation("method lookup not supported on foreign objects");
+        if (foreignProfile.profile(metaClass == context.getCoreLibrary().truffleInteropForeignClass)) {
+            return null;
         }
 
         final DeclarationContext declarationContext = RubyArguments.tryGetDeclarationContext(frame);
@@ -163,7 +160,7 @@ protected static MethodLookupResult lookupCached(RubyContext context, Frame call
         CompilerAsserts.neverPartOfCompilation("slow-path method lookup should not be compiled");
 
         if (metaClass == context.getCoreLibrary().truffleInteropForeignClass) {
-            throw new UnsupportedOperationException("method lookup not supported on foreign objects");
+            return new MethodLookupResult(null);
         }
 
         final DeclarationContext declarationContext = RubyArguments.tryGetDeclarationContext(callingFrame);