Skip to content

Commit c11bee1

Browse files
committed
Mention that always-inlined core methods should not have too much logic
1 parent 64d1016 commit c11bee1

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/main/java/org/truffleruby/core/inlined/AlwaysInlinedMethodNode.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@
1616
/** A core method that should always be executed inline, without going through a CallTarget. That enables accessing the
1717
* caller frame efficiently and reliably. If called from a foreign language, then the caller frame will be null. Such a
1818
* method will not appear in backtraces. However, Ruby exceptions emitted from this node will be resent through a
19-
* CallTarget to get the proper backtrace. */
19+
* CallTarget to get the proper backtrace. Such a core method should not emit significantly more Graal nodes than a
20+
* non-inlined call, as Truffle cannot decide to not inline it, and that could lead to too big methods to compile. */
2021
@GenerateNodeFactory
2122
public abstract class AlwaysInlinedMethodNode extends RubyBaseNode {
2223

0 commit comments

Comments
 (0)