Add MatchData#match and MatchData#match_length

Author: horakivo

CHANGELOG.md

@@ -89,6 +89,7 @@ Compatibility:
 * Add optional `Hash` argument to `Enumerable#tally` (#2733, @andrykonchin).
 * Update `$LOAD_PATH.resolve_feature_path` to return `nil` instead of raising `LoadError` when feature isn't found (#2733, @andrykonchin).
 * Add `objspace/trace` file (#2733, @andrykonchin).
+* Add `MatchData#match` and `MatchData#match_length` (#2733, @horakivo).
 
 Performance:
 

spec/tags/core/matchdata/match_length_tags.txt

@@ -1013,6 +1013,7 @@ public boolean isTruffleBootMainMethod(SharedMethodInfo info) {
             "/core/truffle/ctype.rb",
             "/core/truffle/integer_operations.rb",
             "/core/integer.rb",
+            "/core/match_data.rb",
             "/core/regexp.rb",
             "/core/transcoding.rb",
             "/core/encoding.rb",
@@ -1058,7 +1059,6 @@ public boolean isTruffleBootMainMethod(SharedMethodInfo info) {
             "/core/posix.rb",
             "/core/main.rb",
             "/core/post.rb",
-            "/core/match_data.rb",
             POST_BOOT_FILE
     };
 

spec/tags/core/matchdata/match_tags.txt

@@ -137,6 +137,19 @@ def values_at(*indexes)
     out
   end
 
+  def match(n)
+    # Similar, but #match accepts only single index/name, but not a range or an optional length.
+    number = Truffle::Type.rb_check_convert_type(n, Integer, :to_int)
+    return self[number] if number
+    # To convert the last type (String) we used rb_convert_type instead of rb_check_convert_type which throws an exception
+    name = Truffle::Type.rb_check_convert_type(n, Symbol, :to_sym) || Truffle::Type.rb_convert_type(n, String, :to_str)
+    self[name]
+  end
+
+  def match_length(n)
+    match(n)&.length
+  end
+
   def to_s
     self[0]
   end

src/main/java/org/truffleruby/core/CoreLibrary.java

@@ -37,5 +37,3 @@
 exclude :test_rindex_regexp, "needs investigation"
 exclude :test_yoshidam_net_20041111_1, "needs investigation"
 exclude :test_match_control_meta_escape, "<0> expected but was"
-exclude :test_match_matchsubstring, "NoMethodError: undefined method `match' for #<MatchData \"HX1138\" 1:\"H\" 2:\"X\" 3:\"113\" 4:\"8\" 5:nil>"
-exclude :test_match_match_length, "NoMethodError: undefined method `match_length' for #<MatchData \"HX1138\" 1:\"H\" 2:\"X\" 3:\"113\" 4:\"8\" 5:nil>"