[GR-14684] Add bootstraptest and basictest

PullRequest: truffleruby/736

Author: chrisseaton

ci.jsonnet

@@ -406,6 +406,7 @@ local part_definitions = {
       ] + jt(["lint"]) + self.after_build,
     },
 
+    test_basictest: { run+: jt(["test", "basictest"]) },
     test_mri: { run+: jt(["test", "mri", "--no-sulong", "--", "-j4"]) },
     test_integration: { run+: jt(["test", "integration"]) },
     test_gems: { run+: jt(["test", "gems"]) },
@@ -536,7 +537,7 @@ local composition_environment = utils.add_inclusion_tracking(part_definitions, "
     {
       local linux_gate = $.platform.linux + $.cap.gate + $.jdk.labsjdk8 + $.use.common + $.use.build + { timelimit: "01:00:00" },
 
-      "ruby-test-specs-linux": linux_gate + $.run.test_unit_tck_specs + { timelimit: "35:00" },
+      "ruby-test-specs-linux": linux_gate + $.run.test_unit_tck_specs + $.run.test_basictest + { timelimit: "35:00" },
       "ruby-test-fast-linux":  linux_gate + $.run.test_fast + { timelimit: "30:00" }, # To catch missing slow tags
       "ruby-test-mri-linux":   linux_gate + $.run.test_mri + { timelimit: "30:00" },
       "ruby-test-integration": linux_gate + $.run.test_integration,
@@ -552,7 +553,7 @@ local composition_environment = utils.add_inclusion_tracking(part_definitions, "
     {
       local darwin_gate = $.platform.darwin + $.cap.gate + $.jdk.labsjdk8 + $.use.common + $.use.build + { timelimit: "01:00:00" },
 
-      "ruby-test-specs-darwin": darwin_gate + $.run.test_unit_tck_specs + { timelimit: "45:00" },
+      "ruby-test-specs-darwin": darwin_gate + $.run.test_unit_tck_specs + $.run.test_basictest + { timelimit: "45:00" },
       "ruby-test-mri-darwin":   darwin_gate + $.run.test_mri,
       "ruby-test-cexts-darwin": darwin_gate + $.use.gem_test_pack + $.run.test_cexts,
     } +

doc/contributor/testing.md

@@ -8,6 +8,8 @@ We talk about several types of tests in TruffleRuby:
 * TCK (`TCK`)
 * Specs (`SPECS`)
 * MRI tests (`MRI`)
+* MRI basictest (`BASIC`)
+* MRI bootstraptest (`BOOT`)
 * C extension tests (`CEXT`)
 * Bundler tests (`BUN`)
 * Compiler tests (`COMP`)
@@ -64,6 +66,23 @@ MRI tests are in `test/mri`.
 
 Run MRI tests with `jt test mri`.
 
+### MRI basictest
+
+MRI's basictest is a smaller set of tests for some basic control structures
+and language features. It is in `test/basictest`.
+
+Run basictest with `jt test basictest`.
+
+### MRI bootstraptest
+
+MRI's bootstraptest is a smaller set of tests for functionality they require
+to bootstrap their implementation, including some tests against regressions
+and corner cases. It is in `test/bootstraptest`.
+
+Run bootstraptest with `jt test bootstraptest`. It's not
+tractable to run bootstraptest with the JVM, as it starts a new Ruby process
+for each test. Run it with a native build instead.
+
 ### C extension tests
 
 C extension tests are a basic test of compiling, loading and running C
@@ -187,8 +206,8 @@ and configurations that aren't tested, due to limited resources.
 
 * `UNIT` with `INT` on `J8` on Linux.
 * `UNIT` with `INT` on `J8` on macOS.
-* `SPEC` with `INT` on `J8` on Linux.
-* `SPEC` with `INT` on `J8` on macOS.
+* `BASICTEST`, `SPEC` with `INT` on `J8` on Linux.
+* `BASICTEST`, `SPEC` with `INT` on `J8` on macOS.
 * `SPEC(FAST)` with `INT` on `J11` on Linux.
 * `TCK` with `INT` on `J8` on Linux.
 * `MRI` with `INT` on `J8` on Linux.

src/main/java/org/truffleruby/core/CoreLibrary.java

@@ -1088,6 +1088,10 @@ public DynamicObject getKernelModule() {
         return kernelModule;
     }
 
+    public DynamicObject getErrnoModule() {
+        return errnoModule;
+    }
+
     public GlobalVariables getGlobalVariables() {
         return globalVariables;
     }

src/main/java/org/truffleruby/language/loader/FeatureLoader.java

@@ -154,7 +154,7 @@ public String getWorkingDirectory() {
         final Pointer buffer = GetThreadBufferNode.getBuffer(context, bufferSize);
         final long address = nfi.asPointer((TruffleObject) getcwd.call(buffer.getAddress(), bufferSize));
         if (address == 0) {
-            throw new UnsupportedOperationException("getcwd() failed");
+            context.send(context.getCoreLibrary().getErrnoModule(), "handle");
         }
         final byte[] bytes = buffer.readZeroTerminatedByteArray(context, 0);
         final Encoding localeEncoding = context.getEncodingManager().getLocaleEncoding();

src/main/ruby/core/kernel.rb

@@ -559,7 +559,7 @@ def trace_var(name, cmd = nil, &block)
   end
   module_function :trace_var
 
-  def untrace_var(name, cmd)
+  def untrace_var(name, cmd=undefined)
     # Truffle: not yet implemented
   end
   module_function :untrace_var

test/basictest/runner.rb

@@ -0,0 +1,38 @@
+#! ./miniruby
+
+exit if defined?(CROSS_COMPILING) and CROSS_COMPILING
+ruby = ENV["RUBY"]
+unless ruby
+  if RUBY_ENGINE == 'truffleruby'
+    require 'rbconfig'
+    ruby = RbConfig.ruby
+  else
+    load './rbconfig.rb'
+    ruby = "./#{RbConfig::CONFIG['ruby_install_name']}#{RbConfig::CONFIG['EXEEXT']}"
+  end
+end
+unless File.exist? ruby
+  print "#{ruby} is not found.\n"
+  print "Try `make' first, then `make test', please.\n"
+  exit false
+end
+ARGV[0] and opt = ARGV[0][/\A--run-opt=(.*)/, 1] and ARGV.shift
+
+$stderr.reopen($stdout)
+error = ''
+
+srcdir = File.expand_path('..', File.dirname(__FILE__))
+if env = ENV["RUBYOPT"]
+  ENV["RUBYOPT"] = env + " -W1"
+end
+`#{ruby} #{opt} -W1 #{srcdir}/basictest/test.rb #{ARGV.join(' ')}`.each_line do |line|
+  if line =~ /^end of test/
+    print "\ntest succeeded\n"
+    exit true
+  end
+  error << line if %r:^(basictest/test.rb|not): =~ line
+end
+puts
+print error
+print "test failed\n"
+exit false