Add specs for ObjectSpace#reachable_objects_from

Author: eregon

spec/ruby/library/objectspace/reachable_objects_from_spec.rb

@@ -0,0 +1,61 @@
+require_relative '../../spec_helper'
+require 'objspace'
+
+describe "ObjectSpace.reachable_objects_from" do
+  it "returns nil for true and false" do
+    ObjectSpace.reachable_objects_from(true).should == nil
+    ObjectSpace.reachable_objects_from(false).should == nil
+  end
+
+  it "returns nil for nil" do
+    ObjectSpace.reachable_objects_from(nil).should == nil
+  end
+
+  it "returns nil for small Integers" do
+    ObjectSpace.reachable_objects_from(42).should == nil
+  end
+
+  it "enumerates objects directly reachable from a given object" do
+    ObjectSpace.reachable_objects_from(['a', 'b', 'c']).should include(Array, 'a', 'b', 'c')
+    ObjectSpace.reachable_objects_from(Object.new).should == [Object]
+  end
+
+  it "finds an object stored in an Array" do
+    obj = Object.new
+    ary = [obj]
+    reachable = ObjectSpace.reachable_objects_from(ary)
+    reachable.should include(obj)
+  end
+
+  it "finds an object stored in a copy-on-write Array" do
+    removed = Object.new
+    obj = Object.new
+    ary = [removed, obj]
+    ary.shift
+    reachable = ObjectSpace.reachable_objects_from(ary)
+    reachable.should include(obj)
+    reachable.should_not include(removed)
+  end
+
+  it "finds an object stored in a Queue" do
+    require 'thread'
+    o = Object.new
+    q = Queue.new
+    q << o
+
+    reachable = ObjectSpace.reachable_objects_from(q)
+    reachable = reachable + reachable.flat_map { |r| ObjectSpace.reachable_objects_from(r) }
+    reachable.should include(o)
+  end
+
+  it "finds an object stored in a SizedQueue" do
+    require 'thread'
+    o = Object.new
+    q = SizedQueue.new(3)
+    q << o
+
+    reachable = ObjectSpace.reachable_objects_from(q)
+    reachable = reachable + reachable.flat_map { |r| ObjectSpace.reachable_objects_from(r) }
+    reachable.should include(o)
+  end
+end

spec/tags/library/objectspace/reachable_objects_from_tags.txt

@@ -0,0 +1 @@
+fails:ObjectSpace.reachable_objects_from returns nil for nil

spec/truffle/objspace/reachable_objects_from_spec.rb

@@ -12,12 +12,10 @@
 
 describe "ObjectSpace.reachable_objects_from" do
 
-  # This is a standard method, but our implementation returns more objects so we keep this spec here
+  # This is a standard method, but our implementation returns more objects so we add extra specs here
 
-  it "enumerates objects directly reachable from a given object" do
+  it "returns [NilClass] for nil" do
     ObjectSpace.reachable_objects_from(nil).should == [NilClass]
-    ObjectSpace.reachable_objects_from(['a', 'b', 'c']).should include(Array, 'a', 'b', 'c')
-    ObjectSpace.reachable_objects_from(Object.new).should == [Object]
   end
 
   it "finds the superclass and included/prepended modules of a class" do
@@ -46,43 +44,6 @@
     reachable.should include(captured)
   end
 
-  it "finds an object stored in an Array" do
-    obj = Object.new
-    ary = [obj]
-    reachable = ObjectSpace.reachable_objects_from(ary)
-    reachable.should include(obj)
-  end
-
-  it "finds an object stored in a copy-on-write Array" do
-    removed = Object.new
-    obj = Object.new
-    ary = [removed, obj]
-    ary.shift
-    reachable = ObjectSpace.reachable_objects_from(ary)
-    reachable.should include(obj)
-    reachable.should_not include(removed)
-  end
-
-  it "finds an object stored in a Queue" do
-    require 'thread'
-    o = Object.new
-    q = Queue.new
-    q << o
-
-    reachable = ObjectSpace.reachable_objects_from(q)
-    reachable.should include(o)
-  end
-
-  it "finds an object stored in a SizedQueue" do
-    require 'thread'
-    o = Object.new
-    q = SizedQueue.new(3)
-    q << o
-
-    reachable = ObjectSpace.reachable_objects_from(q)
-    reachable.should include(o)
-  end
-
   it "finds finalizers" do
     object = Object.new
     finalizer = proc { }