Skip to content

Commit b9e3c90

Browse files
committed
[GR-27287] Mark core and standard library as non-internal by default
* Since for backtrace purposes they should be considered not internal. * However it is unclear if they should be considered internal for tools such as profilers and debuggers.
1 parent 8ec0757 commit b9e3c90

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

src/main/java/org/truffleruby/options/Options.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,9 +75,9 @@ public class Options {
7575
public final boolean TRACE_CALLS;
7676
/** --coverage-global=false */
7777
public final boolean COVERAGE_GLOBAL;
78-
/** --core-as-internal=true */
78+
/** --core-as-internal=false */
7979
public final boolean CORE_AS_INTERNAL;
80-
/** --stdlib-as-internal=true */
80+
/** --stdlib-as-internal=false */
8181
public final boolean STDLIB_AS_INTERNAL;
8282
/** --exceptions-store-java=false */
8383
public final boolean EXCEPTIONS_STORE_JAVA;

src/options.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ EXPERT:
5252
COVERAGE_GLOBAL: [coverage-global, boolean, false, Run coverage for all code and print results on exit]
5353

5454
# Options helpful in for debugging, potentially also for user code
55-
CORE_AS_INTERNAL: [core-as-internal, boolean, true, 'Mark core library sources as internal']
56-
STDLIB_AS_INTERNAL: [stdlib-as-internal, boolean, true, 'Mark stdlib sources as internal']
55+
CORE_AS_INTERNAL: [core-as-internal, boolean, false, 'Mark core library sources as internal']
56+
STDLIB_AS_INTERNAL: [stdlib-as-internal, boolean, false, 'Mark stdlib sources as internal']
5757
LAZY_TRANSLATION_USER: [lazy-translation-user, boolean, DEFAULT_LAZY, 'Lazily translation of stdlib, gem and user source files']
5858

5959
# Options to tweak backtraces

src/shared/java/org/truffleruby/shared/options/OptionsCatalog.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ public class OptionsCatalog {
4747
public static final OptionKey<Boolean> HOST_INTEROP_KEY = new OptionKey<>(true);
4848
public static final OptionKey<Boolean> TRACE_CALLS_KEY = new OptionKey<>(true);
4949
public static final OptionKey<Boolean> COVERAGE_GLOBAL_KEY = new OptionKey<>(false);
50-
public static final OptionKey<Boolean> CORE_AS_INTERNAL_KEY = new OptionKey<>(true);
51-
public static final OptionKey<Boolean> STDLIB_AS_INTERNAL_KEY = new OptionKey<>(true);
50+
public static final OptionKey<Boolean> CORE_AS_INTERNAL_KEY = new OptionKey<>(false);
51+
public static final OptionKey<Boolean> STDLIB_AS_INTERNAL_KEY = new OptionKey<>(false);
5252
public static final OptionKey<Boolean> LAZY_TRANSLATION_USER_KEY = new OptionKey<>(DEFAULT_LAZY_KEY.getDefaultValue());
5353
public static final OptionKey<Boolean> EXCEPTIONS_STORE_JAVA_KEY = new OptionKey<>(false);
5454
public static final OptionKey<Boolean> EXCEPTIONS_PRINT_JAVA_KEY = new OptionKey<>(false);

0 commit comments

Comments
 (0)