[GR-15950] Use a random port for Bundler tests to avoid binding conflicts.

PullRequest: truffleruby/852

Author: eregon

test/truffle/common.sh.inc

@@ -9,11 +9,7 @@ function test_server {
   serverpid=$!
   echo "Server PID: $serverpid"
 
-  ports=""
-  while [ -z "$ports" ]; do
-    ports=$(lsof -P -i 4 -a -p $serverpid -Fn | grep nlocalhost | cut -d ':' -f 2)
-    sleep 1
-  done
+  ports=$(jt find_ports_for_pid "$serverpid")
 
   if [[ $(echo "$ports" | wc -l) -gt 1 ]]; then
     echo "More than one port opened!" >&2

tool/jt.rb

@@ -1257,6 +1257,14 @@ def test_ecosystem(*args)
   end
   private :test_ecosystem
 
+  def find_ports_for_pid(pid)
+    while (ports = `lsof -P -i 4 -a -p #{pid} -Fn | grep nlocalhost | cut -d ':' -f 2`.strip).empty?
+      sleep 1
+    end
+    puts ports
+    ports
+  end
+
   def test_bundle(*args)
     require 'tmpdir'
 
@@ -1267,8 +1275,12 @@ def test_bundle(*args)
     ]
     gems = %w[algebrick]
 
-    gem_server = spawn('gem', 'server', '-b', '127.0.0.1', '-d', "#{gem_test_pack}/gems")
+    gem_server = spawn('gem', 'server', '-b', '127.0.0.1', '-p', '0', '-d', "#{gem_test_pack}/gems")
     begin
+      ports = find_ports_for_pid(gem_server)
+      raise "More than one port opened" if ports.lines.size > 1
+      port = Integer(ports)
+
       bundle_install_flags.each do |install_flags|
         puts "Testing Bundler with install flags: #{install_flags}"
         gems.each do |gem_name|
@@ -1289,12 +1301,10 @@ def test_bundle(*args)
                 # add bin from gem_home to PATH
                 'PATH' => ["#{gem_home}/bin", ENV['PATH']].join(File::PATH_SEPARATOR))
 
-              options = [
-                '--experimental-options',
-                '--exceptions-print-java',
-              ]
+              options = %w[--experimental-options --exceptions-print-java]
 
-              gemserver_source = %w[--clear-sources --source http://localhost:8808]
+              run_ruby(environment, *args, *options,
+                '-Sbundle', 'config', '--local', 'mirror.http://localhost:8808', "http://localhost:#{port}")
 
               run_ruby(environment, *args, *options,
                 '-Sbundle', 'install', '-V', *install_flags)