Warn on unused value

PullRequest: truffleruby/752

Author: eregon

lib/cext/include/internal.h

@@ -4,9 +4,6 @@
 #define LIKELY(x)             RB_LIKELY(x)
 #define UNLIKELY(x)           RB_UNLIKELY(x)
 
-#define RHASH_ST_TABLE(hash)  (hash, false)
-#define RHASH_TBL_RAW(hash)   (hash, false)
-
 #define STR_EMBED_P(str)      (str, false)
 #define STR_SHARED_P(str)     (str, false)
 

lib/cext/include/ruby/st.h

@@ -143,8 +143,6 @@ CONSTFUNC(st_index_t st_hash_end(st_index_t h));
 CONSTFUNC(st_index_t st_hash_start(st_index_t h));
 #define st_hash_start(h) ((st_index_t)(h))
 
-void rb_hash_bulk_insert_into_st_table(long, const VALUE *, VALUE);
-
 RUBY_SYMBOL_EXPORT_END
 
 #if defined(__cplusplus)

lib/truffle/rbconfig-for-mkmf.rb

@@ -70,7 +70,6 @@
   '-Wno-unknown-warning-option',     # If we're on an earlier version of clang without a warning option, ignore it
   '-Wno-int-conversion',             # MRI has VALUE defined as long while we have it as void*
   '-Wno-int-to-pointer-cast',        # Same as above
-  '-Wno-unused-value',               # RB_GC_GUARD leaves
   '-Wno-incompatible-pointer-types', # Fix byebug 8.2.1 compile (st_data_t error)
   '-ferror-limit=500'
 ].join(' ')

src/main/c/cext/st.c

@@ -2289,25 +2289,4 @@ st_insert_generic(st_table *tab, long argc, const VALUE *argv, VALUE hash)
     /* reindex */
     st_rehash(tab);
 }
-
-/* Mimics ruby's { foo => bar } syntax. This function is subpart
-   of rb_hash_bulk_insert. */
-void
-rb_hash_bulk_insert_into_st_table(long argc, const VALUE *argv, VALUE hash)
-{
-    st_index_t n, size = argc / 2;
-    st_table *tab = RHASH_ST_TABLE(hash);
-
-    tab = RHASH_TBL_RAW(hash);
-    n = tab->entries_bound + size;
-    st_expand_table(tab, n);
-    if (UNLIKELY(tab->num_entries))
-        st_insert_generic(tab, argc, argv, hash);
-    else if (argc <= 2)
-        st_insert_single(tab, hash, argv[0], argv[1]);
-    else if (tab->bin_power <= MAX_POWER2_FOR_TABLES_WITHOUT_BINS)
-        st_insert_linear(tab, argc, argv, hash);
-    else
-        st_insert_generic(tab, argc, argv, hash);
-}
 #endif