[GR-14806] Update specs.

PullRequest: truffleruby/918

Author: eregon

spec/mspec/README.md

@@ -38,7 +38,7 @@ specs in a manner compatible with multiple Ruby implementations.
 
 ## Requirements
 
-MSpec requires Ruby 2.3 or more recent.
+MSpec requires Ruby 2.4 or more recent.
 
 ## Bundler
 

spec/mspec/lib/mspec/utils/script.rb

@@ -39,8 +39,8 @@ def self.get(key)
   end
 
   def initialize
-    ruby_version_is ""..."2.3" do
-      abort "MSpec needs Ruby 2.3 or more recent"
+    ruby_version_is ""..."2.4" do
+      abort "MSpec needs Ruby 2.4 or more recent"
     end
 
     config[:formatter] = nil

spec/ruby/.mspec.constants

@@ -78,7 +78,7 @@ Find
 Forwardable
 GetoptLong
 HMACConstants
-HashStringsASCII8BIT
+HashStringsBinary
 HashStringsUSASCII
 HashStringsUTF8
 IPAddr

spec/ruby/command_line/dash_upper_k_spec.rb

@@ -6,24 +6,24 @@
   end
 
   describe 'sets __ENCODING__ and Encoding.default_external' do
-    it "to Encoding::ASCII_8BIT with -Ka" do
+    it "to Encoding::BINARY with -Ka" do
       ruby_exe(@test_string, options: '-Ka').should ==
-        [Encoding::ASCII_8BIT.name, Encoding::ASCII_8BIT.name, nil].inspect
+        [Encoding::BINARY.name, Encoding::BINARY.name, nil].inspect
     end
 
-    it "to Encoding::ASCII_8BIT with -KA" do
+    it "to Encoding::BINARY with -KA" do
       ruby_exe(@test_string, options: '-KA').should ==
-        [Encoding::ASCII_8BIT.name, Encoding::ASCII_8BIT.name, nil].inspect
+        [Encoding::BINARY.name, Encoding::BINARY.name, nil].inspect
     end
 
-    it "to Encoding::ASCII_8BIT with -Kn" do
+    it "to Encoding::BINARY with -Kn" do
       ruby_exe(@test_string, options: '-Kn').should ==
-        [Encoding::ASCII_8BIT.name, Encoding::ASCII_8BIT.name, nil].inspect
+        [Encoding::BINARY.name, Encoding::BINARY.name, nil].inspect
     end
 
-    it "to Encoding::ASCII_8BIT with -KN" do
+    it "to Encoding::BINARY with -KN" do
       ruby_exe(@test_string, options: '-KN').should ==
-        [Encoding::ASCII_8BIT.name, Encoding::ASCII_8BIT.name, nil].inspect
+        [Encoding::BINARY.name, Encoding::BINARY.name, nil].inspect
     end
 
     it "to Encoding::EUC_JP with -Ke" do

spec/ruby/command_line/dash_x_spec.rb

@@ -18,6 +18,4 @@
     result = ruby_exe(embedded_ruby)
     result.should == "success\n"
   end
-
-  it "needs to be reviewed for spec completeness"
 end

spec/ruby/command_line/frozen_strings_spec.rb

@@ -22,7 +22,8 @@
 describe "The --debug flag produces" do
   it "debugging info on attempted frozen string modification" do
     error_str = ruby_exe(fixture(__FILE__, 'debug_info.rb'), options: '--debug',  args: "2>&1")
-    error_str.should include("can't modify frozen String, created at ")
+    error_str.should include("can't modify frozen String")
+    error_str.should include("created at")
     error_str.should include("command_line/fixtures/debug_info.rb:2")
   end
 end

spec/ruby/command_line/shared/verbose.rb

@@ -4,6 +4,6 @@
   end
 
   it "sets $VERBOSE to true" do
-    ruby_exe(@script, options: @method).chomp.split.last.should == "true"
+    ruby_exe(@script, options: @method).chomp.b.split.last.should == "true"
   end
 end

spec/ruby/core/argf/binmode_spec.rb

@@ -31,13 +31,13 @@
     end
   end
 
-  it "sets the file's encoding to ASCII-8BIT" do
+  it "sets the file's encoding to BINARY" do
     argf [@bin_file, @file1] do
       @argf.binmode
       @argf.binmode?.should == true
-      @argf.gets.encoding.should == Encoding::ASCII_8BIT
+      @argf.gets.encoding.should == Encoding::BINARY
       @argf.skip
-      @argf.read.encoding.should == Encoding::ASCII_8BIT
+      @argf.read.encoding.should == Encoding::BINARY
     end
   end
 end

spec/ruby/core/array/equal_value_spec.rb

@@ -44,8 +44,8 @@
     [obj].should == [5]
   end
 
-  # As per bug #1720
-  it "returns false for [NaN] == [NaN]" do
-    [nan_value].should_not == [nan_value]
+  # See https://bugs.ruby-lang.org/issues/1720
+  it "returns true for [NaN] == [NaN] because Array#== first checks with #equal? and NaN.equal?(NaN) is true" do
+    [Float::NAN].should == [Float::NAN]
   end
 end

spec/ruby/core/array/fixtures/encoded_strings.rb

@@ -37,33 +37,33 @@ def self.array_with_usascii_and_utf8_strings
     ]
   end
 
-  def self.array_with_utf8_and_7bit_ascii8bit_strings
+  def self.array_with_utf8_and_7bit_binary_strings
     [
       'bar',
       'báz',
-      'foo'.force_encoding('ASCII-8BIT')
+      'foo'.force_encoding('BINARY')
     ]
   end
 
-  def self.array_with_utf8_and_ascii8bit_strings
+  def self.array_with_utf8_and_binary_strings
     [
       'bar',
       'báz',
-      [255].pack('C').force_encoding('ASCII-8BIT')
+      [255].pack('C').force_encoding('BINARY')
     ]
   end
 
-  def self.array_with_usascii_and_7bit_ascii8bit_strings
+  def self.array_with_usascii_and_7bit_binary_strings
     [
       'bar'.force_encoding('US-ASCII'),
-      'foo'.force_encoding('ASCII-8BIT')
+      'foo'.force_encoding('BINARY')
     ]
   end
 
-  def self.array_with_usascii_and_ascii8bit_strings
+  def self.array_with_usascii_and_binary_strings
     [
       'bar'.force_encoding('US-ASCII'),
-      [255].pack('C').force_encoding('ASCII-8BIT')
+      [255].pack('C').force_encoding('BINARY')
     ]
   end
 end