Add spec for AssertionError thrown in a Ruby Thread

(cherry picked from commit 8769a29)

Author: eregon

spec/tags/truffle/java_exception_tags.txt

@@ -0,0 +1 @@
+slow:Java exceptions AssertionError in another Thread is rethrown on the main Ruby Thread

spec/truffle/java_exception_spec.rb

@@ -61,4 +61,18 @@
     }
   end
 
+  it "AssertionError in another Thread is rethrown on the main Ruby Thread" do
+    code = <<-RUBY
+    Thread.new do
+      Truffle::Debug.throw_assertion_error('custom_assertion_error_message')
+    end
+    sleep
+    RUBY
+
+    out = ruby_exe(code, args: "2>&1")
+    $?.exitstatus.should == 1
+    out.should.include?('terminated with internal error')
+    out.should.include?('Caused by:')
+    out.should.include?('custom_assertion_error_message (AssertionError)')
+  end
 end

src/main/java/org/truffleruby/debug/TruffleDebugNodes.java

@@ -401,9 +401,9 @@ static void warning(String message) {
     public abstract static class ThrowJavaExceptionNode extends CoreMethodArrayArgumentsNode {
 
         @TruffleBoundary
-        @Specialization
-        protected Object throwJavaException(Object message) {
-            callingMethod(message.toString());
+        @Specialization(guards = "isRubyString(message)")
+        protected Object throwJavaException(DynamicObject message) {
+            callingMethod(StringOperations.getString(message));
             return nil;
         }
 
@@ -423,21 +423,32 @@ private static void throwingMethod(String message) {
     public abstract static class ThrowJavaExceptionWithCauseNode extends CoreMethodArrayArgumentsNode {
 
         @TruffleBoundary
-        @Specialization
-        protected DynamicObject throwJavaExceptionWithCause(Object message) {
+        @Specialization(guards = "isRubyString(message)")
+        protected Object throwJavaExceptionWithCause(DynamicObject message) {
             throw new RuntimeException(
-                    message.toString(),
+                    StringOperations.getString(message),
                     new RuntimeException("cause 1", new RuntimeException("cause 2")));
         }
 
     }
 
+    @CoreMethod(names = "throw_assertion_error", onSingleton = true, required = 1)
+    public abstract static class ThrowAssertionErrorNode extends CoreMethodArrayArgumentsNode {
+
+        @TruffleBoundary
+        @Specialization(guards = "isRubyString(message)")
+        protected Object throwAssertionError(DynamicObject message) {
+            throw new AssertionError(StringOperations.getString(message));
+        }
+
+    }
+
     @CoreMethod(names = "assert", onSingleton = true, required = 1)
     public abstract static class AssertNode extends CoreMethodArrayArgumentsNode {
 
         @TruffleBoundary
         @Specialization
-        protected Object throwJavaException(boolean condition) {
+        protected Object doAssert(boolean condition) {
             assert condition;
             return nil;
         }
@@ -805,7 +816,7 @@ protected String toDisplayString(boolean allowSideEffects) {
         @TruffleBoundary
         @Specialization(guards = "isRubyString(string)")
         protected Object foreignString(DynamicObject string) {
-            return new ForeignString(string.toString());
+            return new ForeignString(StringOperations.getString(string));
         }
 
     }