Lint: Prefer getOrCompute() to computeIfAbsent()

Author: eregon

src/main/java/org/truffleruby/collections/ConcurrentOperations.java

@@ -19,7 +19,7 @@ public abstract class ConcurrentOperations {
      * Replaces {@link ConcurrentHashMap#computeIfAbsent(Object, Function)} as it does not scale.
      * The JDK method takes a monitor for every access if the key is present.
      * See https://bugs.openjdk.java.net/browse/JDK-8161372 which only fixes it in Java 9
-     * if they are no collisions in the bucket.
+     * if there are no collisions in the bucket.
      * This method might execute the function multiple times, in contrast to computeIfAbsent().
      */
     public static <K, V> V getOrCompute(Map<K, V> map, K key, Function<? super K, ? extends V> compute) {

src/main/java/org/truffleruby/language/loader/FeatureLoader.java

@@ -25,6 +25,7 @@
 import org.truffleruby.RubyLanguage;
 import org.truffleruby.cext.WrapNodeGen;
 import org.truffleruby.cext.WrapNode;
+import org.truffleruby.collections.ConcurrentOperations;
 import org.truffleruby.core.array.ArrayOperations;
 import org.truffleruby.core.encoding.EncodingManager;
 import org.truffleruby.core.support.IONodes.GetThreadBufferNode;
@@ -85,7 +86,7 @@ public void addAutoload(RubyConstant autoloadConstant) {
 
         registeredAutoloadsLock.lock();
         try {
-            final Map<String, RubyConstant> constants = registeredAutoloads.computeIfAbsent(basename, k -> new HashMap<>());
+            final Map<String, RubyConstant> constants = ConcurrentOperations.getOrCompute(registeredAutoloads, basename, k -> new HashMap<>());
             constants.put(StringOperations.getString(autoloadConstant.getAutoloadPath()), autoloadConstant);
         } finally {
             registeredAutoloadsLock.unlock();