[GR-13087] Test for "no properties"

PullRequest: truffleruby/716

Author: chrisseaton

.rubocop.yml

@@ -8,6 +8,7 @@ AllCops:
     - 'lib/truffle/date/delta/parser.rb' # generated code
     - 'lib/truffle/socket/mri.rb' # taken from MRI
     - 'lib/truffle/ffi/library.rb' # taken from FFI gem
+    - 'src/test/ruby/types.rb' # deliberately strange code for debugging purposes
 
 # Type 'Layout' (166):
 # Supports --auto-correct

src/test/java/org/truffleruby/RubyDebugTest.java

@@ -35,6 +35,7 @@
 import java.io.InputStream;
 import java.io.InputStreamReader;
 import java.io.Reader;
+import java.util.Collection;
 import java.util.LinkedList;
 import java.util.concurrent.atomic.AtomicInteger;
 
@@ -216,6 +217,56 @@ public void testEvalThrow() throws Throwable {
         assertExecutedOK("OK");
     }
 
+    @Ignore
+    @Test
+    public void testProperties() throws Throwable {
+        Source source = getSource("src/test/ruby/types.rb");
+        run.addLast(() -> {
+            assertNull(suspendedEvent);
+            assertNotNull(debuggerSession);
+            breakpoint = Breakpoint.newBuilder(DebuggerTester.getSourceImpl(source)).lineIs(27).build();
+            debuggerSession.install(breakpoint);
+        });
+        assertLocation(27, "nme + nm1",
+                        "name", "\"Panama\"", // Possible bug: should really the quotes be included?
+                        "cityArray", "[80, 97, 110, 97, 109, 97]",
+                        "citySum", "590",
+                        "weatherTemperature", "14",
+                        "blt", "true",
+                        "blf", "false",
+                        "null", "nil",
+                        "nm1", "1",
+                        "nm11", "1.111",
+                        "nme", "3.5e+46",
+                        "nc", "(2+3i)",
+                        "nr", "(5404319552844595/18014398509481984)",
+                        "str", "\"A String\"",
+                        "symbol", ":symbolic",
+                        "arr", "[1, \"2\", 3.56, true, nil, \"A String\"]",
+                        "hash", "{:a=>1, \"b\"=>2}");
+        run.addLast(() -> {
+            final DebugStackFrame frame = suspendedEvent.getTopStackFrame();
+            DebugValue value = frame.getScope().getDeclaredValue("name");
+            Collection<DebugValue> properties = value.getProperties();
+            assertTrue("String has " + properties.size() + " properties.", properties.size() > 0); // BUG: String have no properties
+            value = frame.getScope().getDeclaredValue("hash");
+            properties = value.getProperties();
+            assertEquals(2, properties.size()); // 'hash' has two properties
+            try {
+                properties.iterator().next().as(String.class);
+            } catch (IllegalStateException ex) {
+                "Value is not readable".equals(ex.getMessage()); // BUG
+                Assert.fail(ex.getMessage());
+            }
+            assertNotNull(value.getProperty("a")); // == null, BUG
+            assertEquals(0, frame.getScope().getDeclaredValue("symbol").getProperties().size());
+            assertEquals(6, frame.getScope().getDeclaredValue("arr").getArray().size());
+        });
+        performWork();
+        context.eval(source);
+        assertExecutedOK("OK");
+    }
+
     private void performWork() {
         try {
             if (ex == null && !run.isEmpty()) {

src/test/ruby/types.rb

@@ -0,0 +1,30 @@
+# Copyright (c) 2019 Oracle and/or its affiliates. All rights reserved. This
+# code is released under a tri EPL/GPL/LGPL license. You can use it,
+# redistribute it and/or modify it under the terms of the:
+#
+# Eclipse Public License version 1.0, or
+# GNU General Public License version 2, or
+# GNU Lesser General Public License version 2.1.
+
+# Beware, RubyDebugTest use hard-coded line numbers from this file!
+
+def temperature_in_city(name)
+  cityArray = name.bytes
+  citySum = cityArray.reduce(0, :+)
+  weatherTemperature = citySum.modulo(36)
+  blt = true
+  blf = false
+  null = nil
+  nm1 = 1
+  nm11 = 1.111
+  nme = 35e45
+  nc = 2 + 3i
+  nr = Rational(0.3)
+  str = 'A String'
+  symbol = :symbolic
+  arr = [1, '2', 3.56, blt, nil, str]
+  hash = {:a => 1, 'b' => 2}
+  nme + nm1
+end
+
+temperature_in_city('Panama')