Make check_real? a Primitive

* Removes two calls per call site calling that.

Author: eregon

src/main/java/org/truffleruby/core/support/TypeNodes.java

@@ -13,6 +13,7 @@
 import java.util.Arrays;
 import java.util.List;
 
+import com.oracle.truffle.api.profiles.ConditionProfile;
 import org.truffleruby.builtins.CoreMethod;
 import org.truffleruby.builtins.CoreMethodArrayArgumentsNode;
 import org.truffleruby.builtins.CoreModule;
@@ -43,6 +44,7 @@
 import org.truffleruby.language.RubyDynamicObject;
 import org.truffleruby.language.RubyNode;
 import org.truffleruby.language.control.RaiseException;
+import org.truffleruby.language.dispatch.DispatchNode;
 import org.truffleruby.language.library.RubyLibrary;
 import org.truffleruby.language.objects.IsANode;
 import org.truffleruby.language.objects.LogicalClassNode;
@@ -404,6 +406,35 @@ protected Object check(Object value,
         }
     }
 
+    @Primitive(name = "check_real?")
+    @NodeChild(value = "value", type = RubyNode.class)
+    public abstract static class CheckRealNode extends PrimitiveNode {
+        @Specialization
+        protected boolean check(int value) {
+            return true;
+        }
+
+        @Specialization
+        protected boolean check(long value) {
+            return true;
+        }
+
+        @Specialization
+        protected boolean check(double value) {
+            return true;
+        }
+
+        @Fallback
+        protected boolean other(Object value,
+                @Cached IsANode isANode,
+                @Cached ConditionProfile numericProfile,
+                @Cached DispatchNode isRealNode,
+                @Cached BooleanCastNode booleanCastNode) {
+            return numericProfile.profile(isANode.executeIsA(value, coreLibrary().numericClass)) &&
+                    booleanCastNode.executeToBoolean(isRealNode.call(value, "real?"));
+        }
+    }
+
     @Primitive(name = "undefined?")
     @NodeChild(value = "value", type = RubyNode.class)
     public abstract static class IsUndefinedNode extends PrimitiveNode {

src/main/ruby/truffleruby/core/complex.rb

@@ -41,7 +41,7 @@ class Complex < Numeric
                :round, :step, :truncate, :i, :negative?, :positive?
 
   def self.convert(real, imag = undefined, exception: true)
-    if check_real?(real) && check_real?(imag)
+    if Primitive.check_real?(real) && Primitive.check_real?(imag)
       return new(real, imag)
     end
 
@@ -99,22 +99,17 @@ def Complex.generic?(other) # :nodoc:
   end
 
   def Complex.rect(real, imag=0)
-    raise TypeError, 'not a real' unless check_real?(real) && check_real?(imag)
+    raise TypeError, 'not a real' unless Primitive.check_real?(real) && Primitive.check_real?(imag)
     new(real, imag)
   end
   class << self; alias_method :rectangular, :rect end
 
   def Complex.polar(r, theta=0)
-    raise TypeError, 'not a real' unless check_real?(r) && check_real?(theta)
+    raise TypeError, 'not a real' unless Primitive.check_real?(r) && Primitive.check_real?(theta)
 
     Complex(r*Math.cos(theta), r*Math.sin(theta))
   end
 
-  def Complex.check_real?(obj)
-    Primitive.object_kind_of?(obj, Numeric) && obj.real?
-  end
-  private_class_method :check_real?
-
   attr_reader :real, :imag
   alias_method :imaginary, :imag