Clear BigDecimal comparison specs

Author: chrisseaton

spec/tags/library/bigdecimal/gt_tags.txt

@@ -74,6 +74,7 @@ public static boolean isPrimitiveClass(Class<?> clazz) {
         return clazz == Boolean.class || clazz == Byte.class || clazz == Short.class || clazz == Integer.class
                 || clazz == Long.class || clazz == Float.class || clazz == Double.class;
     }
+
     // Ruby types
 
     public static boolean isRubyBasicObject(Object object) {
@@ -313,6 +314,10 @@ public static boolean isInfinity(double value) {
         return Double.isInfinite(value);
     }
 
+    public static boolean isFinite(double value) {
+        return Double.isFinite(value);
+    }
+
     public static boolean isPositive(double value) {
         return value >= 0;
     }

spec/tags/library/bigdecimal/gte_tags.txt

@@ -971,11 +971,27 @@ public int compare(DynamicObject a, long b) {
             return compareBigDecimal(a, BigDecimal.valueOf(b));
         }
 
-        @Specialization(guards = "isNormal(a)")
-        public int compare(DynamicObject a, double b) {
+        @Specialization(guards = {
+                "isNormal(a)",
+                "isFinite(b)"
+        })
+        public int compareFinite(DynamicObject a, double b) {
             return compareBigDecimal(a, valueOf(b));
         }
 
+        @Specialization(guards = {
+                "isNormal(a)",
+                "!isFinite(b)"
+        })
+        public Object compareNotFinite(DynamicObject a, double b) {
+            if (Double.isNaN(b)) {
+                return nil();
+            } else {
+                assert Double.isInfinite(b);
+                return b < 0 ? +1 : -1;
+            }
+        }
+
         @Specialization(guards = {
                 "isNormal(a)",
                 "isRubyBignum(b)"
@@ -997,11 +1013,28 @@ public Object compareSpecial(DynamicObject a, long b) {
             return compareSpecial(a, createBigDecimal(BigDecimal.valueOf(b)));
         }
 
-        @Specialization(guards = "!isNormal(a)")
-        public Object compareSpecial(DynamicObject a, double b) {
+        @Specialization(guards = {
+                "!isNormal(a)",
+                "isFinite(b)"
+        })
+        public Object compareSpecialFinite(DynamicObject a, double b) {
             return compareSpecial(a, createBigDecimal(valueOf(b)));
         }
 
+        @Specialization(guards = {
+                "!isNormal(a)",
+                "!isFinite(b)"
+        })
+        public Object compareSpecialInfinite(DynamicObject a, double b) {
+            final BigDecimalType type = Layouts.BIG_DECIMAL.getType(a);
+
+            if (type == BigDecimalType.NAN || Double.isNaN(b)) {
+                return nil();
+            } else {
+                return b < 0 ? +1 : -1;
+            }
+        }
+
         @Specialization(guards = {
                 "!isNormal(a)",
                 "isRubyBignum(b)"