[GR-20446] Fix Digest::Base#{update, <<}

PullRequest: truffleruby/1991

Author: bjfish

CHANGELOG.md

@@ -32,6 +32,7 @@ Compatibility:
 * Verify that gem paths are correct before loading RubyGems (#2075).
 * Implement `rb_ivar_count`.
 * Implemented `rb_yield_values2`.
+* Implemented `Digest::Base#{update, <<}` (#2100).
 
 Performance:
 

lib/truffle/digest.rb

@@ -79,7 +79,7 @@ def new
     end
 
     def update(message)
-      Truffle::Digest.update @digest, message
+      raise RuntimeError, "#{self.class.name} does not implement update()"
     end
     alias_method :<<, :update
 
@@ -154,6 +154,12 @@ def self.hexdigest(str, *args)
   end
 
   class Base < ::Digest::Class
+    def update(str)
+      str = StringValue(str)
+      Truffle::Digest.update(@digest, str)
+      self
+    end
+    alias_method :<<, :update
   end
 
   class MD5 < Base

spec/ruby/library/digest/instance/append_spec.rb

@@ -0,0 +1,7 @@
+require_relative '../../../spec_helper'
+require 'digest'
+require_relative 'shared/update'
+
+describe "Digest::Instance#<<" do
+  it_behaves_like :digest_instance_update, :<<
+end

spec/ruby/library/digest/instance/shared/update.rb

@@ -0,0 +1,8 @@
+describe :digest_instance_update, shared: true do
+  it "raises a RuntimeError if called" do
+    c = Class.new do
+      include Digest::Instance
+    end
+    -> { c.new.update("test") }.should raise_error(RuntimeError)
+  end
+end

spec/ruby/library/digest/instance/update_spec.rb

@@ -0,0 +1,7 @@
+require_relative '../../../spec_helper'
+require 'digest'
+require_relative 'shared/update'
+
+describe "Digest::Instance#update" do
+  it_behaves_like :digest_instance_update, :update
+end

spec/tags/truffle/methods_tags.txt

@@ -97,3 +97,8 @@ fails:Public methods on TracePoint should include instruction_sequence
 fails:Public methods on TracePoint should include parameters
 fails:Public methods on TracePoint should include raised_exception
 fails:Public methods on TracePoint should include return_value
+fails:Public methods on Digest::Base should include block_length
+fails:Public methods on Digest::Base should include digest_length
+fails:Public methods on Digest::Base should include reset
+fails:Public methods on Digest::MD5 should not include block_length
+fails:Public methods on Digest::SHA1 should not include block_length

spec/truffle/methods/Digest.txt

@@ -0,0 +1,5 @@
+<<
+block_length
+digest_length
+reset
+update