remove ROPE_DEPTH_THRESHOLD option

Author: Nicolas Laurent

src/main/java/org/truffleruby/options/Options.java

@@ -219,8 +219,6 @@ public class Options {
     public final int CEXTS_MARKING_CACHE;
     /** --cexts-tonative-stats=false */
     public final boolean CEXTS_TONATIVE_STATS;
-    /** --rope-depth-threshold=128 */
-    public final int ROPE_DEPTH_THRESHOLD;
     /** --global-variable-max-invalidations=1 */
     public final int GLOBAL_VARIABLE_MAX_INVALIDATIONS;
     /** --clone-default=true */
@@ -359,7 +357,6 @@ public Options(Env env, OptionValues options, LanguageOptions languageOptions) {
         PACK_RECOVER_LOOP_MIN = options.get(OptionsCatalog.PACK_RECOVER_LOOP_MIN_KEY);
         CEXTS_MARKING_CACHE = options.get(OptionsCatalog.CEXTS_MARKING_CACHE_KEY);
         CEXTS_TONATIVE_STATS = options.get(OptionsCatalog.CEXTS_TONATIVE_STATS_KEY);
-        ROPE_DEPTH_THRESHOLD = options.get(OptionsCatalog.ROPE_DEPTH_THRESHOLD_KEY);
         GLOBAL_VARIABLE_MAX_INVALIDATIONS = options.get(OptionsCatalog.GLOBAL_VARIABLE_MAX_INVALIDATIONS_KEY);
         CLONE_DEFAULT = options.get(OptionsCatalog.CLONE_DEFAULT_KEY);
         INLINE_DEFAULT = options.get(OptionsCatalog.INLINE_DEFAULT_KEY);
@@ -579,8 +576,6 @@ public Object fromDescriptor(OptionDescriptor descriptor) {
                 return CEXTS_MARKING_CACHE;
             case "ruby.cexts-tonative-stats":
                 return CEXTS_TONATIVE_STATS;
-            case "ruby.rope-depth-threshold":
-                return ROPE_DEPTH_THRESHOLD;
             case "ruby.global-variable-max-invalidations":
                 return GLOBAL_VARIABLE_MAX_INVALIDATIONS;
             case "ruby.clone-default":

src/options.yml

@@ -160,7 +160,6 @@ INTERNAL: # Options for debugging the TruffleRuby implementation
     PACK_RECOVER_LOOP_MIN: [pack-recover, integer, 32, 'If a pack or unpack expression is longer than this, attempt to recover loops']
     CEXTS_MARKING_CACHE: [cexts-marking-cache, integer, 100, 'Number of objects converted to native handles before the marking service is run']
     CEXTS_TONATIVE_STATS: [cexts-tonative-stats, boolean, false, Track the number of conversions of VALUEs to native and print the stats at application exit]
-    ROPE_DEPTH_THRESHOLD: [rope-depth-threshold, integer, 128, Threshold value at which ropes will be rebalanced (indirectly controls flattening as well)]
     GLOBAL_VARIABLE_MAX_INVALIDATIONS: [global-variable-max-invalidations, integer, 1, Maximum number of times a global variable can be changed to be considered constant]
 
     # Splitting and cloning, useful for debugging cloning

src/shared/java/org/truffleruby/shared/options/OptionsCatalog.java

@@ -128,7 +128,6 @@ public class OptionsCatalog {
     public static final OptionKey<Integer> PACK_RECOVER_LOOP_MIN_KEY = new OptionKey<>(32);
     public static final OptionKey<Integer> CEXTS_MARKING_CACHE_KEY = new OptionKey<>(100);
     public static final OptionKey<Boolean> CEXTS_TONATIVE_STATS_KEY = new OptionKey<>(false);
-    public static final OptionKey<Integer> ROPE_DEPTH_THRESHOLD_KEY = new OptionKey<>(128);
     public static final OptionKey<Integer> GLOBAL_VARIABLE_MAX_INVALIDATIONS_KEY = new OptionKey<>(1);
     public static final OptionKey<Boolean> CLONE_DEFAULT_KEY = new OptionKey<>(true);
     public static final OptionKey<Boolean> INLINE_DEFAULT_KEY = new OptionKey<>(true);
@@ -905,13 +904,6 @@ public class OptionsCatalog {
             .stability(OptionStability.EXPERIMENTAL)
             .build();
 
-    public static final OptionDescriptor ROPE_DEPTH_THRESHOLD = OptionDescriptor
-            .newBuilder(ROPE_DEPTH_THRESHOLD_KEY, "ruby.rope-depth-threshold")
-            .help("Threshold value at which ropes will be rebalanced (indirectly controls flattening as well)")
-            .category(OptionCategory.INTERNAL)
-            .stability(OptionStability.EXPERIMENTAL)
-            .build();
-
     public static final OptionDescriptor GLOBAL_VARIABLE_MAX_INVALIDATIONS = OptionDescriptor
             .newBuilder(GLOBAL_VARIABLE_MAX_INVALIDATIONS_KEY, "ruby.global-variable-max-invalidations")
             .help("Maximum number of times a global variable can be changed to be considered constant")
@@ -1263,8 +1255,6 @@ public static OptionDescriptor fromName(String name) {
                 return CEXTS_MARKING_CACHE;
             case "ruby.cexts-tonative-stats":
                 return CEXTS_TONATIVE_STATS;
-            case "ruby.rope-depth-threshold":
-                return ROPE_DEPTH_THRESHOLD;
             case "ruby.global-variable-max-invalidations":
                 return GLOBAL_VARIABLE_MAX_INVALIDATIONS;
             case "ruby.clone-default":
@@ -1418,7 +1408,6 @@ public static OptionDescriptor[] allDescriptors() {
             PACK_RECOVER_LOOP_MIN,
             CEXTS_MARKING_CACHE,
             CEXTS_TONATIVE_STATS,
-            ROPE_DEPTH_THRESHOLD,
             GLOBAL_VARIABLE_MAX_INVALIDATIONS,
             CLONE_DEFAULT,
             INLINE_DEFAULT,