Skip to content

Commit a38947d

Browse files
committed
Reduce diff to upstream
1 parent 8e0cd6e commit a38947d

File tree

9 files changed

+4
-134
lines changed

9 files changed

+4
-134
lines changed

lib/mri/drb/drb.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1571,25 +1571,21 @@ def perform
15711571
info = Thread.current['DRb']
15721572
if @block
15731573
@result = Thread.new do
1574-
begin # TruffleRuby bare ensure
15751574
Thread.current['DRb'] = info
15761575
prev_safe_level = $SAFE
15771576
$SAFE = @safe_level
15781577
perform_with_block
15791578
ensure
15801579
$SAFE = prev_safe_level
1581-
end
15821580
end.value
15831581
else
15841582
@result = Thread.new do
1585-
begin # TruffleRuby bare ensure
15861583
Thread.current['DRb'] = info
15871584
prev_safe_level = $SAFE
15881585
$SAFE = @safe_level
15891586
perform_without_block
15901587
ensure
15911588
$SAFE = prev_safe_level
1592-
end
15931589
end.value
15941590
end
15951591
else

lib/mri/erb.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -891,13 +891,11 @@ def run(b=new_toplevel)
891891
def result(b=new_toplevel)
892892
if @safe_level
893893
proc do
894-
begin # TruffleRuby for ensure
895894
prev_safe_level = $SAFE
896895
$SAFE = @safe_level
897896
eval(@src, b, (@filename || '(erb)'), @lineno)
898897
ensure
899898
$SAFE = prev_safe_level
900-
end
901899
end.call
902900
else
903901
eval(@src, b, (@filename || '(erb)'), @lineno)

test/mri/tests/lib/envutil.rb

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,6 @@
1212
rescue LoadError
1313
end
1414

15-
class Integer
16-
if defined?(::TruffleRuby)
17-
FIXNUM_MIN = Truffle::Platform::LONG_MIN
18-
FIXNUM_MAX = Truffle::Platform::LONG_MAX
19-
else
20-
require "rbconfig/sizeof"
21-
FIXNUM_MIN = -(1 << (8 * RbConfig::SIZEOF['long'] - 2))
22-
FIXNUM_MAX = (1 << (8 * RbConfig::SIZEOF['long'] - 2)) - 1
23-
end
24-
end
25-
2615
module EnvUtil
2716
def rubybin
2817
if ruby = ENV["RUBY"]

test/mri/tests/ripper/test_lexer.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,4 +95,4 @@ def test_slice
9595
assert_equal "string\#{nil}\n",
9696
Ripper.slice(%(<<HERE\nstring\#{nil}\nHERE), "heredoc_beg .*? nl $(.*?) heredoc_end", 1)
9797
end
98-
end if ripper_test
98+
end

test/mri/tests/ruby/test_array.rb

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
# frozen_string_literal: false
33
require 'test/unit'
44
require "delegate"
5+
require "rbconfig/sizeof"
56

67
class TestArray < Test::Unit::TestCase
78
def setup
@@ -3050,8 +3051,8 @@ def test_dig
30503051
assert_raise(TypeError) {h.dig(1, 0)}
30513052
end
30523053

3053-
FIXNUM_MIN = Integer::FIXNUM_MIN
3054-
FIXNUM_MAX = Integer::FIXNUM_MAX
3054+
FIXNUM_MIN = RbConfig::LIMITS['FIXNUM_MIN']
3055+
FIXNUM_MAX = RbConfig::LIMITS['FIXNUM_MAX']
30553056

30563057
def assert_typed_equal(e, v, cls, msg=nil)
30573058
assert_kind_of(cls, v, msg)

test/mri/tests/ruby/test_exception.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1150,7 +1150,6 @@ def test_warning_warn_circular_require_backtrace
11501150
warning = nil
11511151
path = nil
11521152
Tempfile.create(%w[circular .rb]) do |t|
1153-
begin # TruffleRuby extra begin for ensure
11541153
path = File.realpath(t.path)
11551154
basename = File.basename(path)
11561155
t.puts "require '#{basename}'"
@@ -1161,7 +1160,6 @@ def test_warning_warn_circular_require_backtrace
11611160
$LOAD_PATH.pop
11621161
$LOADED_FEATURES.delete(t)
11631162
end
1164-
end
11651163
assert_equal(1, warning.size)
11661164
assert_match(/circular require/, warning.first)
11671165
assert_match(/^\tfrom #{Regexp.escape(path)}:1:/, warning.first)

test/mri/tests/ruby/test_io.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2542,13 +2542,11 @@ def capture.write(str)
25422542

25432543
capture.clear
25442544
assert_warning(/[.#]write is outdated/) do
2545-
begin # TruffleRuby extra begin for ensure
25462545
stdout, $stdout = $stdout, capture
25472546
puts "hey"
25482547
ensure
25492548
$stdout = stdout
25502549
end
2551-
end
25522550
assert_equal("hey\n", capture)
25532551
end
25542552

test/mri/tests/ruby/test_require.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,13 +110,11 @@ def self.ospath_encoding(path)
110110
nil
111111
else
112112
proc do |require_path|
113-
begin # TruffleRuby extra begin for ensure
114113
$SAFE = 1
115114
require(require_path)
116115
ensure
117116
$SAFE = 0
118117
end
119-
end
120118
end
121119

122120
def prepare_require_path(dir, encoding)

test/mri/tests/rubygems/test_gem_installer.rb

Lines changed: 0 additions & 108 deletions
Original file line numberDiff line numberDiff line change
@@ -1554,114 +1554,6 @@ def spec.validate(*args); end
15541554
end
15551555
end
15561556

1557-
def test_pre_install_checks_malicious_name_before_eval
1558-
spec = util_spec "malicious\n::Object.const_set(:FROM_EVAL, true)#", '1'
1559-
def spec.full_name # so the spec is buildable
1560-
"malicious-1"
1561-
end
1562-
def spec.validate(*args); end
1563-
1564-
util_build_gem spec
1565-
1566-
gem = File.join(@gemhome, 'cache', spec.file_name)
1567-
1568-
use_ui @ui do
1569-
@installer = Gem::Installer.at gem
1570-
e = assert_raises Gem::InstallError do
1571-
@installer.pre_install_checks
1572-
end
1573-
assert_equal "#<Gem::Specification name=malicious\n::Object.const_set(:FROM_EVAL, true)# version=1> has an invalid name", e.message
1574-
end
1575-
refute defined?(::Object::FROM_EVAL)
1576-
end
1577-
1578-
def test_pre_install_checks_malicious_require_paths_before_eval
1579-
spec = util_spec "malicious", '1'
1580-
def spec.full_name # so the spec is buildable
1581-
"malicious-1"
1582-
end
1583-
def spec.validate(*args); end
1584-
spec.require_paths = ["malicious\n``"]
1585-
1586-
util_build_gem spec
1587-
1588-
gem = File.join(@gemhome, 'cache', spec.file_name)
1589-
1590-
use_ui @ui do
1591-
@installer = Gem::Installer.at gem
1592-
e = assert_raises Gem::InstallError do
1593-
@installer.pre_install_checks
1594-
end
1595-
assert_equal "#<Gem::Specification name=malicious version=1> has an invalid require_paths", e.message
1596-
end
1597-
end
1598-
1599-
def test_pre_install_checks_malicious_extensions_before_eval
1600-
skip "mswin environment disallow to create file contained the carriage return code." if Gem.win_platform?
1601-
1602-
spec = util_spec "malicious", '1'
1603-
def spec.full_name # so the spec is buildable
1604-
"malicious-1"
1605-
end
1606-
def spec.validate(*args); end
1607-
spec.extensions = ["malicious\n``"]
1608-
1609-
util_build_gem spec
1610-
1611-
gem = File.join(@gemhome, 'cache', spec.file_name)
1612-
1613-
use_ui @ui do
1614-
@installer = Gem::Installer.at gem
1615-
e = assert_raises Gem::InstallError do
1616-
@installer.pre_install_checks
1617-
end
1618-
assert_equal "#<Gem::Specification name=malicious version=1> has an invalid extensions", e.message
1619-
end
1620-
end
1621-
1622-
def test_pre_install_checks_malicious_specification_version_before_eval
1623-
spec = util_spec "malicious", '1'
1624-
def spec.full_name # so the spec is buildable
1625-
"malicious-1"
1626-
end
1627-
def spec.validate(*args); end
1628-
spec.specification_version = "malicious\n``"
1629-
1630-
util_build_gem spec
1631-
1632-
gem = File.join(@gemhome, 'cache', spec.file_name)
1633-
1634-
use_ui @ui do
1635-
@installer = Gem::Installer.at gem
1636-
e = assert_raises Gem::InstallError do
1637-
@installer.pre_install_checks
1638-
end
1639-
assert_equal "#<Gem::Specification name=malicious version=1> has an invalid specification_version", e.message
1640-
end
1641-
end
1642-
1643-
def test_pre_install_checks_malicious_dependencies_before_eval
1644-
spec = util_spec "malicious", '1'
1645-
def spec.full_name # so the spec is buildable
1646-
"malicious-1"
1647-
end
1648-
def spec.validate(*args); end
1649-
spec.add_dependency "b\nfoo", '> 5'
1650-
1651-
util_build_gem spec
1652-
1653-
gem = File.join(@gemhome, 'cache', spec.file_name)
1654-
1655-
use_ui @ui do
1656-
@installer = Gem::Installer.at gem
1657-
@installer.ignore_dependencies = true
1658-
e = assert_raises Gem::InstallError do
1659-
@installer.pre_install_checks
1660-
end
1661-
assert_equal "#<Gem::Specification name=malicious version=1> has an invalid dependencies", e.message
1662-
end
1663-
end
1664-
16651557
def test_shebang
16661558
util_make_exec @spec, "#!/usr/bin/ruby"
16671559

0 commit comments

Comments
 (0)