[GR-19220] Run jt lint in TravisCI for Pull Requests.

PullRequest: truffleruby/1166

Author: eregon

.travis.yml

@@ -0,0 +1,12 @@
+language: ruby
+rvm: 2.6.2
+install:
+  - tool/jt.rb install jvmci
+  - tool/jt.rb mx sforceimports
+  - tool/jt.rb build
+  - gem install rubocop:0.66.0
+script:
+  - tool/jt.rb lint
+cache:
+  directories:
+    - $HOME/.mx/cache

test/truffle/ecosystem/blog-shared.sh

@@ -22,9 +22,7 @@ alias truffleruby="jt ruby -S"
 
 set -xe
 
-if [ "$2" != "--no-gem-test-pack" ]; then
-  gem_test_pack_path="$(jt gem-test-pack)"
-fi
+gem_test_pack_path="$2"
 
 cd "test/truffle/ecosystem/$1"
 

tool/jt.rb

@@ -579,7 +579,6 @@ def help
       jt test bundle [--jdebug]                      tests using bundler
       jt test gems [TESTS]                           tests using gems
       jt test ecosystem [TESTS] [options]            tests using the wider ecosystem such as bundler, Rails, etc
-          --no-gem-test-pack                         run without gem test pack
       jt test cexts [--no-openssl] [--no-gems] [test_names...]
                                                      run C extension tests (set GEM_HOME)
       jt test unit                                   run Java unittests
@@ -1210,8 +1209,7 @@ def retag(*args)
   end
 
   private def test_ecosystem(*args)
-    use_gem_test_pack = !args.delete('--no-gem-test-pack')
-    gem_test_pack if use_gem_test_pack
+    gem_test_pack if gem_test_pack?
 
     tests_path = "#{TRUFFLERUBY_DIR}/test/truffle/ecosystem"
     single_test = !args.empty?
@@ -1233,7 +1231,7 @@ def retag(*args)
 
     success = candidates.all? do |test_script|
       next true if test_script.end_with? 'shared.sh'
-      sh test_script, *('--no-gem-test-pack' unless use_gem_test_pack), continue_on_failure: true
+      sh test_script, *(gem_test_pack if gem_test_pack?), continue_on_failure: true
     end
     exit success
   end
@@ -1354,14 +1352,19 @@ def mspec(*args)
     run_mspec env_vars, command, *options, *prefixed_ruby_args, *args
   end
 
+  def gem_test_pack?
+    return true if ci?
+    Dir.exist?(File.expand_path('truffleruby-gem-test-pack', TRUFFLERUBY_DIR))
+  end
+
   def gem_test_pack
     name = 'truffleruby-gem-test-pack'
     gem_test_pack = File.expand_path(name, TRUFFLERUBY_DIR)
 
     unless Dir.exist?(gem_test_pack)
       $stderr.puts 'Cloning the truffleruby-gem-test-pack repository'
       unless Remotes.bitbucket
-        abort 'Need a git remote in truffleruby with the internal repository URL or use --no-gem-test-pack option'
+        abort 'Need a git remote in truffleruby with the internal repository URL'
       end
       url = Remotes.url(Remotes.bitbucket).sub('truffleruby', name)
       sh 'git', 'clone', url
@@ -1951,16 +1954,21 @@ def native_launcher
   alias :'native-launcher' :native_launcher
 
   def rubocop(*args)
-    gem_home = "#{gem_test_pack}/rubocop-gems"
-    env = {
-      'GEM_HOME' => gem_home,
-      'GEM_PATH' => gem_home,
-      'PATH' => "#{gem_home}/bin:#{ENV['PATH']}"
-    }
     if args.empty? or args.all? { |arg| arg.start_with?('-') }
       args += RUBOCOP_INCLUDE_LIST
     end
-    sh env, 'ruby', "#{gem_home}/bin/rubocop", *args
+
+    if gem_test_pack?
+      gem_home = "#{gem_test_pack}/rubocop-gems"
+      env = {
+        'GEM_HOME' => gem_home,
+        'GEM_PATH' => gem_home,
+        'PATH' => "#{gem_home}/bin:#{ENV['PATH']}"
+      }
+      sh env, 'ruby', "#{gem_home}/bin/rubocop", *args
+    else
+      sh 'rubocop', '_0.66.0_', *args
+    end
   end
 
   def command_format(*args)
@@ -2065,7 +2073,7 @@ def make_specializations_protected
             new_content << line
           end
         else
-          looking = line.match?(/^ *@(Specialization|Fallback|CreateCast)/)
+          looking = /^ *@(Specialization|Fallback|CreateCast)/ =~ line
           new_content << line
           if looking
             braces = count_braces.(line)
@@ -2082,7 +2090,7 @@ def make_specializations_protected
     changed
   end
 
-  def lint(*args)
+  def lint
     check_filename_length
     rubocop
     sh 'tool/lint.sh'