[GR-18163] Replace ArrayCastNode by SplatCastNode and ArrayConvertNode (#2355)

PullRequest: truffleruby/2665

Author: eregon

CHANGELOG.md

@@ -10,6 +10,7 @@ Bug fixes:
 * `Truffle::POSIX.select` was being redefined repeatedly (#2332).
 * Fix the `--backtraces-raise` and `--backtraces-rescue` options in JVM mode (#2335).
 * Fix `File.{atime, mtime, ctime}` to include nanoseconds (#2337).
+* Fix `Array#[a, b] = "frozen string literal".freeze` (#2355).
 
 Compatibility:
 

spec/ruby/core/array/element_set_spec.rb

@@ -36,6 +36,7 @@
     a[3, 2] = ['a', 'b', 'c', 'd']
     a.should == [2, 2, 3, "a", "b", "c", "d", 6]
   end
+
   it "replaces the section defined by [start,length] with the given values" do
     a = [1, 2, 3, 4, 5, 6]
     a[3, 2] = 'a', 'b', 'c', 'd'
@@ -169,6 +170,7 @@
     ary[1...1] = []
     ary.should == [1, 2, 3]
   end
+
   it "does nothing if the section defined by range has negative width and the rhs is an empty array" do
     ary = [1, 2, 3, 4, 5]
     ary[1...0] = []
@@ -284,6 +286,12 @@ def obj.to_ary() [1, 2, 3] end
     (a[2, 3] = [4, 5]).should == [4, 5]
   end
 
+  it "accepts a frozen String literal as RHS" do
+    a = ['a', 'b', 'c']
+    a[0, 2] = 'd'.freeze
+    a.should == ['d', 'c']
+  end
+
   it "just sets the section defined by [start,length] to nil even if the rhs is nil" do
     a = ['a', 'b', 'c', 'd', 'e']
     a[1, 3] = nil

src/main/java/org/truffleruby/core/array/ArrayConvertNode.java

@@ -9,27 +9,34 @@
  */
 package org.truffleruby.core.array;
 
+import com.oracle.truffle.api.dsl.Cached;
+import com.oracle.truffle.api.dsl.Specialization;
 import com.oracle.truffle.api.profiles.ConditionProfile;
-import org.truffleruby.core.cast.ArrayCastNode;
 import org.truffleruby.language.RubyContextNode;
+import org.truffleruby.language.dispatch.DispatchNode;
 
-/** Attempts converting its argument to an array, via {@link ArrayCastNode} (i.e. calling "to_ary"), or if that doesn't
- * work, by wrapping it inside a one-element array. */
-public final class ArrayConvertNode extends RubyContextNode {
+/** Attempts converting its argument to an array by calling #to_ary, or if that doesn't work, by wrapping it inside a
+ * one-element array. */
+public abstract class ArrayConvertNode extends RubyContextNode {
 
-    @Child ArrayCastNode arrayCast = ArrayCastNode.create();
-    @Child ArrayBuilderNode arrayBuilder = ArrayBuilderNode.create();
-    private final ConditionProfile cantCast = ConditionProfile.create();
+    public abstract RubyArray execute(Object value);
 
-    public static ArrayConvertNode create() {
-        return new ArrayConvertNode();
+    @Specialization
+    protected RubyArray castArray(RubyArray array) {
+        return array;
     }
 
-    public RubyArray execute(Object object) {
-        Object converted = arrayCast.execute(object);
-        if (cantCast.profile(converted == nil)) {
+    @Specialization(guards = "!isRubyArray(object)")
+    protected RubyArray cast(Object object,
+            @Cached ConditionProfile canCast,
+            @Cached ArrayBuilderNode arrayBuilder,
+            @Cached(parameters = "PRIVATE_RETURN_MISSING") DispatchNode toArrayNode) {
+        final Object result = toArrayNode.call(object, "to_ary");
+        if (canCast.profile(result instanceof RubyArray)) {
+            return (RubyArray) result;
+        } else {
             return ArrayHelpers.specializedRubyArrayOf(getContext(), getLanguage(), arrayBuilder, object);
         }
-        return (RubyArray) converted;
     }
+
 }

src/main/java/org/truffleruby/core/cast/ArrayCastNode.java

@@ -15,7 +15,9 @@
 import org.truffleruby.RubyLanguage;
 import org.truffleruby.collections.CachedSupplier;
 import org.truffleruby.core.IsNilNode;
-import org.truffleruby.core.cast.ArrayCastNodeGen;
+import org.truffleruby.core.cast.SplatCastNode;
+import org.truffleruby.core.cast.SplatCastNode.NilBehavior;
+import org.truffleruby.core.cast.SplatCastNodeGen;
 import org.truffleruby.core.proc.ProcCallTargets;
 import org.truffleruby.core.proc.ProcType;
 import org.truffleruby.language.RubyLambdaRootNode;
@@ -201,7 +203,9 @@ private RubyNode preludeProc(
             final RubyNode readArrayNode = profileArgument(
                     language,
                     new ReadPreArgumentNode(0, MissingArgumentBehavior.RUNTIME_ERROR));
-            final RubyNode castArrayNode = ArrayCastNodeGen.create(readArrayNode);
+            final SplatCastNode castArrayNode = SplatCastNodeGen
+                    .create(language, NilBehavior.NIL, true, readArrayNode);
+            castArrayNode.doNotCopy();
 
             final FrameSlot arraySlot = environment.declareVar(environment.allocateLocalTemp("destructure"));
             final RubyNode writeArrayNode = new WriteLocalVariableNode(arraySlot, castArrayNode);