Copying the associated pointers with a String should be done in String#initialize_copy

Author: eregon

src/main/java/org/truffleruby/core/kernel/KernelNodes.java

@@ -411,12 +411,6 @@ protected Property[] getCopiedProperties(Shape shape) {
                 }
             }
 
-            final Property associatedProperty = shape.getProperty(Layouts.ASSOCIATED_IDENTIFIER);
-
-            if (associatedProperty != null) {
-                copiedProperties.add(associatedProperty);
-            }
-
             return copiedProperties.toArray(new Property[copiedProperties.size()]);
         }
 

src/main/java/org/truffleruby/core/string/StringNodes.java

@@ -162,6 +162,8 @@
 import org.truffleruby.language.objects.ReadObjectFieldNode;
 import org.truffleruby.language.objects.ReadObjectFieldNodeGen;
 import org.truffleruby.language.objects.TaintNode;
+import org.truffleruby.language.objects.WriteObjectFieldNode;
+import org.truffleruby.language.objects.WriteObjectFieldNodeGen;
 import org.truffleruby.language.yield.YieldNode;
 
 import com.oracle.truffle.api.CompilerDirectives;
@@ -1320,6 +1322,9 @@ public Rope getRope(DynamicObject str) {
     @CoreMethod(names = "initialize_copy", required = 1)
     public abstract static class InitializeCopyNode extends CoreMethodArrayArgumentsNode {
 
+        @Child private ReadObjectFieldNode readAssociatedNode = ReadObjectFieldNodeGen.create(Layouts.ASSOCIATED_IDENTIFIER, null);
+        @Child private WriteObjectFieldNode writeAssociatedNode;
+
         @Specialization(guards = "self == from")
         public Object initializeCopySelfIsSameAsFrom(DynamicObject self, DynamicObject from) {
             return self;
@@ -1329,17 +1334,29 @@ public Object initializeCopySelfIsSameAsFrom(DynamicObject self, DynamicObject f
         @Specialization(guards = { "self != from", "isRubyString(from)", "!isNativeRope(from)" })
         public Object initializeCopy(DynamicObject self, DynamicObject from) {
             StringOperations.setRope(self, rope(from));
-
+            copyAssociated(self, from);
             return self;
         }
 
         @Specialization(guards = { "self != from", "isRubyString(from)", "isNativeRope(from)" })
         public Object initializeCopyFromNative(DynamicObject self, DynamicObject from) {
             StringOperations.setRope(self, ((NativeRope) rope(from)).makeCopy(getContext().getFinalizationService()));
-
+            copyAssociated(self, from);
             return self;
         }
 
+        private void copyAssociated(DynamicObject self, DynamicObject from) {
+            final Object associated = readAssociatedNode.execute(from);
+            if (associated != null) {
+                if (writeAssociatedNode == null) {
+                    CompilerDirectives.transferToInterpreterAndInvalidate();
+                    writeAssociatedNode = insert(WriteObjectFieldNodeGen.create(Layouts.ASSOCIATED_IDENTIFIER));
+                }
+
+                writeAssociatedNode.write(self, associated);
+            }
+        }
+
         protected boolean isNativeRope(DynamicObject other) {
             return rope(other) instanceof NativeRope;
         }