[GR-44710] Fix rb_time_timespec_new function

PullRequest: truffleruby/3679

Author: andrykonchin

CHANGELOG.md

@@ -23,6 +23,7 @@ Bug fixes:
 * Fix `\P{}` matching in regular expressions (#2798, @andrykonchin).
 * Fix constants lookup when `BasicObject#instance_eval` method is called with a String (#2810, @andrykonchin).
 * Don't trigger the `method_added` event when changing a method's visibility or calling `module_function` (@paracycle, @nirvdrum).
+* Fix `rb_time_timespec_new` function to not call `Time.at` method directly (@andrykonchin).
 
 Compatibility:
 

lib/truffle/truffle/cext.rb

@@ -112,6 +112,12 @@ module Truffle::CExt
     LIBTRUFFLERUBY = libtruffleruby
   end
 
+  # Rails 6 overrides `Time.at` in a way that doesn't delegate keyword arguments to the original `Time.at` method.
+  # The issue was fixed in Rails 6.1 but wasn't backported.
+  # It causes ArgumentError exception when `rb_time_timespec_new` function is called in the `pg` gem.
+  # See https://github.com/rails/rails/issues/47586.
+  ORIGINAL_TIME_AT = Time.method(:at)
+
   def self.register_libtruffleruby(libtruffleruby)
     SET_LIBTRUFFLERUBY.call(libtruffleruby)
   end
@@ -1673,21 +1679,21 @@ def warning?
   end
 
   def rb_time_nano_new(sec, nsec)
-    Time.at sec, nsec, :nanosecond
+    ORIGINAL_TIME_AT.call(sec, nsec, :nanosecond)
   end
 
   def rb_time_timespec_new(sec, nsec, offset, is_utc, is_local)
     if is_local
-      Time.at(sec, nsec, :nanosecond)
+      ORIGINAL_TIME_AT.call(sec, nsec, :nanosecond)
     elsif is_utc
-      Time.at(sec, nsec, :nanosecond, in: 0).getgm
+      ORIGINAL_TIME_AT.call(sec, nsec, :nanosecond, in: 0).getgm
     else
-      Time.at(sec, nsec, :nanosecond, in: offset)
+      ORIGINAL_TIME_AT.call(sec, nsec, :nanosecond, in: offset)
     end
   end
 
   def rb_time_num_new(timev, off)
-    Time.at(timev).getlocal(off)
+    ORIGINAL_TIME_AT.call(timev).getlocal(off)
   end
 
   def rb_time_interval_acceptable(time_val)

spec/ruby/core/warning/warn_spec.rb

@@ -79,8 +79,8 @@ def Warning.warn(msg)
       Warning[:deprecated] = true
       begin
         -> {
-          warn("foo", category: :deprecated)
-        }.should complain("foo\n")
+          Warning.warn("foo", category: :deprecated)
+        }.should complain("foo")
       ensure
         Warning[:deprecated] = warn_deprecated
       end
@@ -91,8 +91,8 @@ def Warning.warn(msg)
       Warning[:experimental] = true
       begin
         -> {
-          warn("foo", category: :experimental)
-        }.should complain("foo\n")
+          Warning.warn("foo", category: :experimental)
+        }.should complain("foo")
       ensure
         Warning[:experimental] = warn_experimental
       end
@@ -103,7 +103,7 @@ def Warning.warn(msg)
       Warning[:deprecated] = false
       begin
         -> {
-          warn("foo", category: :deprecated)
+          Warning.warn("foo", category: :deprecated)
         }.should_not complain
       ensure
         Warning[:deprecated] = warn_deprecated
@@ -115,7 +115,7 @@ def Warning.warn(msg)
       Warning[:experimental] = false
       begin
         -> {
-          warn("foo", category: :experimental)
+          Warning.warn("foo", category: :experimental)
         }.should_not complain
       ensure
         Warning[:experimental] = warn_experimental

spec/ruby/optional/capi/time_spec.rb

@@ -283,6 +283,11 @@
       -> { @s.rb_time_timespec_new(1447087832, 476451125, 86400) }.should raise_error(ArgumentError)
       -> { @s.rb_time_timespec_new(1447087832, 476451125, -86400) }.should raise_error(ArgumentError)
     end
+
+    it "doesn't call Time.at directly" do
+      Time.should_not_receive(:at)
+      @s.rb_time_timespec_new(1447087832, 476451125, 32400).should be_kind_of(Time)
+    end
   end
 
   describe "rb_timespec_now" do