Fix a few RubyString#toString() calls

(cherry picked from commit 4cb098a)

Author: eregon

src/main/java/org/truffleruby/core/array/ArrayNodes.java

@@ -1591,7 +1591,7 @@ private RubyString finishPack(int formatLength, BytesResult result) {
 
         @TruffleBoundary
         protected RootCallTarget compileFormat(RubyString format) {
-            return new PackCompiler(getContext(), this).compile(format.toString());
+            return new PackCompiler(getContext(), this).compile(format.getJavaString());
         }
 
         protected int getCacheLimit() {

src/main/java/org/truffleruby/core/exception/CoreExceptions.java

@@ -89,6 +89,14 @@ public void showExceptionIfDebug(RubyClass rubyClass, Object message, Backtrace
         }
     }
 
+    public String inspectReceiver(Object receiver) {
+        RubyString rubyString = (RubyString) context.send(
+                context.getCoreLibrary().truffleExceptionOperationsModule,
+                "receiver_string",
+                receiver);
+        return rubyString.getJavaString();
+    }
+
     // ArgumentError
 
     public RubyException argumentErrorOneHashRequired(Node currentNode) {
@@ -488,17 +496,17 @@ public RubyException typeErrorCantConvertInto(Object from, String toClass, Node
 
     @TruffleBoundary
     public RubyException typeErrorIsNotA(Object value, String expectedType, Node currentNode) {
-        return typeErrorIsNotA(value.toString(), expectedType, currentNode);
+        return typeErrorIsNotA(inspectReceiver(value), expectedType, currentNode);
     }
 
     @TruffleBoundary
     public RubyException typeErrorIsNotA(String value, String expectedType, Node currentNode) {
-        return typeError(StringUtils.format("%s is not a %s", value, expectedType), currentNode);
+        return typeError(value + " is not a " + expectedType, currentNode);
     }
 
     @TruffleBoundary
     public RubyException typeErrorIsNotAClassModule(Object value, Node currentNode) {
-        return typeError(StringUtils.format("%s is not a class/module", value), currentNode);
+        return typeError(inspectReceiver(value) + " is not a class/module", currentNode);
     }
 
     @TruffleBoundary

src/main/java/org/truffleruby/core/regexp/MatchDataNodes.java

@@ -389,11 +389,11 @@ private int getBackRefFromRope(RubyMatchData matchData, Object index, Rope value
                         0,
                         value.byteLength(),
                         matchData.region);
-            } catch (final ValueException e) {
+            } catch (ValueException e) {
                 throw new RaiseException(
                         getContext(),
                         coreExceptions().indexError(
-                                StringUtils.format("undefined group name reference: %s", index.toString()),
+                                StringUtils.format("undefined group name reference: %s", index),
                                 this));
             }
         }

src/main/java/org/truffleruby/core/rope/Rope.java

@@ -21,7 +21,7 @@ public abstract class Rope implements Comparable<Rope> {
     public static final int NUMBER_OF_CONCRETE_CLASSES = 8;
 
     // Useful for debugging. Setting to false allow to catch wrong usages.
-    protected static final boolean ALLOW_TO_STRING = true;
+    protected static final boolean ALLOW_TO_STRING = false;
 
     public final Encoding encoding;
     private final int byteLength;

src/main/java/org/truffleruby/parser/parser/RubyParser.java

@@ -1259,7 +1259,7 @@ rel_expr        : arg relop arg   %prec tGT {
                      $$ = support.getOperatorCallNode($1, $2, $3, lexer.getPosition());
                 }
                 | rel_expr relop arg   %prec tGT {
-                     support.warning(lexer.getPosition(), "comparison '" + $2 + "' after comparison");
+                     support.warning(lexer.getPosition(), "comparison '" + $2.getString() + "' after comparison");
                      $$ = support.getOperatorCallNode($1, $2, $3, lexer.getPosition());
                 }
 

src/main/java/org/truffleruby/parser/parser/RubyParser.y

@@ -48,8 +48,7 @@ def self.class_name(receiver)
     end
 
     # MRI: name_err_mesg_to_str
-    def self.receiver_string(exception)
-      receiver = exception.receiver
+    def self.receiver_string(receiver)
       ret = begin
         if Primitive.object_respond_to?(receiver, :inspect, false)
           Truffle::Type.rb_inspect(receiver)
@@ -157,19 +156,19 @@ def self.comparison_error_message(x, y)
     end
 
     NO_METHOD_ERROR = Proc.new do |exception|
-      format("undefined method `%s' for %s", exception.name, receiver_string(exception))
+      format("undefined method `%s' for %s", exception.name, receiver_string(exception.receiver))
     end
 
     NO_LOCAL_VARIABLE_OR_METHOD_ERROR = Proc.new do |exception|
-      format("undefined local variable or method `%s' for %s", exception.name, receiver_string(exception))
+      format("undefined local variable or method `%s' for %s", exception.name, receiver_string(exception.receiver))
     end
 
     PRIVATE_METHOD_ERROR = Proc.new do |exception|
-      format("private method `%s' called for %s", exception.name, receiver_string(exception))
+      format("private method `%s' called for %s", exception.name, receiver_string(exception.receiver))
     end
 
     PROTECTED_METHOD_ERROR = Proc.new do |exception|
-      format("protected method `%s' called for %s", exception.name, receiver_string(exception))
+      format("protected method `%s' called for %s", exception.name, receiver_string(exception.receiver))
     end
 
     SUPER_METHOD_ERROR = Proc.new do |exception|