[GR-20250] Fix Symbol#to_proc to create proc with nil source_location (#1663).

PullRequest: truffleruby/1204

Author: bjfish

CHANGELOG.md

@@ -47,6 +47,7 @@ Bug fixes:
 * Fixed `BigDecimal#to_s` formatting issue (#1711).
 * Run `END` keyword block only once at exit.
 * Implement Numeric#clone method to return self.
+* Fixed `Symbol#to_proc` to create proc with nil `source_location` (#1663).
 
 Compatibility:
 

spec/ruby/core/symbol/to_proc_spec.rb

@@ -38,4 +38,9 @@ def to_proc
     end
     klass.new.to_proc.should == :value
   end
+
+  it "produces a proc with source location nil" do
+    pr = :to_s.to_proc
+    pr.source_location.should == nil
+  end
 end

src/main/java/org/truffleruby/core/CoreLibrary.java

@@ -79,6 +79,11 @@
 
 public class CoreLibrary {
 
+    public static final SourceSection UNAVAILABLE_SOURCE_SECTION = Source
+            .newBuilder(TruffleRuby.LANGUAGE_ID, "", "(unavailable)")
+            .build()
+            .createUnavailableSection();
+
     private static final String ERRNO_CONFIG_PREFIX = NativeConfiguration.PREFIX + "errno.";
 
     private static final Property ALWAYS_FROZEN_PROPERTY = Property

src/main/java/org/truffleruby/core/method/MethodNodes.java

@@ -181,7 +181,7 @@ public abstract static class SourceLocationNode extends CoreMethodArrayArguments
         protected Object sourceLocation(DynamicObject method) {
             SourceSection sourceSection = Layouts.METHOD.getMethod(method).getSharedMethodInfo().getSourceSection();
 
-            if (sourceSection.getSource() == null) {
+            if (!sourceSection.isAvailable()) {
                 return nil();
             } else {
                 DynamicObject file = makeStringNode.executeMake(

src/main/java/org/truffleruby/core/method/UnboundMethodNodes.java

@@ -178,7 +178,7 @@ protected Object sourceLocation(DynamicObject unboundMethod) {
                     .getSharedMethodInfo()
                     .getSourceSection();
 
-            if (sourceSection.getSource() == null) {
+            if (!sourceSection.isAvailable()) {
                 return nil();
             } else {
                 DynamicObject file = makeStringNode.executeMake(

src/main/java/org/truffleruby/core/proc/ProcNodes.java

@@ -286,7 +286,7 @@ public abstract static class SourceLocationNode extends CoreMethodArrayArguments
         protected Object sourceLocation(DynamicObject proc) {
             SourceSection sourceSection = Layouts.PROC.getSharedMethodInfo(proc).getSourceSection();
 
-            if (sourceSection.getSource() == null ||
+            if (!sourceSection.isAvailable() ||
                     sourceSection.getSource().getName().endsWith("/lib/truffle/truffle/cext.rb")) {
                 return nil();
             } else {

src/main/java/org/truffleruby/core/symbol/SymbolNodes.java

@@ -15,6 +15,7 @@
 import org.truffleruby.builtins.CoreMethod;
 import org.truffleruby.builtins.CoreMethodArrayArgumentsNode;
 import org.truffleruby.builtins.UnaryCoreMethodNode;
+import org.truffleruby.core.CoreLibrary;
 import org.truffleruby.core.proc.ProcOperations;
 import org.truffleruby.core.proc.ProcType;
 import org.truffleruby.core.string.StringNodes;
@@ -122,11 +123,7 @@ protected DynamicObject toProcUncached(VirtualFrame frame, DynamicObject symbol)
         @TruffleBoundary
         protected DynamicObject createProc(DeclarationContext declarationContext, InternalMethod method,
                 DynamicObject symbol) {
-            final SourceSection sourceSection = getContext()
-                    .getCallStack()
-                    .getCallerNodeIgnoringSend()
-                    .getEncapsulatingSourceSection();
-
+            final SourceSection sourceSection = CoreLibrary.UNAVAILABLE_SOURCE_SECTION;
             final SharedMethodInfo sharedMethodInfo = new SharedMethodInfo(
                     sourceSection,
                     method.getLexicalScope(),