Skip to content

Commit 953557e

Browse files
committed
Use RubyNode.EMPTY_ARRAY for createCallNode without call arguments
1 parent 6752255 commit 953557e

File tree

1 file changed

+7
-12
lines changed

1 file changed

+7
-12
lines changed

src/main/java/org/truffleruby/parser/YARPTranslator.java

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -985,7 +985,7 @@ public RubyNode visitCaseNode(Nodes.CaseNode node) {
985985
// so `when a, *b, c` is translated into `[a, *b, c].any?`
986986
final RubyNode whenConditionNode = translateExpressionsList(whenConditions);
987987
final RubyNode receiver = whenConditionNode;
988-
final RubyNode predicateNode = createCallNode(receiver, "any?");
988+
final RubyNode predicateNode = createCallNode(receiver, "any?", RubyNode.EMPTY_ARRAY);
989989

990990
// create `if` node
991991
final RubyNode thenNode = translateNodeOrNil(when.statements);
@@ -1729,10 +1729,9 @@ public RubyNode visitImaginaryNode(Nodes.ImaginaryNode node) {
17291729
final ReadConstantNode complexModuleNode = new ReadConstantNode(objectClassNode, "Complex");
17301730
final RubyNode realComponentNode = new IntegerFixnumLiteralNode(0);
17311731
final RubyNode imaginaryComponentNode = node.numeric.accept(this);
1732-
17331732
RubyNode[] arguments = new RubyNode[]{ realComponentNode, imaginaryComponentNode };
1734-
RubyNode rubyNode = createCallNode(complexModuleNode, "convert", arguments);
17351733

1734+
RubyNode rubyNode = createCallNode(complexModuleNode, "convert", arguments);
17361735
return assignPositionAndFlags(node, rubyNode);
17371736
}
17381737

@@ -2003,11 +2002,9 @@ public RubyNode visitInterpolatedMatchLastLineNode(Nodes.InterpolatedMatchLastLi
20032002
final var regexp = new Nodes.InterpolatedRegularExpressionNode(node.parts, node.flags, node.startOffset,
20042003
node.length);
20052004
final var regexpNode = regexp.accept(this);
2006-
20072005
final var lastLineNode = ReadGlobalVariableNodeGen.create("$_");
2008-
final RubyNode[] arguments = new RubyNode[]{ lastLineNode };
20092006

2010-
final RubyNode rubyNode = createCallNode(false, regexpNode, "=~", arguments);
2007+
final RubyNode rubyNode = createCallNode(false, regexpNode, "=~", lastLineNode);
20112008
return assignPositionAndFlags(node, rubyNode);
20122009
}
20132010

@@ -2051,8 +2048,8 @@ public RubyNode visitInterpolatedSymbolNode(Nodes.InterpolatedSymbolNode node) {
20512048
public RubyNode visitInterpolatedXStringNode(Nodes.InterpolatedXStringNode node) {
20522049
var stringNode = new Nodes.InterpolatedStringNode(node.parts, node.startOffset, node.length);
20532050
final RubyNode string = stringNode.accept(this);
2054-
final RubyNode rubyNode = createCallNode(new SelfNode(), "`", string);
20552051

2052+
final RubyNode rubyNode = createCallNode(new SelfNode(), "`", string);
20562053
return assignPositionAndFlags(node, rubyNode);
20572054
}
20582055

@@ -2213,11 +2210,9 @@ public RubyNode visitMatchLastLineNode(Nodes.MatchLastLineNode node) {
22132210

22142211
final var regexp = new Nodes.RegularExpressionNode(node.unescaped, node.flags, node.startOffset, node.length);
22152212
final var regexpNode = regexp.accept(this);
2216-
22172213
final var lastLineNode = ReadGlobalVariableNodeGen.create("$_");
2218-
final RubyNode[] arguments = new RubyNode[]{ lastLineNode };
22192214

2220-
final RubyNode rubyNode = createCallNode(false, regexpNode, "=~", arguments);
2215+
final RubyNode rubyNode = createCallNode(false, regexpNode, "=~", lastLineNode);
22212216
return assignPositionAndFlags(node, rubyNode);
22222217
}
22232218

@@ -2464,8 +2459,8 @@ public RubyNode visitRationalNode(Nodes.RationalNode node) {
24642459
}
24652460

24662461
RubyNode[] arguments = new RubyNode[]{ numeratorNode, denominatorNode };
2467-
RubyNode rubyNode = createCallNode(rationalModuleNode, "convert", arguments);
24682462

2463+
RubyNode rubyNode = createCallNode(rationalModuleNode, "convert", arguments);
24692464
return assignPositionAndFlags(node, rubyNode);
24702465
}
24712466

@@ -2782,8 +2777,8 @@ public RubyNode visitXStringNode(Nodes.XStringNode node) {
27822777
// TODO: pass flags, needs https://github.com/ruby/yarp/issues/1567
27832778
var stringNode = new Nodes.StringNode((short) 0, node.unescaped, node.startOffset, node.length);
27842779
final RubyNode string = stringNode.accept(this);
2785-
final RubyNode rubyNode = createCallNode(new SelfNode(), "`", string);
27862780

2781+
final RubyNode rubyNode = createCallNode(new SelfNode(), "`", string);
27872782
return assignPositionAndFlags(node, rubyNode);
27882783
}
27892784

0 commit comments

Comments
 (0)