Do not store options while parsing in polyglotOptions

* Otherwise, if we exec() to JVM, we'll have them twice as the launcher
  keeps the original arguments, and we would pass experimental options
  on the command line which would make it fail.
* We need to check if --embedded or --ruby.embedded is passed on the
  command line, which we do by looking at polyglotOptions.

Author: eregon

src/launcher/java/org/truffleruby/launcher/CommandLineOptions.java

@@ -34,6 +34,8 @@
 import org.truffleruby.shared.options.StringArrayOptionType;
 
 import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 
@@ -50,16 +52,25 @@ public class CommandLineOptions {
     /** A thing to be executed: a file, inline script, etc. Used by executionAction when applicable. */
     String toExecute = "";
 
-    private Map<String, String> options;
+    /** This should not be modified, as otherwise when exec()-ing to JVM from a native launcher,
+     * these options would be passed on the command line, which fails if they are experimental.
+     * This would also cause parsing the options twice with the current Launcher design. */
+    private final Map<String, String> polyglotOptions;
+    private final Map<String, String> options;
     private String[] arguments;
     private final List<String> unknownArguments;
 
-    public CommandLineOptions(Map<String, String> options) {
-        this.options = options;
-        this.arguments = new String[]{};
+    public CommandLineOptions(Map<String, String> polyglotOptions) {
+        this.polyglotOptions = Collections.unmodifiableMap(polyglotOptions);
+        this.options = new HashMap<>();
+        this.arguments = new String[0];
         this.unknownArguments = new ArrayList<>();
     }
 
+    boolean isSetInPolyglotOptions(String optionName) {
+        return polyglotOptions.containsKey(optionName);
+    }
+
     public Map<String, String> getOptions() {
         return options;
     }

src/launcher/java/org/truffleruby/launcher/RubyLauncher.java

@@ -248,10 +248,12 @@ private static void debugPreInitialization() {
     }
 
     private Context createContext(Context.Builder builder, CommandLineOptions config) {
-        if (!config.getOptions().containsKey(OptionsCatalog.EMBEDDED.getName())) {
-            builder.option(OptionsCatalog.EMBEDDED.getName(), Boolean.FALSE.toString());
+        if (!config.isSetInPolyglotOptions(OptionsCatalog.EMBEDDED.getName())) {
+            builder.option(OptionsCatalog.EMBEDDED.getName(), "false");
         }
 
+        builder.options(config.getOptions());
+
         builder.arguments(TruffleRuby.LANGUAGE_ID, config.getArguments());
 
         return builder.build();