Use an uncached node rather than a manual slow path copy

Author: eregon

src/main/java/org/truffleruby/core/rope/RopeNodes.java

@@ -1091,26 +1091,6 @@ protected Rope withEncodingAsciiCompatible(ManagedRope rope, Encoding encoding,
             }
         }
 
-        // Version without a node
-        @TruffleBoundary
-        public static Rope withEncodingSlow(Rope originalRope, Encoding newEncoding) {
-            if (originalRope.getEncoding() == newEncoding) {
-                return originalRope;
-            }
-
-            if (originalRope.getCodeRange() == CR_7BIT && newEncoding.isAsciiCompatible()) {
-                return originalRope.withEncoding(newEncoding, CR_7BIT);
-            }
-
-            if (newEncoding == ASCIIEncoding.INSTANCE && originalRope.getCodeRange() == CR_VALID &&
-                    originalRope.getEncoding().isAsciiCompatible()) {
-                // ASCII-compatible CR_VALID strings are also CR_VALID in binary.
-                return originalRope.withEncoding(newEncoding, CR_VALID);
-            }
-
-            return RopeOperations.create(originalRope.getBytes(), newEncoding, CR_UNKNOWN);
-        }
-
         private Rope rescanBytesForEncoding(Rope rope, Encoding encoding, BytesNode bytesNode,
                 MakeLeafRopeNode makeLeafRopeNode) {
             return makeLeafRopeNode.executeMake(bytesNode.execute(rope), encoding, CR_UNKNOWN, NotProvided.INSTANCE);

src/main/java/org/truffleruby/core/rope/RopeOperations.java

@@ -40,6 +40,7 @@
 import org.truffleruby.core.Hashing;
 import org.truffleruby.core.encoding.EncodingManager;
 import org.truffleruby.core.rope.RopeNodes.WithEncodingNode;
+import org.truffleruby.core.rope.RopeNodesFactory.WithEncodingNodeGen;
 import org.truffleruby.core.string.StringAttributes;
 import org.truffleruby.core.string.StringOperations;
 import org.truffleruby.core.string.StringSupport;
@@ -132,7 +133,7 @@ public static Rope emptyRope(Encoding encoding) {
     }
 
     public static Rope withEncoding(Rope originalRope, Encoding newEncoding) {
-        return WithEncodingNode.withEncodingSlow(originalRope, newEncoding);
+        return WithEncodingNodeGen.getUncached().executeWithEncoding(originalRope, newEncoding);
     }
 
     public static Rope encodeAscii(String value, Encoding encoding) {