[GR-40333] Ruby 3.1 Add Struct.new.keyword_init?

PullRequest: truffleruby/3702

Author: andrykonchin

CHANGELOG.md

@@ -92,6 +92,7 @@ Compatibility:
 * Add `Process._fork` (#2733, @horakivo).
 * Update to JCodings 1.0.58 and Joni 2.1.44 (@eregon).
 * Add `MatchData#match` and `MatchData#match_length` (#2733, @horakivo).
+* Add `StructClass#keyword_init?` method (#2377, @moste00).
 
 Performance:
 

spec/ruby/core/struct/keyword_init_spec.rb

@@ -17,5 +17,24 @@
       struct = Struct.new(:arg)
       struct.keyword_init?.should be_nil
     end
+
+    it "returns nil for a struct that does specify keyword_init to be nil" do
+      struct = Struct.new(:arg, keyword_init: nil)
+      struct.keyword_init?.should be_nil
+    end
+
+    it "returns true for any truthy value, not just for true" do
+      struct = Struct.new(:arg, keyword_init: 1)
+      struct.keyword_init?.should be_true
+
+      struct = Struct.new(:arg, keyword_init: "")
+      struct.keyword_init?.should be_true
+
+      struct = Struct.new(:arg, keyword_init: [])
+      struct.keyword_init?.should be_true
+
+      struct = Struct.new(:arg, keyword_init: {})
+      struct.keyword_init?.should be_true
+    end
   end
 end

spec/tags/core/struct/keyword_init_tags.txt

@@ -33,7 +33,7 @@ class << self
     alias_method :subclass_new, :new
   end
 
-  def self.new(klass_name, *attrs, keyword_init: false, &block)
+  def self.new(klass_name, *attrs, keyword_init: nil, &block)
     if klass_name
       if Primitive.object_kind_of?(klass_name, Symbol) # Truffle: added to avoid exception and match MRI
         attrs.unshift klass_name
@@ -92,6 +92,11 @@ def self.inspect
 
       const_set :STRUCT_ATTRS, attrs
       const_set :KEYWORD_INIT, keyword_init
+
+      def self.keyword_init?
+        return nil if Primitive.nil?(self::KEYWORD_INIT)
+        Primitive.as_boolean(self::KEYWORD_INIT)
+      end
     end
 
     const_set klass_name, klass if klass_name

src/main/ruby/truffleruby/core/struct.rb

@@ -5,4 +5,3 @@
 exclude :test_struct_new_with_empty_hash, "needs investigation"
 exclude :test_parameters, "<[[:req, :_]]> expected but was"
 exclude :test_keyword_args_warning, "<{:a=>1}> expected but was"
-exclude :test_struct_keyword_init_p, "NoMethodError: undefined method `keyword_init?' for #<Class:0x6bf8>(keyword_init: true)"

test/mri/excludes/TestStruct/SubStruct.rb

@@ -3,6 +3,5 @@
 exclude :test_nonascii, "needs investigation"
 exclude :test_redefinition_warning, "needs investigation"
 exclude :test_struct_new_with_empty_hash, "needs investigation"
-exclude :test_struct_keyword_init_p, "NoMethodError: undefined method `keyword_init?' for #<Class:0xc3f888>(keyword_init: true)"
 exclude :test_parameters, "<[[:req, :_]]> expected but was"
 exclude :test_keyword_args_warning, "expected: /warning: Passing only keyword arguments to Struct#initialize will behave differently from Ruby 3\\.2\\./"