[GR-45043] Integrate YARP parser [Part 4]

PullRequest: truffleruby/4045

Author: andrykonchin

spec/ruby/core/method/parameters_spec.rb

@@ -7,6 +7,7 @@ def one_key(a: 1); end
     def one_keyrest(**a); end
 
     def one_keyreq(a:); end
+    def one_nokey(**nil); end
 
     def one_splat_one_req(*a,b); end
     def one_splat_two_req(*a,b,c); end
@@ -15,6 +16,7 @@ def one_splat_one_req_with_block(*a,b,&blk); end
     def one_opt_with_stabby(a=-> b { true }); end
 
     def one_unnamed_splat(*); end
+    def one_unnamed_keyrest(**); end
 
     def one_splat_one_block(*args, &block)
       local_is_not_parameter = {}
@@ -178,6 +180,11 @@ def underscore_parameters(_, _, _ = 1, *_, _:, _: 2, **_, &_); end
     m.parameters.should == [[:keyreq,:a]]
   end
 
+  it "returns [[:nokey]] for a method with a single **nil parameter" do
+    m = MethodSpecs::Methods.instance_method(:one_nokey)
+    m.parameters.should == [[:nokey]]
+  end
+
   it "works with ->(){} as the value of an optional argument" do
     m = MethodSpecs::Methods.instance_method(:one_opt_with_stabby)
     m.parameters.should == [[:opt,:a]]
@@ -225,17 +232,39 @@ def underscore_parameters(_, _, _ = 1, *_, _:, _: 2, **_, &_); end
   end
 
   ruby_version_is '3.2' do
-    it "adds * rest arg for \"star\" argument" do
+    it "adds rest arg with name * for \"star\" argument" do
       m = MethodSpecs::Methods.new
       m.method(:one_unnamed_splat).parameters.should == [[:rest, :*]]
     end
+
+    it "adds keyrest arg with ** as a name for \"double star\" argument" do
+      m = MethodSpecs::Methods.new
+      m.method(:one_unnamed_keyrest).parameters.should == [[:keyrest, :**]]
+    end
   end
 
   ruby_version_is ''...'3.2' do
     it "adds nameless rest arg for \"star\" argument" do
       m = MethodSpecs::Methods.new
       m.method(:one_unnamed_splat).parameters.should == [[:rest]]
     end
+
+    it "adds nameless keyrest arg for \"double star\" argument" do
+      m = MethodSpecs::Methods.new
+      m.method(:one_unnamed_keyrest).parameters.should == [[:keyrest]]
+    end
+  end
+
+  ruby_version_is '3.1' do
+    it "adds block arg with name & for anonymous block argument" do
+      object = Object.new
+
+      eval(<<~RUBY).should == [[:block, :&]]
+        def object.foo(&)
+        end
+        object.method(:foo).parameters
+      RUBY
+    end
   end
 
   it "returns the args and block for a splat and block argument" do

spec/ruby/core/proc/parameters_spec.rb

@@ -21,7 +21,7 @@
   end
 
   ruby_version_is "3.2" do
-    it "sets the first element of each sub-Array to :req if argument would be required if a lambda if lambda keyword used" do
+    it "sets the first element of each sub-Array to :req for required argument if lambda keyword used" do
       proc {|x| }.parameters(lambda: true).first.first.should == :req
       proc {|y,*x| }.parameters(lambda: true).first.first.should == :req
     end
@@ -91,19 +91,33 @@
     proc {|&block| }.parameters.first.last.should == :block
   end
 
-  it "ignores unnamed rest args" do
+  it "ignores unnamed rest arguments" do
     -> x {}.parameters.should == [[:req, :x]]
   end
 
   ruby_version_is '3.2' do
-    it "adds * rest arg for \"star\" argument" do
-      -> x, * {}.parameters.should == [[:req, :x], [:rest, :*]]
+    it "adds rest arg with name * for \"star\" argument" do
+      -> * {}.parameters.should == [[:rest, :*]]
+    end
+
+    it "adds keyrest arg with ** as a name for \"double star\" argument" do
+      -> ** {}.parameters.should == [[:keyrest, :**]]
     end
   end
 
   ruby_version_is ''...'3.2' do
     it "adds nameless rest arg for \"star\" argument" do
-      -> x, * {}.parameters.should == [[:req, :x], [:rest]]
+      -> * {}.parameters.should == [[:rest]]
+    end
+
+    it "adds nameless keyrest arg for \"double star\" argument" do
+      -> ** {}.parameters.should == [[:keyrest]]
+    end
+  end
+
+  ruby_version_is '3.1' do
+    it "adds block arg with name & for anonymous block argument" do
+      eval('-> & {}.parameters').should == [[:block, :&]]
     end
   end
 

spec/tags/core/method/parameters_tags.txt

@@ -1 +1,3 @@
-fails:Method#parameters adds * rest arg for "star" argument
+fails:Method#parameters adds rest arg with name * for "star" argument
+fails:Method#parameters adds keyrest arg with ** as a name for "double star" argument
+fails:Method#parameters adds block arg with name & for anonymous block argument

spec/tags/core/proc/parameters_tags.txt

@@ -1,4 +1,6 @@
-fails:Proc#parameters sets the first element of each sub-Array to :req if argument would be required if a lambda if lambda keyword used
+fails:Proc#parameters sets the first element of each sub-Array to :req for required argument if lambda keyword used
 fails:Proc#parameters regards named parameters in procs as required if lambda keyword used
 fails:Proc#parameters regards named parameters in lambda as optional if lambda: false keyword used
-fails:Proc#parameters adds * rest arg for "star" argument
+fails:Proc#parameters adds rest arg with name * for "star" argument
+fails:Proc#parameters adds keyrest arg with ** as a name for "double star" argument
+fails:Proc#parameters adds block arg with name & for anonymous block argument