Assert there are no null's in arguments or in Object[] arrays

Author: eregon

src/main/java/org/truffleruby/core/array/ArrayHelpers.java

@@ -29,8 +29,13 @@ public static void setSize(RubyArray array, int size) {
         array.size = size;
     }
 
+    private static boolean assertNoNullElement(Object store, int size) {
+        return !(store instanceof Object[]) || ArrayUtils.assertNoNullElement((Object[]) store, size);
+    }
+
     public static RubyArray createArray(RubyContext context, RubyLanguage language, Object store, int size) {
         assert !(store instanceof Object[]) || store.getClass() == Object[].class;
+        assert assertNoNullElement(store, size);
         return new RubyArray(context.getCoreLibrary().arrayClass, language.arrayShape, store, size);
     }
 

src/main/java/org/truffleruby/core/array/ArrayUtils.java

@@ -20,6 +20,19 @@ public abstract class ArrayUtils {
 
     public static final Object[] EMPTY_ARRAY = new Object[0];
 
+    public static boolean assertNoNullElement(Object[] array, int size) {
+        assert size <= array.length;
+        for (int i = 0; i < size; i++) {
+            final Object element = array[i];
+            assert element != null : element;
+        }
+        return true;
+    }
+
+    public static boolean assertNoNullElement(Object[] array) {
+        return assertNoNullElement(array, array.length);
+    }
+
     /** Extracts part of an array into a newly allocated byte[] array. Does not perform safety checks on parameters.
      * 
      * @param source the source array whose values should be extracted

src/main/java/org/truffleruby/language/arguments/RubyArguments.java

@@ -70,6 +70,8 @@ public static Object[] pack(
         assert declarationContext != null;
         assert self != null;
         assert arguments != null;
+        assert ArrayUtils.assertNoNullElement(arguments);
+
         assert callerFrameOrVariables == null ||
                 callerFrameOrVariables instanceof MaterializedFrame ||
                 callerFrameOrVariables instanceof SpecialVariableStorage ||