[GR-16274] [GR-16294] Check for unused imports with CheckStyle.

eregon · eregon · commit 8329b5b84e24 · 2019-06-05T09:04:50.000-07:00
PullRequest: truffleruby/877
diff --git a/src/main/.checkstyle_checks.xml b/src/main/.checkstyle_checks.xml
@@ -34,6 +34,7 @@
       <property name="format" value="^[A-Z][_a-zA-Z0-9]*$"/>
     </module>
     <module name="RedundantImport"/>
+    <module name="UnusedImports"/>
     <!--<module name="LineLength">-->
       <!--<property name="max" value="250"/>-->
     <!--</module>-->
diff --git a/src/main/java/org/truffleruby/RubyContext.java b/src/main/java/org/truffleruby/RubyContext.java
@@ -46,7 +46,6 @@
 import org.truffleruby.core.rope.PathToRopeCache;
 import org.truffleruby.core.rope.Rope;
 import org.truffleruby.core.rope.RopeCache;
-import org.truffleruby.core.rope.RopeKey;
 import org.truffleruby.core.string.CoreStrings;
 import org.truffleruby.core.string.FrozenStringLiterals;
 import org.truffleruby.core.symbol.SymbolTable;
diff --git a/src/main/java/org/truffleruby/RubyLanguage.java b/src/main/java/org/truffleruby/RubyLanguage.java
@@ -39,7 +39,6 @@
 import org.truffleruby.stdlib.CoverageManager;
 
 import java.util.ArrayList;
-import java.util.Collection;
 import java.util.Collections;
 import java.util.List;
 
diff --git a/src/main/java/org/truffleruby/builtins/CoreMethodNodeManager.java b/src/main/java/org/truffleruby/builtins/CoreMethodNodeManager.java
@@ -9,7 +9,6 @@
  */
 package org.truffleruby.builtins;
 
-import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
 import java.util.function.Function;
diff --git a/src/main/java/org/truffleruby/builtins/PrimitiveNodeConstructor.java b/src/main/java/org/truffleruby/builtins/PrimitiveNodeConstructor.java
@@ -11,7 +11,6 @@
 
 import com.oracle.truffle.api.dsl.NodeFactory;
 import com.oracle.truffle.api.source.Source;
-import com.oracle.truffle.api.source.SourceSection;
 import org.truffleruby.RubyContext;
 import org.truffleruby.core.RaiseIfFrozenNode;
 import org.truffleruby.core.array.ArrayUtils;
@@ -24,9 +23,6 @@
 import org.truffleruby.language.arguments.ReadSelfNode;
 import org.truffleruby.parser.Translator;
 
-import java.util.ArrayList;
-import java.util.List;
-
 public class PrimitiveNodeConstructor {
 
     private final Primitive annotation;
diff --git a/src/main/java/org/truffleruby/cext/CExtNodes.java b/src/main/java/org/truffleruby/cext/CExtNodes.java
@@ -46,7 +46,6 @@
 import org.truffleruby.builtins.YieldingCoreMethodNode;
 import org.truffleruby.cext.CExtNodesFactory.CallCWithMutexNodeFactory;
 import org.truffleruby.cext.CExtNodesFactory.StringToNativeNodeGen;
-import org.truffleruby.cext.CExtNodesFactory.CallCWithMutexNodeFactory.CallCWithMutexNodeGen;
 import org.truffleruby.core.CoreLibrary;
 import org.truffleruby.core.MarkingServiceNodes;
 import org.truffleruby.core.MarkingService.ExtensionCallStack;
diff --git a/src/main/java/org/truffleruby/core/CoreLibrary.java b/src/main/java/org/truffleruby/core/CoreLibrary.java
@@ -72,7 +72,6 @@
 import org.truffleruby.parser.ast.RootParseNode;
 import org.truffleruby.platform.NativeConfiguration;
 import org.truffleruby.platform.NativeTypes;
-import org.truffleruby.platform.Platform;
 import org.truffleruby.shared.BuildInformationImpl;
 import org.truffleruby.shared.TruffleRuby;
 
diff --git a/src/main/java/org/truffleruby/core/binding/BindingNodes.java b/src/main/java/org/truffleruby/core/binding/BindingNodes.java
@@ -33,8 +33,6 @@
 import org.truffleruby.language.arguments.RubyArguments;
 import org.truffleruby.language.control.RaiseException;
 import org.truffleruby.language.locals.FindDeclarationVariableNodes;
-import org.truffleruby.language.locals.ReadFrameSlotNode;
-import org.truffleruby.language.locals.ReadFrameSlotNodeGen;
 import org.truffleruby.language.locals.WriteFrameSlotNode;
 import org.truffleruby.language.locals.WriteFrameSlotNodeGen;
 import org.truffleruby.language.locals.FindDeclarationVariableNodes.FrameSlotAndDepth;
diff --git a/src/main/java/org/truffleruby/core/format/write/array/WriteValueNode.java b/src/main/java/org/truffleruby/core/format/write/array/WriteValueNode.java
@@ -13,7 +13,6 @@
 import com.oracle.truffle.api.dsl.NodeChild;
 import com.oracle.truffle.api.dsl.Specialization;
 import com.oracle.truffle.api.frame.VirtualFrame;
-import com.oracle.truffle.api.nodes.Node;
 import org.truffleruby.core.array.ArrayUtils;
 import org.truffleruby.core.format.FormatNode;
 import org.truffleruby.core.format.MissingValue;
diff --git a/src/main/java/org/truffleruby/core/inlined/CoreMethods.java b/src/main/java/org/truffleruby/core/inlined/CoreMethods.java
@@ -18,7 +18,6 @@
 import org.truffleruby.language.RubyNode;
 import org.truffleruby.language.dispatch.RubyCallNode;
 import org.truffleruby.language.dispatch.RubyCallNodeParameters;
-import org.truffleruby.language.literal.NilLiteralNode;
 import org.truffleruby.language.methods.BlockDefinitionNode;
 import org.truffleruby.language.methods.InternalMethod;
 import org.truffleruby.parser.TranslatorEnvironment;
diff --git a/src/main/java/org/truffleruby/core/inlined/InlinedBlockGivenNode.java b/src/main/java/org/truffleruby/core/inlined/InlinedBlockGivenNode.java
@@ -9,7 +9,6 @@
  */
 package org.truffleruby.core.inlined;
 
-import org.truffleruby.RubyContext;
 import org.truffleruby.language.RubyNode;
 import org.truffleruby.language.dispatch.RubyCallNodeParameters;
 import org.truffleruby.language.methods.LookupMethodNode;
diff --git a/src/main/java/org/truffleruby/core/kernel/KernelNodes.java b/src/main/java/org/truffleruby/core/kernel/KernelNodes.java
@@ -19,7 +19,6 @@
 import com.oracle.truffle.api.dsl.NodeChild;
 import com.oracle.truffle.api.dsl.ReportPolymorphism;
 import com.oracle.truffle.api.dsl.Specialization;
-import com.oracle.truffle.api.frame.Frame;
 import com.oracle.truffle.api.frame.FrameDescriptor;
 import com.oracle.truffle.api.frame.FrameInstance.FrameAccess;
 import com.oracle.truffle.api.frame.FrameSlot;
@@ -109,8 +108,6 @@
 import org.truffleruby.language.globals.ReadGlobalVariableNodeGen;
 import org.truffleruby.language.loader.CodeLoader;
 import org.truffleruby.language.loader.RequireNode;
-import org.truffleruby.language.locals.ReadFrameSlotNode;
-import org.truffleruby.language.locals.ReadFrameSlotNodeGen;
 import org.truffleruby.language.locals.FindDeclarationVariableNodes.FindAndReadDeclarationVariableNode;
 import org.truffleruby.language.methods.DeclarationContext;
 import org.truffleruby.language.methods.InternalMethod;
diff --git a/src/main/java/org/truffleruby/core/numeric/IntegerNodes.java b/src/main/java/org/truffleruby/core/numeric/IntegerNodes.java
@@ -31,7 +31,6 @@
 import org.truffleruby.builtins.PrimitiveArrayArgumentsNode;
 import org.truffleruby.builtins.YieldingCoreMethodNode;
 import org.truffleruby.core.CoreLibrary;
-import org.truffleruby.core.Hashing;
 import org.truffleruby.core.cast.BooleanCastNode;
 import org.truffleruby.core.cast.ToIntNode;
 import org.truffleruby.core.numeric.IntegerNodesFactory.AbsNodeFactory;
diff --git a/src/main/java/org/truffleruby/core/string/FrozenStringLiterals.java b/src/main/java/org/truffleruby/core/string/FrozenStringLiterals.java
@@ -9,12 +9,9 @@
  */
 package org.truffleruby.core.string;
 
-import java.util.Map;
-import java.util.concurrent.ConcurrentHashMap;
 
 import org.truffleruby.Layouts;
 import org.truffleruby.RubyContext;
-import org.truffleruby.collections.ConcurrentOperations;
 import org.truffleruby.collections.WeakValueCache;
 import org.truffleruby.core.rope.Rope;
 import org.truffleruby.core.rope.RopeKey;
diff --git a/src/main/java/org/truffleruby/core/string/StringNodes.java b/src/main/java/org/truffleruby/core/string/StringNodes.java
@@ -92,7 +92,6 @@
 import org.truffleruby.builtins.NonStandard;
 import org.truffleruby.builtins.Primitive;
 import org.truffleruby.builtins.PrimitiveArrayArgumentsNode;
-import org.truffleruby.builtins.PrimitiveNode;
 import org.truffleruby.builtins.YieldingCoreMethodNode;
 import org.truffleruby.collections.ByteArrayBuilder;
 import org.truffleruby.core.array.ArrayUtils;
@@ -125,10 +124,8 @@
 import org.truffleruby.core.rope.RopeBuilder;
 import org.truffleruby.core.rope.RopeConstants;
 import org.truffleruby.core.rope.RopeGuards;
-import org.truffleruby.core.rope.RopeKey;
 import org.truffleruby.core.rope.RopeNodes;
 import org.truffleruby.core.rope.RopeNodes.RepeatNode;
-import org.truffleruby.core.rope.TruffleRopesNodes.FlattenRopeNode;
 import org.truffleruby.core.rope.RopeOperations;
 import org.truffleruby.core.rope.SubstringRope;
 import org.truffleruby.core.string.StringNodesFactory.ByteIndexFromCharIndexNodeGen;
diff --git a/src/main/java/org/truffleruby/language/RubyConstant.java b/src/main/java/org/truffleruby/language/RubyConstant.java
@@ -14,7 +14,6 @@
 import com.oracle.truffle.api.source.SourceSection;
 
 import java.util.Set;
-import java.util.concurrent.locks.ReentrantLock;
 
 import org.truffleruby.Layouts;
 import org.truffleruby.RubyContext;
diff --git a/src/main/java/org/truffleruby/language/dispatch/UnresolvedDispatchNode.java b/src/main/java/org/truffleruby/language/dispatch/UnresolvedDispatchNode.java
@@ -19,7 +19,6 @@
 import org.truffleruby.language.RubyGuards;
 import org.truffleruby.language.control.RaiseException;
 import org.truffleruby.language.objects.ShapeCachingGuards;
-import org.truffleruby.language.objects.shared.SharedObjects;
 
 public final class UnresolvedDispatchNode extends DispatchNode {
 
diff --git a/src/main/java/org/truffleruby/language/objects/PropagateTaintNode.java b/src/main/java/org/truffleruby/language/objects/PropagateTaintNode.java
@@ -12,7 +12,6 @@
 import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.nodes.Node;
 import com.oracle.truffle.api.object.DynamicObject;
-import com.oracle.truffle.api.profiles.ConditionProfile;
 
 public class PropagateTaintNode extends Node {
 
diff --git a/src/main/java/org/truffleruby/language/yield/YieldExpressionNode.java b/src/main/java/org/truffleruby/language/yield/YieldExpressionNode.java
@@ -19,7 +19,6 @@
 import org.truffleruby.language.RubyNode;
 import org.truffleruby.language.arguments.RubyArguments;
 import org.truffleruby.language.control.RaiseException;
-import org.truffleruby.parser.ReadLocalNode;
 
 public class YieldExpressionNode extends RubyNode {
 
diff --git a/src/main/java/org/truffleruby/stdlib/ObjSpaceNodes.java b/src/main/java/org/truffleruby/stdlib/ObjSpaceNodes.java
@@ -21,10 +21,6 @@
 import org.truffleruby.core.regexp.MatchDataNodes.ValuesNode;
 import org.truffleruby.core.string.StringOperations;
 import org.truffleruby.language.objects.ObjectGraph;
-import org.truffleruby.language.objects.ReadObjectFieldNode;
-import org.truffleruby.language.objects.ReadObjectFieldNodeGen;
-import org.truffleruby.language.objects.WriteObjectFieldNode;
-import org.truffleruby.language.objects.WriteObjectFieldNodeGen;
 
 import java.util.Set;
 
diff --git a/src/main/java/org/truffleruby/stdlib/bigdecimal/BigDecimalNodes.java b/src/main/java/org/truffleruby/stdlib/bigdecimal/BigDecimalNodes.java
@@ -21,7 +21,6 @@
 import org.truffleruby.Layouts;
 import org.truffleruby.builtins.CoreClass;
 import org.truffleruby.builtins.CoreMethod;
-import org.truffleruby.builtins.CoreMethodArrayArgumentsNode;
 import org.truffleruby.builtins.NonStandard;
 import org.truffleruby.builtins.Primitive;
 import org.truffleruby.core.cast.IntegerCastNode;
@@ -33,7 +32,6 @@
 import org.truffleruby.language.Visibility;
 import org.truffleruby.language.control.RaiseException;
 import org.truffleruby.language.dispatch.CallDispatchHeadNode;
-import org.truffleruby.language.objects.AllocateObjectNode;
 import org.truffleruby.parser.SafeDoubleParser;
 
 import java.math.BigDecimal;
diff --git a/src/test/java/org/truffleruby/RubyTCKLanguageProvider.java b/src/test/java/org/truffleruby/RubyTCKLanguageProvider.java
@@ -19,7 +19,6 @@
 import org.graalvm.polyglot.tck.Snippet;
 import org.graalvm.polyglot.tck.TypeDescriptor;
 import org.junit.Assert;
-import org.truffleruby.language.control.RaiseException;
 import org.truffleruby.shared.TruffleRuby;
 
 import java.io.File;
diff --git a/test/mri/excludes/TestExtLibs.rb b/test/mri/excludes/TestExtLibs.rb
@@ -1,8 +1,3 @@
-exclude :"test_existence_of_mathn/complex", "needs investigation"
-exclude :"test_existence_of_mathn/rational", "needs investigation"
-exclude :test_existence_of_nkf, "needs investigation"
-exclude :test_existence_of_openssl, "needs investigation"
 exclude :test_existence_of_pty, "needs investigation"
 exclude :"test_existence_of_racc/cparse", "needs investigation"
-exclude :test_existence_of_ripper, "needs investigation"
 exclude :test_existence_of_sdbm, "needs investigation"
diff --git a/test/mri/failing.exclude b/test/mri/failing.exclude
@@ -60,6 +60,10 @@ ruby/test_parse.rb # encoding
 rubygems/test_gem_security.rb # hangs
 io/wait/test_io_wait_uncommon.rb # unreliable in parallel
 
+# Too slow
+
+test_extlibs.rb
+
 # Other issues
 
 bigdecimal/test_bigdecimal.rb
@@ -177,7 +181,6 @@ ruby/test_arity.rb
 ruby/test_backtrace.rb
 ruby/test_enum.rb # cannot load such file -- continuation
 ruby/test_env.rb # TestEnv#test_aset = core:/core/rubinius/bootstrap/time.rb:28:in `now': internal implementation error - ClassCastException org.truffleruby.runtime.core.RubyNilClass cannot be cast to org.truffleruby.runtime.core.RubyString org.truffleruby.nodes.time.ReadTimeZoneNode.executeRubyString(ReadTimeZoneNode.java:36) (RuntimeError)
-ruby/test_extlibs.rb
 ruby/test_file.rb
 ruby/test_iseq.rb
 ruby/test_iterator.rb # /Users/chrisseaton/Documents/ruby/jruby/test/mri/lib/minitest/unit.rb:1417:in `sort': internal implementation error - NullPointerException null org.truffleruby.runtime.subsystems.TraceManager$4.probeTaggedAs(TraceManager.java:117) (RuntimeError)
