make stronger check of assumption

Nicolas Laurent · Nicolas Laurent · commit 81b6d4050c5c · 2021-02-03T16:23:53.000+01:00
diff --git a/src/main/java/org/truffleruby/core/rope/ConcatRope.java b/src/main/java/org/truffleruby/core/rope/ConcatRope.java
@@ -115,7 +115,10 @@ public ConcatState getState() {
         }
 
         CompilerDirectives.transferToInterpreterAndInvalidate();
-        assert this.bytes != null;
+        if (this.bytes != null) {
+            throw CompilerDirectives
+                    .shouldNotReachHere("our assumptions about reordering and memory barriers seem incorrect");
+        }
         return new ConcatState(null, null, this.bytes);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,10 @@ public ConcatState getState() {`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`CompilerDirectives.transferToInterpreterAndInvalidate();`
`118`		`- assert this.bytes != null;`
	`118`	`+ if (this.bytes != null) {`
	`119`	`+ throw CompilerDirectives`
	`120`	`+ .shouldNotReachHere("our assumptions about reordering and memory barriers seem incorrect");`
	`121`	`+ }`
`119`	`122`	`return new ConcatState(null, null, this.bytes);`
`120`	`123`	`}`
`121`	`124`