[GR-17457] Check the process status and stderr before other expectations.

PullRequest: truffleruby/1997

Author: eregon

spec/truffle/launcher_spec.rb

@@ -72,8 +72,8 @@ def check_status_or_print(stdout_and_stderr)
     unless [:ruby, :truffleruby].include?(launcher)
       it "runs #{launcher} as an -S command" do
         out = ruby_exe(nil, options: "-S#{launcher} --version", args: @redirect)
-        out.should =~ test
         check_status_and_empty_stderr
+        out.should =~ test
       end
     end
   end
@@ -82,8 +82,8 @@ def check_status_or_print(stdout_and_stderr)
     it "supports running #{launcher} in any of the bin/ directories" do
       @bin_dirs.each do |bin_dir|
         out = `#{bin_dir}/#{launcher} --version #{@redirect}`
-        out.should =~ test
         check_status_and_empty_stderr
+        out.should =~ test
       end
     end
   end
@@ -98,8 +98,8 @@ def check_status_or_print(stdout_and_stderr)
             linkname = "linkto#{launcher}"
             File.symlink("#{bin_dir}/#{launcher}", linkname)
             out = `./#{linkname} --version #{@redirect}`
-            out.should =~ test
             check_status_and_empty_stderr
+            out.should =~ test
           end
         end
       end
@@ -148,17 +148,17 @@ def check_status_or_print(stdout_and_stderr)
   ['RUBYOPT', 'TRUFFLERUBYOPT'].each do |var|
     it "should recognize ruby --vm options in #{var}" do
       out = ruby_exe('print Truffle::System.get_java_property("foo")', env: { var => "--vm.Dfoo=bar" }, args: @redirect)
-      out.should == 'bar'
       check_status_and_empty_stderr
+      out.should == 'bar'
     end
   end
 
   def should_print_full_java_command(options, env: {})
     out = ruby_exe(nil, options: options, env: env, args: @redirect)
+    check_status_and_empty_stderr
     parts = out.split(' ')
     parts[0].should == "$"
     parts[1].should =~ /(java|graalvm)$/
-    check_status_and_empty_stderr
   end
 
   it "does not create context on --version and -v" do