Skip to content

Commit 7db18a5

Browse files
committed
[GR-62802] Stop using -UseJVMCICompiler in jt test compiler clone-uninitialized-checks
* That option does not work for unchained standalones (or needs DisableVersionChecks). * The time difference is not that big.
1 parent 48a0a62 commit 7db18a5

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

test/truffle/compiler/clone-uninitialized-checks.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@ source test/truffle/common.sh.inc
55
export TRUFFLERUBY_CHECK_PREINITIALIZED_SPEC=false
66

77
# --always-clone-all covers more than just --core-always-clone, but is much slower (6 min vs 1 min)
8-
JT_SPECS_COMPILATION=false JT_SPECS_SPLITTING=true jt test fast -- --experimental-options --core-always-clone --check-clone-uninitialized-correctness
8+
jt test fast -- --experimental-options --engine.Compilation=false --core-always-clone --check-clone-uninitialized-correctness

tool/jt.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1787,7 +1787,9 @@ def mspec(*args)
17871787
vm_args, ruby_args, parsed_options = ruby_options({}, ['--ea', *ruby_args])
17881788

17891789
if !JT_SPECS_COMPILATION && truffleruby_compiler? && truffleruby_jvm?
1790-
vm_args << '--vm.XX:-UseJVMCICompiler' << '--experimental-options' << '--engine.Compilation=false'
1790+
# Note: GR-62802: --vm.XX:-UseJVMCICompiler does not work for unchained standalones or needs --vm.Dpolyglotimpl.DisableVersionChecks=true
1791+
vm_args << '--vm.XX:-UseJVMCICompiler'
1792+
vm_args << '--experimental-options' << '--engine.Compilation=false'
17911793
vm_args << '--engine.Splitting=false' unless JT_SPECS_SPLITTING
17921794
end
17931795

0 commit comments

Comments
 (0)