Fix UDPSocket#bind to specify family and socktype when resolving address

PullRequest: truffleruby/718

Author: eregon

CHANGELOG.md

@@ -10,9 +10,11 @@ Changes:
   unsupported, have been removed.
 * Our experimental JRuby-compatible Java interop has been removed - use
   `Polyglot` and `Java` instead.
+
 Bug fixes:
 
 * `autoload :C, "path"; require "path"` now correctly triggers the autoload.
+* Fixed `UDPSocket#bind` to specify family and socktype when resolving address.
 
 # 1.0 RC 14
 

lib/truffle/socket/udp_socket.rb

@@ -39,7 +39,8 @@ def initialize(family = Socket::AF_INET)
   end
 
   def bind(host, port)
-    addr   = Socket.sockaddr_in(port.to_i, host)
+    addr = Truffle::Socket::Foreign.pack_sockaddr_in(
+        host, port.to_i, @family, Socket::SOCK_DGRAM, 0)
     status = Truffle::Socket::Foreign.bind(descriptor, addr)
 
     Errno.handle('bind(2)') if status < 0
@@ -48,8 +49,8 @@ def bind(host, port)
   end
 
   def connect(host, port)
-    sockaddr = Truffle::Socket::Foreign
-      .pack_sockaddr_in(host, port.to_i, @family, Socket::SOCK_DGRAM, 0)
+    sockaddr = Truffle::Socket::Foreign.pack_sockaddr_in(
+        host, port.to_i, @family, Socket::SOCK_DGRAM, 0)
 
     status = Truffle::Socket::Foreign.connect(descriptor, sockaddr)
 

spec/tags/library/socket/udpsocket/send_tags.txt

@@ -18,3 +18,5 @@
 exclude :test_sticky, "needs investigation"
 exclude :test_suid, "needs investigation"
 exclude :test_test, "needs investigation"
+exclude :test_flock_exclusive, "spurious on macOS"
+exclude :test_flock_shared, "spurious on macOS"