Move specs to language/hash_spec.rb, add descriptions and cleanup

Author: eregon

spec/ruby/language/hash_spec.rb

@@ -167,3 +167,42 @@ def h.to_hash; {:b => 2, :c => 3}; end
     usascii_hash.keys.first.encoding.should == Encoding::US_ASCII
   end
 end
+
+describe "The ** operator" do
+  it "makes a copy when calling a method taking a keyword rest argument" do
+    def m(**h)
+      h.delete(:one); h
+    end
+
+    h = { one: 1, two: 2 }
+    m(**h).should == { two: 2 }
+    m(**h).should_not.equal?(h)
+    h.should == { one: 1, two: 2 }
+  end
+
+  ruby_version_is ""..."3.0" do
+    it "makes a caller-side copy when calling a method taking a positional Hash" do
+      def m(h)
+        h.delete(:one); h
+      end
+
+      h = { one: 1, two: 2 }
+      m(**h).should == { two: 2 }
+      m(**h).should_not.equal?(h)
+      h.should == { one: 1, two: 2 }
+    end
+  end
+
+  ruby_version_is "3.0" do
+    it "does not copy when calling a method taking a positional Hash" do
+      def m(h)
+        h.delete(:one); h
+      end
+
+      h = { one: 1, two: 2 }
+      m(**h).should == { two: 2 }
+      m(**h).should.equal?(h)
+      h.should == { two: 2 }
+    end
+  end
+end

spec/ruby/language/method_spec.rb

@@ -777,18 +777,7 @@ def m(a, **k) [a, k] end
           m("a" => 1, b: 2).should == [{"a" => 1, b: 2}, {}]
         end
       end
-
-      evaluate <<-ruby do
-        def m(a)
-          a.delete(:one); a
-        end
-      ruby
-      h = { one: 1, two: 2 }
-
-      m(**h).should == { two: 2 }
-      m(**h).should_not equal(h)
     end
-  end
 
     ruby_version_is "3.0" do
       evaluate <<-ruby do
@@ -817,17 +806,6 @@ def m(a, **k) [a, k] end
         m(1, a: 2, b: 3).should == [1, {a: 2, b: 3}]
         -> { m("a" => 1, b: 2) }.should raise_error(ArgumentError)
       end
-
-      evaluate <<-ruby do
-          def m(a)
-            a.delete(:one); a
-          end
-        ruby
-        h = { one: 1, two: 2 }
-
-        m(**h).should == { two: 2 }
-        m(**h).should equal(h)
-      end
     end
 
     evaluate <<-ruby do

spec/tags/language/hash_tags.txt

@@ -0,0 +1 @@
+fails:The ** operator makes a caller-side copy when calling a method taking a positional Hash

spec/tags/language/method_tags.txt

@@ -1,6 +1,5 @@
 fails:A method assigns local variables from method parameters for definition 'def m() end'
 fails:A method assigns local variables from method parameters for definition 'def m(*a) a end'
-fails:"A method assigns local variables from method parameters for definition \n    def m(a)\n      a.delete(:one); a\n    end"
 fails:A method assigns local variables from method parameters for definition 'def m(a = nil, **k) [a, k] end'
 fails:A method assigns local variables from method parameters for definition 'def m(*a, **k) [a, k] end'
 fails:A method assigns local variables from method parameters for definition 'def m(a, **nil); a end;'