Remove unused methods and code review updates

Author: bjfish

spec/tags/core/kernel/eval_tags.txt

@@ -4,3 +4,4 @@ fails:Kernel#eval unwinds through a Proc-style closure and returns from a lambda
 slow:Kernel#eval raises a LocalJumpError if there is no lambda-style closure in the chain
 slow:Kernel#eval does not share locals across eval scopes
 fails(cannot store constant with name in binary encoding):Kernel#eval with a magic encoding comment ignores the magic encoding comment if it is after a frozen_string_literal magic comment
+fails:Kernel#eval with a magic encoding comment ignores the frozen_string_literal magic comment if it appears after a token and warns if $VERBOSE is true

spec/tags/language/numbered_parameters_tags.txt

@@ -1 +1 @@
-fails:Numbered parameters warns when numbered parameter is overwritten with local variable
+fails(GR-30031):Numbered parameters warns when numbered parameter is overwritten with local variable

src/main/java/org/truffleruby/aot/ParserCache.java

@@ -66,7 +66,7 @@ private static RootParseNode parse(RubySource source) {
                 .parseToJRubyAST(null, source, staticScope, parserConfiguration, rubyWarnings);
         if (!rubyWarnings.warnings.isEmpty()) {
             throw new RuntimeException("Core files should not emit warnings: " + String.join(
-                    ", ",
+                    "\n",
                     rubyWarnings.warnings.stream().map(w -> w.getWarningMessage()).collect(Collectors.toList())));
         }
         return rootParseNode;

src/main/java/org/truffleruby/language/methods/CatchForMethodNode.java

@@ -55,10 +55,6 @@ public Object execute(VirtualFrame frame) {
         }
     }
 
-    public RubyNode getBody() {
-        return body;
-    }
-
     @Override
     public RubyNode simplifyAsTailExpression() {
         return new CatchForMethodNode(returnID, body.simplifyAsTailExpression()).copySourceSection(this);

src/main/java/org/truffleruby/language/methods/CatchNextNode.java

@@ -26,10 +26,6 @@ public CatchNextNode(RubyNode body) {
         this.body = body;
     }
 
-    public RubyNode getBody() {
-        return body;
-    }
-
     @Override
     public Object execute(VirtualFrame frame) {
         try {

src/main/java/org/truffleruby/language/methods/CatchRetryAsErrorNode.java

@@ -37,8 +37,4 @@ public Object execute(VirtualFrame frame) {
         }
     }
 
-    public RubyNode getBody() {
-        return body;
-    }
-
 }

src/main/java/org/truffleruby/language/methods/ExceptionTranslatingNode.java

@@ -40,10 +40,6 @@ public Object execute(VirtualFrame frame) {
         }
     }
 
-    public RubyNode getChild() {
-        return child;
-    }
-
     @Override
     public RubyNode simplifyAsTailExpression() {
         return new ExceptionTranslatingNode(child.simplifyAsTailExpression(), unsupportedOperationBehavior)

src/main/java/org/truffleruby/parser/RubyDeferredWarnings.java

@@ -59,7 +59,7 @@ public WarningMessage(Verbosity verbosity, String fileName, Integer lineNumber,
         }
 
         public String getWarningMessage() {
-            StringBuilder buffer = new StringBuilder(100);
+            StringBuilder buffer = new StringBuilder();
             if (fileName != null) {
                 buffer.append(fileName);
                 if (lineNumber != null) {

src/main/java/org/truffleruby/parser/RubyWarnings.java

@@ -69,7 +69,7 @@ public void warn(String fileName, int lineNumber, String message) {
             return;
         }
 
-        StringBuilder buffer = new StringBuilder(100);
+        StringBuilder buffer = new StringBuilder();
 
         buffer.append(fileName).append(':').append(lineNumber).append(": ");
         buffer.append("warning: ").append(message).append('\n');
@@ -82,7 +82,7 @@ public void warn(String fileName, String message) {
             return;
         }
 
-        StringBuilder buffer = new StringBuilder(100);
+        StringBuilder buffer = new StringBuilder();
 
         if (fileName != null) {
             buffer.append(fileName).append(' ');

src/main/java/org/truffleruby/parser/lexer/RubyLexer.java

@@ -851,10 +851,16 @@ private int yylex() {
                 case '#': { /* it's a comment */
                     this.tokenSeen = tokenSeen;
 
-                    // Always scan for magic comments, verbosity is not known at this time.
-                    if (!parser_magic_comment(lexb, lex_p, lex_pend - lex_p, parserRopeOperations, this)) {
-                        if (comment_at_top()) {
-                            set_file_encoding(lex_p, lex_pend);
+                    // There are no magic comments that can affect any runtime options after a token has been seen, so there's
+                    // no point in looking for them. However, if warnings are enabled, this should, but does not, scan for
+                    // the magic comment so we can report that it will be ignored. It does not warn for verbose because
+                    // verbose is not known at this point and we don't want to remove the tokenSeen check because it would
+                    // affect lexer performance.
+                    if (!tokenSeen) {
+                        if (!parser_magic_comment(lexb, lex_p, lex_pend - lex_p, parserRopeOperations, this)) {
+                            if (comment_at_top()) {
+                                set_file_encoding(lex_p, lex_pend);
+                            }
                         }
                     }