Skip to content

Commit 7918a6d

Browse files
committed
Default to BucketsHashStore for the big hash storage strategy
* CompactHashStore seems to be more prone to races: #3447 * Until a thread-safe Hash implementation is merged.
1 parent 04c2281 commit 7918a6d

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/main/java/org/truffleruby/options/LanguageOptions.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public final class LanguageOptions {
4141
public final boolean LAZY_TRANSLATION_USER;
4242
/** --backtraces-omit-unused=true */
4343
public final boolean BACKTRACES_OMIT_UNUSED;
44-
/** --buckets-big-hash=false */
44+
/** --buckets-big-hash=true */
4545
public final boolean BIG_HASH_STRATEGY_IS_BUCKETS;
4646
/** --building-core-cexts=false */
4747
public final boolean BUILDING_CORE_CEXTS;

src/options.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ EXPERT:
118118
BACKTRACES_OMIT_UNUSED: [backtraces-omit-unused, boolean, true, Omit backtraces that should be unused as they have pure rescue expressions]
119119

120120
# Big Hash Strategy
121-
BIG_HASH_STRATEGY_IS_BUCKETS: [buckets-big-hash, boolean, false, 'Whether to use chaining-style buckets hash store for hash tables exceeding the small hash limit']
121+
BIG_HASH_STRATEGY_IS_BUCKETS: [buckets-big-hash, boolean, true, 'Whether to use chaining-style buckets hash store for hash tables exceeding the small hash limit']
122122

123123
# Print backtraces at key events
124124
BACKTRACE_ON_INTERRUPT: [backtraces-on-interrupt, boolean, false, Show the backtraces of all Threads on Ctrl+C]

src/shared/java/org/truffleruby/shared/options/OptionsCatalog.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public final class OptionsCatalog {
6262
public static final OptionKey<Boolean> EXCEPTIONS_WARN_OUT_OF_MEMORY_KEY = new OptionKey<>(true);
6363
public static final OptionKey<Boolean> BACKTRACES_INTERLEAVE_JAVA_KEY = new OptionKey<>(false);
6464
public static final OptionKey<Boolean> BACKTRACES_OMIT_UNUSED_KEY = new OptionKey<>(true);
65-
public static final OptionKey<Boolean> BIG_HASH_STRATEGY_IS_BUCKETS_KEY = new OptionKey<>(false);
65+
public static final OptionKey<Boolean> BIG_HASH_STRATEGY_IS_BUCKETS_KEY = new OptionKey<>(true);
6666
public static final OptionKey<Boolean> BACKTRACE_ON_INTERRUPT_KEY = new OptionKey<>(false);
6767
public static final OptionKey<Boolean> BACKTRACE_ON_SIGALRM_KEY = new OptionKey<>(!EMBEDDED_KEY.getDefaultValue());
6868
public static final OptionKey<Boolean> BACKTRACE_ON_RAISE_KEY = new OptionKey<>(false);

0 commit comments

Comments
 (0)