Implement Time.at in parameter

Author: bjfish

CHANGELOG.md

@@ -59,6 +59,7 @@ Compatibility:
 * Update random implementation layout to be more compatible (#2234).
 * Set `RbConfig::CONFIG['LIBPATHFLAG'/'RPATHFLAG']` like MRI to let `$LIBPATH` changes in `extconf.rb` work.
 * Access to path and mode via `rb_io_t` from C has been changed to improve compatibility for io-console.
+* Implemented the `Time.at` `in:` parameter.
 
 Performance:
 

spec/tags/core/time/at_tags.txt

@@ -1,5 +1,3 @@
 fails:Time.at passed Numeric roundtrips a Rational produced by #to_r
-fails:Time.at :in keyword argument could be UTC offset as a String in '+HH:MM or '-HH:MM' format
-fails:Time.at :in keyword argument could be UTC offset as a number of seconds
 fails:Time.at :in keyword argument could be a timezone object
 fails:Time.at passed non-Time, non-Numeric with an argument that responds to #to_r needs for the argument to respond to #to_int too

src/main/ruby/truffleruby/core/time.rb

@@ -300,18 +300,25 @@ def _dump(limit = nil)
   private :_dump
 
   class << self
-    def at(sec, usec=undefined, unit=undefined)
-      if Primitive.undefined?(usec)
-        if Primitive.object_kind_of?(sec, Time)
-          copy = allocate
-          copy.send(:initialize_copy, sec)
-          return copy
-        elsif Primitive.object_kind_of?(sec, Integer)
-          return Primitive.time_at self, sec, 0
-        elsif Primitive.object_kind_of?(sec, Float) and sec >= 0.0
-          ns = (sec % 1.0 * 1e9).round
-          return Primitive.time_at self, sec.to_i, ns
-        end
+    def at(sec, usec=undefined, unit=undefined, **kwargs)
+      # **kwargs is used here because 'in' is a ruby keyword
+      offset = kwargs[:in] ? Truffle::Type.coerce_to_utc_offset(kwargs[:in]) : nil
+
+      result = if Primitive.undefined?(usec)
+                 if Primitive.object_kind_of?(sec, Time)
+                   copy = allocate
+                   copy.send(:initialize_copy, sec)
+                   copy
+                 elsif Primitive.object_kind_of?(sec, Integer)
+                   Primitive.time_at self, sec, 0
+                 elsif Primitive.object_kind_of?(sec, Float) and sec >= 0.0
+                   ns = (sec % 1.0 * 1e9).round
+                   Primitive.time_at self, sec.to_i, ns
+                 end
+               end
+      if result
+        result = Primitive.time_localtime(result, offset) if offset
+        return result
       end
 
       if Primitive.object_kind_of?(sec, Time) && Primitive.object_kind_of?(usec, Integer)
@@ -343,7 +350,9 @@ def at(sec, usec=undefined, unit=undefined)
       sec += nsec / 1_000_000_000
       nsec %= 1_000_000_000
 
-      Primitive.time_at self, sec, nsec
+      time = Primitive.time_at self, sec, nsec
+      time = Primitive.time_localtime(time, offset) if offset
+      time
     end
 
     def from_array(sec, min, hour, mday, month, year, nsec, is_dst, is_utc, utc_offset)