Move implicit block arg name to the translator environment.

Author: aardvark179

src/main/java/org/truffleruby/core/inlined/CoreMethods.java

@@ -173,7 +173,7 @@ public RubyNode createCallNode(RubyCallNodeParameters callParameters, Translator
                     break;
                 case "block_given?":
                     if (callParameters.isIgnoreVisibility()) {
-                        RubyNode readBlockNode = environment.findLocalVarOrNilNode(TranslatorEnvironment.TEMP_PREFIX + "__unnamed_block_arg__", null);
+                        RubyNode readBlockNode = environment.findLocalVarOrNilNode(TranslatorEnvironment.IMPLICIT_BLOCK_NAME, null);
                         return InlinedBlockGivenNodeGen.create(context, callParameters,
                                        readBlockNode,
                                        self);

src/main/java/org/truffleruby/core/kernel/KernelNodes.java

@@ -294,7 +294,7 @@ public boolean blockGiven(VirtualFrame frame,
                 @Cached("create(nil())") FindAndReadDeclarationVariableNode readNode,
                 @Cached("createBinaryProfile()") ConditionProfile blockProfile) {
             MaterializedFrame callerFrame = callerFrameNode.execute(frame).materialize();
-            return readNode.execute(callerFrame, TranslatorEnvironment.TEMP_PREFIX + "__unnamed_block_arg__") != nil();
+            return readNode.execute(callerFrame, TranslatorEnvironment.IMPLICIT_BLOCK_NAME) != nil();
         }
     }
 

src/main/java/org/truffleruby/core/proc/ProcNodes.java

@@ -77,7 +77,7 @@ public DynamicObject proc(VirtualFrame frame, DynamicObject procClass, Object[]
             final MaterializedFrame parentFrame = getContext().getCallStack().getCallerFrameIgnoringSend()
                     .getFrame(FrameAccess.MATERIALIZE).materialize();
 
-            DynamicObject parentBlock = (DynamicObject) readNode.execute(parentFrame, TranslatorEnvironment.TEMP_PREFIX + "__unnamed_block_arg__");
+            DynamicObject parentBlock = (DynamicObject) readNode.execute(parentFrame, TranslatorEnvironment.IMPLICIT_BLOCK_NAME);
 
             if (parentBlock == nil()) {
                 parentBlock = tryParentBlockForCExts();

src/main/java/org/truffleruby/parser/BodyTranslator.java

@@ -3056,7 +3056,7 @@ public RubyNode visitYieldNode(YieldParseNode node) {
             argumentsTranslated[i] = arguments[i].accept(this);
         }
 
-        RubyNode readBlock = environment.findLocalVarOrNilNode(TranslatorEnvironment.TEMP_PREFIX + "__unnamed_block_arg__", node.getPosition());
+        RubyNode readBlock = environment.findLocalVarOrNilNode(TranslatorEnvironment.IMPLICIT_BLOCK_NAME, node.getPosition());
         final RubyNode ret = new YieldExpressionNode(unsplat, argumentsTranslated, readBlock);
         ret.unsafeSetSourceSection(node.getPosition());
         return addNewlineIfNeeded(node, ret);

src/main/java/org/truffleruby/parser/LoadArgumentsTranslator.java

@@ -344,7 +344,7 @@ public RubyNode visitRestArgNode(RestArgParseNode node) {
 
     public RubyNode visitUnnamedBlockArg() {
         final RubyNode readNode = new ReadBlockNode(context.getCoreLibrary().getNil());
-        final FrameSlot slot = methodBodyTranslator.getEnvironment().getFrameDescriptor().findOrAddFrameSlot(TranslatorEnvironment.TEMP_PREFIX + "__unnamed_block_arg__");
+        final FrameSlot slot = methodBodyTranslator.getEnvironment().getFrameDescriptor().findOrAddFrameSlot(TranslatorEnvironment.IMPLICIT_BLOCK_NAME);
         return new WriteLocalVariableNode(slot, readNode);
     }
 

src/main/java/org/truffleruby/parser/TranslatorEnvironment.java

@@ -30,6 +30,7 @@
 public class TranslatorEnvironment {
 
     public static final char TEMP_PREFIX = '%';
+    public static final String IMPLICIT_BLOCK_NAME = TEMP_PREFIX + "__unnamed_block_arg__";
 
     private final ParseEnvironment parseEnvironment;