[GR-17086] Do not translate IllegalArgumentException

* Consider it an internal error like other Java exceptions.

Author: eregon

src/main/java/org/truffleruby/collections/IntHashMap.java

@@ -71,12 +71,6 @@ public IntHashMap(int initialCapacity) {
     @SuppressWarnings({ "unchecked", "rawtypes" })
     public IntHashMap(int initialCapacity, float loadFactor) {
         super();
-        if (initialCapacity < 0) {
-            throw new IllegalArgumentException("Illegal Capacity: " + initialCapacity);
-        }
-        if (loadFactor <= 0) {
-            throw new IllegalArgumentException("Illegal Load: " + loadFactor);
-        }
         if (initialCapacity == 0) {
             initialCapacity = 1;
         }

src/main/java/org/truffleruby/core/exception/CoreExceptions.java

@@ -14,6 +14,7 @@
 import java.io.IOException;
 import java.util.EnumSet;
 
+import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.interop.InvalidBufferOffsetException;
 import com.oracle.truffle.api.interop.UnknownKeyException;
 import org.jcodings.Encoding;
@@ -1077,7 +1078,7 @@ public RubyException rangeErrorConvertToInt(long value, Node currentNode) {
         } else if (value > Integer.MAX_VALUE) {
             direction = "big";
         } else {
-            throw new IllegalArgumentException();
+            throw CompilerDirectives.shouldNotReachHere("long fitting in int");
         }
 
         return rangeError(StringUtils.format("integer %d too %s to convert to `int'", value, direction), currentNode);

src/main/java/org/truffleruby/core/format/FormatExceptionTranslator.java

@@ -9,6 +9,7 @@
  */
 package org.truffleruby.core.format;
 
+import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
 import com.oracle.truffle.api.nodes.Node;
 import org.truffleruby.RubyContext;
@@ -49,9 +50,8 @@ public static RuntimeException translate(RubyContext context, Node currentNode,
         } else if (exception instanceof InvalidFormatException) {
             final InvalidFormatException e = (InvalidFormatException) exception;
             return new RaiseException(context, coreExceptions.argumentError(e.getMessage(), currentNode));
-
         } else {
-            throw new IllegalArgumentException();
+            throw CompilerDirectives.shouldNotReachHere(exception);
         }
     }
 

src/main/java/org/truffleruby/core/format/pack/SimplePackTreeBuilder.java

@@ -15,6 +15,7 @@
 import java.util.Deque;
 import java.util.List;
 
+import com.oracle.truffle.api.CompilerDirectives;
 import org.truffleruby.RubyLanguage;
 import org.truffleruby.core.format.FormatEncoding;
 import org.truffleruby.core.format.FormatNode;
@@ -293,7 +294,7 @@ private void appendFloatNode(int size, ByteOrder byteOrder, int count) {
                 typeNode = readNode;
                 break;
             default:
-                throw new IllegalArgumentException();
+                throw CompilerDirectives.shouldNotReachHere();
         }
 
         appendNode(sharedTreeBuilder.applyCount(
@@ -341,7 +342,7 @@ private FormatNode writeInteger(int size, ByteOrder byteOrder, FormatNode readNo
                 }
                 break;
             default:
-                throw new IllegalArgumentException(Integer.toString(size));
+                throw CompilerDirectives.shouldNotReachHere(Integer.toString(size));
         }
 
         return WriteBytesNodeGen.create(convertNode);

src/main/java/org/truffleruby/core/format/unpack/SimpleUnpackTreeBuilder.java

@@ -15,6 +15,7 @@
 import java.util.Deque;
 import java.util.List;
 
+import com.oracle.truffle.api.CompilerDirectives;
 import org.truffleruby.RubyLanguage;
 import org.truffleruby.core.format.FormatNode;
 import org.truffleruby.core.format.SharedTreeBuilder;
@@ -306,7 +307,7 @@ private void appendFloatNode(int size, ByteOrder byteOrder, int count) {
                 decodeNode = ReinterpretLongAsDoubleNodeGen.create(readNode);
                 break;
             default:
-                throw new IllegalArgumentException();
+                throw CompilerDirectives.shouldNotReachHere();
         }
 
         final FormatNode writeNode = WriteValueNodeGen.create(new OutputNode(), decodeNode);
@@ -344,7 +345,7 @@ private FormatNode createIntegerDecodeNode(int size, ByteOrder byteOrder, boolea
                 }
                 break;
             default:
-                throw new IllegalArgumentException();
+                throw CompilerDirectives.shouldNotReachHere();
         }
 
         if (!signed) {

src/main/java/org/truffleruby/core/kernel/TruffleKernelNodes.java

@@ -192,7 +192,8 @@ protected Object defineHookedVariableInnerNode(
                     name.getString(),
                     getter,
                     setter,
-                    isDefined);
+                    isDefined,
+                    this);
             return nil;
         }
 

src/main/java/org/truffleruby/core/method/MethodFilter.java

@@ -9,6 +9,7 @@
  */
 package org.truffleruby.core.method;
 
+import com.oracle.truffle.api.CompilerDirectives;
 import org.truffleruby.language.Visibility;
 import org.truffleruby.language.methods.InternalMethod;
 
@@ -57,7 +58,7 @@ public static MethodFilter by(Visibility visibility) {
             case PRIVATE:
                 return PRIVATE;
             default:
-                throw new IllegalArgumentException("unsupported visibility: " + visibility);
+                throw CompilerDirectives.shouldNotReachHere("unsupported visibility: " + visibility);
         }
     }
 }

src/main/java/org/truffleruby/core/proc/ProcOperations.java

@@ -9,6 +9,7 @@
  */
 package org.truffleruby.core.proc;
 
+import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.object.Shape;
 import org.truffleruby.RubyContext;
 import org.truffleruby.RubyLanguage;
@@ -72,7 +73,7 @@ public static RubyProc createRubyProc(
                 callTargetForType = holder.getCallTargetForLambda();
                 break;
             default:
-                throw new IllegalArgumentException();
+                throw CompilerDirectives.shouldNotReachHere();
         }
 
         return new RubyProc(

src/main/java/org/truffleruby/core/string/ConvertBytes.java

@@ -16,6 +16,7 @@
 import java.math.BigInteger;
 import java.util.Arrays;
 
+import com.oracle.truffle.api.CompilerDirectives;
 import org.truffleruby.RubyContext;
 import org.truffleruby.core.CoreLibrary;
 import org.truffleruby.core.numeric.FixnumOrBignumNode;
@@ -733,7 +734,7 @@ public static final byte[] twosComplementToHexBytes(byte[] in, boolean upper) {
 
     public static final byte[] twosComplementToUnsignedBytes(byte[] in, int shift, boolean upper) {
         if (shift < 1 || shift > 4) {
-            throw new IllegalArgumentException("shift value must be 1-4");
+            throw CompilerDirectives.shouldNotReachHere("shift value must be 1-4");
         }
         int ilen = in.length;
         int olen = (ilen * 8 + shift - 1) / shift;

src/main/java/org/truffleruby/core/string/EncodingUtils.java

@@ -29,11 +29,15 @@
 import java.util.ArrayList;
 import java.util.List;
 
+import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
+import com.oracle.truffle.api.nodes.Node;
 import org.jcodings.Encoding;
 import org.jcodings.ascii.AsciiTables;
 import org.jcodings.specific.ASCIIEncoding;
+import org.truffleruby.RubyContext;
 import org.truffleruby.core.rope.CodeRange;
 import org.truffleruby.core.rope.RopeOperations;
+import org.truffleruby.language.control.RaiseException;
 
 public class EncodingUtils {
 
@@ -164,19 +168,25 @@ public static int encAscget(byte[] pBytes, int p, int e, int[] len, Encoding enc
     }
 
     // rb_enc_codepoint_len
-    public static int encCodepointLength(byte[] pBytes, int p, int e, int[] len_p, Encoding enc, CodeRange codeRange) {
+    @TruffleBoundary
+    public static int encCodepointLength(byte[] pBytes, int p, int e, int[] len_p, Encoding enc, CodeRange codeRange,
+            Node node) {
         int r;
         if (e <= p) {
-            throw new IllegalArgumentException("empty string");
+            final RubyContext context = RubyContext.get(node);
+            throw new RaiseException(context, context.getCoreExceptions().argumentError("empty string", node));
         }
         r = StringSupport.characterLength(enc, codeRange, pBytes, p, e);
         if (!StringSupport.MBCLEN_CHARFOUND_P(r)) {
-            throw new IllegalArgumentException("invalid byte sequence in " + enc);
+            final RubyContext context = RubyContext.get(node);
+            throw new RaiseException(
+                    context,
+                    context.getCoreExceptions().argumentError("invalid byte sequence in " + enc, node));
         }
         if (len_p != null) {
             len_p[0] = StringSupport.MBCLEN_CHARFOUND_LEN(r);
         }
-        return StringSupport.codePoint(enc, codeRange, pBytes, p, e);
+        return StringSupport.codePoint(enc, codeRange, pBytes, p, e, node);
     }
 
     // rb_enc_mbcput