Process.argv0 and the initial value of $0 should be frozen

* Also ensure Process.argv0 is set also when embedded.

Author: eregon

spec/tags/core/process/argv0_tags.txt

@@ -1,2 +1 @@
 slow:Process.argv0 is the path given as the main script and the same as __FILE__
-fails:Process.argv0 returns a frozen object

src/main/java/org/truffleruby/RubyContext.java

@@ -47,6 +47,8 @@
 import org.truffleruby.core.array.ArrayOperations;
 import org.truffleruby.core.array.RubyArray;
 import org.truffleruby.core.encoding.EncodingManager;
+import org.truffleruby.core.encoding.Encodings;
+import org.truffleruby.core.encoding.TStringUtils;
 import org.truffleruby.core.exception.CoreExceptions;
 import org.truffleruby.core.fiber.FiberManager;
 import org.truffleruby.core.hash.PreInitializationManager;
@@ -58,7 +60,7 @@
 import org.truffleruby.core.objectspace.ObjectSpaceManager;
 import org.truffleruby.core.proc.ProcOperations;
 import org.truffleruby.core.proc.RubyProc;
-import org.truffleruby.core.string.RubyString;
+import org.truffleruby.core.string.ImmutableRubyString;
 import org.truffleruby.core.symbol.RubySymbol;
 import org.truffleruby.core.thread.ThreadManager;
 import org.truffleruby.core.time.GetTimeZoneNode;
@@ -160,7 +162,7 @@ public class RubyContext {
     private final AssumedValue<Boolean> warningCategoryDeprecated;
     private final AssumedValue<Boolean> warningCategoryExperimental;
 
-    private RubyString scriptName;
+    private ImmutableRubyString mainScriptName;
 
     private static final ContextReference<RubyContext> REFERENCE = ContextReference.create(RubyLanguage.class);
 
@@ -764,11 +766,17 @@ public GlobalVariableStorage getGlobalVariableStorage(int index) {
         return globalVariablesArray.get(index);
     }
 
-    public void setScriptName(RubyString name) {
-        this.scriptName = name;
+    public void initializeMainScriptName(String mainScriptName) {
+        ImmutableRubyString mainScriptString = language.getFrozenStringLiteral(TStringUtils.utf8TString(mainScriptName),
+                Encodings.UTF_8);
+
+        int index = language.getGlobalVariableIndex("$0");
+        getGlobalVariableStorage(index).setValueInternal(mainScriptString);
+
+        this.mainScriptName = mainScriptString;
     }
 
-    public RubyString getScriptName() {
-        return this.scriptName;
+    public ImmutableRubyString getMainScriptName() {
+        return this.mainScriptName;
     }
 }

src/main/java/org/truffleruby/core/CoreLibrary.java

@@ -24,7 +24,6 @@
 
 import com.oracle.truffle.api.RootCallTarget;
 import com.oracle.truffle.api.exception.AbstractTruffleException;
-import com.oracle.truffle.api.strings.TruffleString;
 import org.graalvm.collections.Pair;
 import org.jcodings.transcode.EConvFlags;
 import org.truffleruby.RubyContext;
@@ -47,7 +46,6 @@
 import org.truffleruby.core.numeric.BigIntegerOps;
 import org.truffleruby.core.numeric.RubyBignum;
 import org.truffleruby.core.string.TStringWithEncoding;
-import org.truffleruby.core.string.RubyString;
 import org.truffleruby.debug.BindingLocalVariablesObject;
 import org.truffleruby.debug.GlobalVariablesObject;
 import org.truffleruby.debug.TopScopeObject;
@@ -817,15 +815,7 @@ private void afterLoadCoreLibrary() {
         findGlobalVariableStorage();
 
         // Initialize $0 so it is set to a String as RubyGems expect, also when not run from the RubyLauncher
-        // NOTE(norswap, Nov. 2nd 2020): Okay for language access to be slow, currently only used during initialization.
-        RubyString dollarZeroValue = new RubyString(
-                stringClass,
-                language.stringShape,
-                false,
-                TruffleString.fromCodePointUncached('-', TruffleString.Encoding.US_ASCII),
-                Encodings.US_ASCII);
-        int index = language.getGlobalVariableIndex("$0");
-        context.getGlobalVariableStorage(index).setValueInternal(dollarZeroValue);
+        context.initializeMainScriptName("-");
 
         topLevelBinding = (RubyBinding) objectClass.fields
                 .getConstant("TOPLEVEL_BINDING")

src/main/java/org/truffleruby/core/ProcessNodes.java

@@ -14,7 +14,7 @@
 import org.truffleruby.annotations.Primitive;
 import org.truffleruby.builtins.CoreMethodArrayArgumentsNode;
 import org.truffleruby.builtins.PrimitiveArrayArgumentsNode;
-import org.truffleruby.core.string.RubyString;
+import org.truffleruby.core.string.ImmutableRubyString;
 import org.truffleruby.core.symbol.RubySymbol;
 
 import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
@@ -31,8 +31,8 @@ public abstract class ProcessNodes {
     public abstract static class Argv0Node extends CoreMethodArrayArgumentsNode {
 
         @Specialization
-        protected RubyString argv0() {
-            return getContext().getScriptName();
+        protected ImmutableRubyString argv0() {
+            return getContext().getMainScriptName();
         }
 
     }

src/main/java/org/truffleruby/language/TruffleBootNodes.java

@@ -170,23 +170,23 @@ private void setArgvGlobals() {
 
         private RubySource loadMainSourceSettingDollarZero(String kind, String toExecute) {
             final RubySource rubySource;
-            final RubyString dollarZeroValue;
+            final String mainScriptName;
             final MainLoader mainLoader = new MainLoader(getContext(), getLanguage());
             try {
                 switch (kind) {
                     case "FILE":
                         rubySource = mainLoader.loadFromFile(getContext().getEnv(), this, toExecute);
-                        dollarZeroValue = utf8(toExecute);
+                        mainScriptName = toExecute;
                         break;
 
                     case "STDIN":
                         rubySource = mainLoader.loadFromStandardIn(this, "-");
-                        dollarZeroValue = utf8("-");
+                        mainScriptName = "-";
                         break;
 
                     case "INLINE":
                         rubySource = mainLoader.loadFromCommandLineArgument(toExecute);
-                        dollarZeroValue = utf8("-e");
+                        mainScriptName = "-e";
                         break;
 
                     default:
@@ -197,9 +197,7 @@ private RubySource loadMainSourceSettingDollarZero(String kind, String toExecute
             }
             assert RubyLanguage.MIME_TYPE_MAIN_SCRIPT.equals(rubySource.getSource().getMimeType());
 
-            int index = getLanguage().getGlobalVariableIndex("$0");
-            getContext().getGlobalVariableStorage(index).setValueInternal(dollarZeroValue);
-            getContext().setScriptName(dollarZeroValue);
+            getContext().initializeMainScriptName(mainScriptName);
 
             return rubySource;
         }