[GR-17457] hash_internal is now primitive

PullRequest: truffleruby/3800

Author: horakivo

src/main/java/org/truffleruby/core/array/ArrayNodes.java

@@ -55,6 +55,7 @@
 import org.truffleruby.core.format.FormatExceptionTranslator;
 import org.truffleruby.core.format.exceptions.FormatException;
 import org.truffleruby.core.format.pack.PackCompiler;
+import org.truffleruby.core.hash.HashingNodes;
 import org.truffleruby.core.kernel.KernelNodes;
 import org.truffleruby.core.kernel.KernelNodes.SameOrEqlNode;
 import org.truffleruby.core.kernel.KernelNodes.SameOrEqualNode;
@@ -1049,20 +1050,19 @@ protected Object fillFallback(VirtualFrame frame, RubyArray array, Object[] args
 
     }
 
-    @CoreMethod(names = "hash_internal", visibility = Visibility.PRIVATE)
-    @ReportPolymorphism
-    public abstract static class HashNode extends ArrayCoreMethodNode {
+    @Primitive(name = "hash_internal")
+    @ImportStatic(ArrayGuards.class)
+    public abstract static class HashNode extends PrimitiveArrayArgumentsNode {
 
         private static final int CLASS_SALT = 42753062; // random number, stops hashes for similar values but different classes being the same, static because we want deterministic hashes
 
         @Specialization(limit = "storageStrategyLimit()")
         protected long hash(VirtualFrame frame, RubyArray array,
                 @Bind("array.getStore()") Object store,
                 @CachedLibrary("store") ArrayStoreLibrary stores,
-                @Cached DispatchNode toHashNode,
-                @Cached ToLongNode toLongNode,
-                @Cached IntValueProfile arraySizeProfile,
-                @Cached LoopConditionProfile loopProfile) {
+                @Cached HashingNodes.ToHashByHashCode toHashByHashCode,
+                @Cached @Shared IntValueProfile arraySizeProfile,
+                @Cached @Shared LoopConditionProfile loopProfile) {
             final int size = arraySizeProfile.profile(array.size);
             long h = getContext().getHashing(this).start(size);
             h = Hashing.update(h, CLASS_SALT);
@@ -1071,8 +1071,7 @@ protected long hash(VirtualFrame frame, RubyArray array,
             try {
                 for (; loopProfile.inject(n < size); n++) {
                     final Object value = stores.read(store, n);
-                    final long valueHash = toLongNode.execute(toHashNode.call(value, "hash"));
-                    h = Hashing.update(h, valueHash);
+                    h = Hashing.update(h, toHashByHashCode.execute(value));
                     TruffleSafepoint.poll(this);
                 }
             } finally {

src/main/ruby/truffleruby/core/array.rb

@@ -520,7 +520,7 @@ def flatten!(level = -1)
   def hash
     unless Primitive.array_can_contain_object?(self)
       # Primitive arrays do not need the recursion check
-      return hash_internal
+      return Primitive.hash_internal(self)
     end
 
     hash_val = size
@@ -544,7 +544,7 @@ def hash
       begin
         objects[id] = true
 
-        hash_val = hash_internal
+        hash_val = Primitive.hash_internal(self)
       ensure
         objects.delete id
       end
@@ -556,7 +556,7 @@ def hash
         objects[:__detect_outermost_recursion__] = true
         objects[id] = true
 
-        hash_val = hash_internal
+        hash_val = Primitive.hash_internal(self)
 
         # An inner version will raise to return back here, indicating that
         # the whole structure is recursive. In which case, abandon most of