Skip to content

Commit 658296c

Browse files
committed
[GR-16885] Do not set MinTimeThreshold since it no longer has any effect
1 parent 78eb6cc commit 658296c

File tree

1 file changed

+6
-17
lines changed

1 file changed

+6
-17
lines changed

src/main/java/org/truffleruby/RubyContext.java

Lines changed: 6 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -185,23 +185,12 @@ public RubyContext(RubyLanguage language, TruffleLanguage.Env env) {
185185

186186
// Stuff that needs to be loaded before we load any code
187187

188-
/*
189-
* The Graal option TimeThreshold sets how long a method has to become hot after it has started running, in ms.
190-
* This is designed to not try to compile cold methods that just happen to be called enough times during a
191-
* very long running program. We haven't worked out the best value of this for Ruby yet, and the default value
192-
* produces poor benchmark results. Here we just set it to a very high value, to effectively disable it.
193-
*/
194-
195-
if (compilerOptions.supportsOption("MinTimeThreshold")) {
196-
compilerOptions.setOption("MinTimeThreshold", 100000000);
197-
}
198-
199-
/*
200-
* The Graal option InliningMaxCallerSize sets the maximum size of a method for where we consider to inline
201-
* calls from that method. So it's the caller method we're talking about, not the called method. The default
202-
* value doesn't produce good results for Ruby programs, but we aren't sure why yet. Perhaps it prevents a few
203-
* key methods from the core library from inlining other methods.
204-
*/
188+
/*
189+
* The Graal option InliningMaxCallerSize sets the maximum size of a method for where we consider to inline
190+
* calls from that method. So it's the caller method we're talking about, not the called method. The default
191+
* value doesn't produce good results for Ruby programs, but we aren't sure why yet. Perhaps it prevents a few
192+
* key methods from the core library from inlining other methods.
193+
*/
205194

206195
if (compilerOptions.supportsOption("MinInliningMaxCallerSize")) {
207196
compilerOptions.setOption("MinInliningMaxCallerSize", 5000);

0 commit comments

Comments
 (0)