[GR-29819] Fix issues when running with --engine.ExcludeAssertions=false

PullRequest: truffleruby/2473

Author: eregon

src/main/java/org/truffleruby/core/array/ArrayUtils.java

@@ -20,17 +20,22 @@ public abstract class ArrayUtils {
 
     public static final Object[] EMPTY_ARRAY = new Object[0];
 
+    public static boolean assertNoNullElement(Object[] array) {
+        return assertNoNullElement(array, array.length);
+    }
+
     public static boolean assertNoNullElement(Object[] array, int size) {
         assert size <= array.length;
         for (int i = 0; i < size; i++) {
             final Object element = array[i];
-            assert element != null : element;
+            assert element != null : nullElementAt(array, i);
         }
         return true;
     }
 
-    public static boolean assertNoNullElement(Object[] array) {
-        return assertNoNullElement(array, array.length);
+    @TruffleBoundary
+    private static String nullElementAt(Object[] array, int index) {
+        return "null element in Object[] at index " + index + ": " + Arrays.toString(array);
     }
 
     /** Extracts part of an array into a newly allocated byte[] array. Does not perform safety checks on parameters.

src/main/java/org/truffleruby/core/proc/RubyProc.java

@@ -12,6 +12,7 @@
 import java.util.Set;
 
 import org.truffleruby.core.klass.RubyClass;
+import org.truffleruby.core.string.StringUtils;
 import org.truffleruby.interop.ForeignToRubyArgumentsNode;
 import org.truffleruby.language.Nil;
 import org.truffleruby.language.RubyDynamicObject;
@@ -61,7 +62,7 @@ public RubyProc(
             FrameOnStackMarker frameOnStackMarker,
             DeclarationContext declarationContext) {
         super(rubyClass, shape);
-        assert block instanceof Nil || block instanceof RubyProc : block;
+        assert block instanceof Nil || block instanceof RubyProc : StringUtils.toString(block);
         this.type = type;
         this.sharedMethodInfo = sharedMethodInfo;
         this.callTargets = callTargets;

src/main/java/org/truffleruby/core/string/StringUtils.java

@@ -21,7 +21,7 @@ public abstract class StringUtils {
 
     @TruffleBoundary
     public static String toString(Object value) {
-        return value.toString();
+        return String.valueOf(value);
     }
 
     @TruffleBoundary

src/main/java/org/truffleruby/language/arguments/RubyArguments.java

@@ -11,6 +11,7 @@
 
 import org.truffleruby.core.array.ArrayUtils;
 import org.truffleruby.core.proc.RubyProc;
+import org.truffleruby.core.string.StringUtils;
 import org.truffleruby.language.FrameAndVariables;
 import org.truffleruby.language.Nil;
 import org.truffleruby.language.control.FrameOnStackMarker;
@@ -161,7 +162,7 @@ public static Object getSelf(Frame frame) {
     public static Object getBlock(Frame frame) {
         final Object block = frame.getArguments()[ArgumentIndicies.BLOCK.ordinal()];
         /* We put into the arguments array either a Nil or RubyProc, so that's all we'll get out at this point. */
-        assert block instanceof Nil || block instanceof RubyProc : block;
+        assert block instanceof Nil || block instanceof RubyProc : StringUtils.toString(block);
         return block;
     }