remove todo, add note

Nicolas Laurent · Nicolas Laurent · commit 6287568afb66 · 2021-01-25T16:27:44.000+01:00
diff --git a/src/main/java/org/truffleruby/core/module/ModuleNodes.java b/src/main/java/org/truffleruby/core/module/ModuleNodes.java
@@ -1716,7 +1716,8 @@ protected RubyNode coerceToBoolean(RubyNode inherit) {
             return BooleanCastWithDefaultNodeGen.create(true, inherit);
         }
 
-        // TODO (pitr-ch 30-Mar-2016): cache lookup
+        // NOTE(norswap): We considered caching the lookup here, but determined that the resulting complexity
+        //   increase in LookupMethodNode wasn't worth it, as it would slow down the more common cases.
 
         @Specialization(guards = "inherit")
         protected boolean isMethodDefinedInherit(RubyModule module, String name, boolean inherit) {

Original file line number	Diff line number	Diff line change
`@@ -1716,7 +1716,8 @@ protected RubyNode coerceToBoolean(RubyNode inherit) {`
`1716`	`1716`	`return BooleanCastWithDefaultNodeGen.create(true, inherit);`
`1717`	`1717`	`}`
`1718`	`1718`
`1719`		`- // TODO (pitr-ch 30-Mar-2016): cache lookup`
	`1719`	`+ // NOTE(norswap): We considered caching the lookup here, but determined that the resulting complexity`
	`1720`	`+ // increase in LookupMethodNode wasn't worth it, as it would slow down the more common cases.`
`1720`	`1721`
`1721`	`1722`	`@Specialization(guards = "inherit")`
`1722`	`1723`	`protected boolean isMethodDefinedInherit(RubyModule module, String name, boolean inherit) {`