[GR-17457] Optimize DispatchNode class check

PullRequest: truffleruby/2235

Author: eregon

src/main/java/org/truffleruby/language/dispatch/DispatchNode.java

@@ -78,7 +78,6 @@ public static DispatchNode getUncached() {
     @Child protected ToSymbolNode toSymbol;
 
     protected final ConditionProfile methodMissing;
-    protected final ConditionProfile isForeignCall;
     protected final BranchProfile methodMissingMissing;
 
     protected DispatchNode(
@@ -87,14 +86,12 @@ protected DispatchNode(
             LookupMethodNode methodLookup,
             CallInternalMethodNode callNode,
             ConditionProfile methodMissing,
-            ConditionProfile isForeignCall,
             BranchProfile methodMissingMissing) {
         this.config = config;
         this.metaclassNode = metaclassNode;
         this.methodLookup = methodLookup;
         this.callNode = callNode;
         this.methodMissing = methodMissing;
-        this.isForeignCall = isForeignCall;
         this.methodMissingMissing = methodMissingMissing;
     }
 
@@ -105,7 +102,6 @@ protected DispatchNode(DispatchConfiguration config) {
                 LookupMethodNode.create(),
                 CallInternalMethodNode.create(),
                 ConditionProfile.create(),
-                ConditionProfile.create(),
                 BranchProfile.create());
     }
 
@@ -122,21 +118,21 @@ public Object dispatch(VirtualFrame frame, Object receiver, String methodName, R
     }
 
     public Object execute(VirtualFrame frame, Object receiver, String methodName, RubyProc block, Object[] arguments) {
-
         final RubyClass metaclass = metaclassNode.execute(receiver);
 
-        if (isForeignCall.profile(metaclass == getContext().getCoreLibrary().truffleInteropForeignClass)) {
-            return callForeign(receiver, methodName, block, arguments);
-        }
-
         final InternalMethod method = methodLookup.execute(frame, metaclass, methodName, config);
 
         if (methodMissing.profile(method == null || method.isUndefined())) {
             switch (config.missingBehavior) {
                 case RETURN_MISSING:
                     return MISSING;
                 case CALL_METHOD_MISSING:
-                    return callMethodMissing(frame, receiver, methodName, block, arguments);
+                    // Both branches implicitly profile through lazy node creation
+                    if (metaclass == getContext().getCoreLibrary().truffleInteropForeignClass) {
+                        return callForeign(receiver, methodName, block, arguments);
+                    } else {
+                        return callMethodMissing(frame, receiver, methodName, block, arguments);
+                    }
             }
         }
 
@@ -240,7 +236,6 @@ protected Uncached(DispatchConfiguration config) {
                     LookupMethodNodeGen.getUncached(),
                     CallInternalMethodNodeGen.getUncached(),
                     ConditionProfile.getUncached(),
-                    ConditionProfile.getUncached(),
                     BranchProfile.getUncached());
         }