[GR-25377] Order specializations in *ClassNode nodes by their frequency using SpecializationStatistics

PullRequest: truffleruby/3820

Author: eregon

src/main/java/org/truffleruby/language/objects/ImmutableClassNode.java

@@ -28,6 +28,7 @@
 import com.oracle.truffle.api.dsl.Specialization;
 import com.oracle.truffle.api.dsl.TypeSystemReference;
 
+// Specializations are order by their frequency on railsbench using --engine.SpecializationStatistics
 @GenerateInline
 @GenerateCached(false)
 @GenerateUncached
@@ -40,56 +41,44 @@ public final RubyClass execute(Node node, Object value) {
 
     protected abstract RubyClass execute(Node node, Object value, CoreLibrary coreLibrary);
 
-    // Cover all primitives, nil and symbols
-
-    @Specialization(guards = "value")
-    protected RubyClass metaClassTrue(boolean value, CoreLibrary coreLibrary) {
-        return coreLibrary.trueClass;
-    }
-
-    @Specialization(guards = "!value")
-    protected RubyClass metaClassFalse(boolean value, CoreLibrary coreLibrary) {
-        return coreLibrary.falseClass;
-    }
-
     @Specialization
     protected RubyClass metaClassInt(int value, CoreLibrary coreLibrary) {
         return coreLibrary.integerClass;
     }
 
     @Specialization
-    protected RubyClass metaClassLong(long value, CoreLibrary coreLibrary) {
-        return coreLibrary.integerClass;
-    }
-
-    @Specialization
-    protected RubyClass metaClassBignum(RubyBignum value, CoreLibrary coreLibrary) {
-        return coreLibrary.integerClass;
+    protected RubyClass metaClassImmutableString(ImmutableRubyString value, CoreLibrary coreLibrary) {
+        return coreLibrary.stringClass;
     }
 
     @Specialization
-    protected RubyClass metaClassDouble(double value, CoreLibrary coreLibrary) {
-        return coreLibrary.floatClass;
+    protected RubyClass metaClassSymbol(RubySymbol value, CoreLibrary coreLibrary) {
+        return coreLibrary.symbolClass;
     }
 
     @Specialization
     protected RubyClass metaClassNil(Nil value, CoreLibrary coreLibrary) {
         return coreLibrary.nilClass;
     }
 
-    @Specialization
-    protected RubyClass metaClassSymbol(RubySymbol value, CoreLibrary coreLibrary) {
-        return coreLibrary.symbolClass;
+    @Specialization(guards = "value")
+    protected RubyClass metaClassTrue(boolean value, CoreLibrary coreLibrary) {
+        return coreLibrary.trueClass;
+    }
+
+    @Specialization(guards = "!value")
+    protected RubyClass metaClassFalse(boolean value, CoreLibrary coreLibrary) {
+        return coreLibrary.falseClass;
     }
 
     @Specialization
-    protected RubyClass metaClassEncoding(RubyEncoding value, CoreLibrary coreLibrary) {
-        return coreLibrary.encodingClass;
+    protected RubyClass metaClassLong(long value, CoreLibrary coreLibrary) {
+        return coreLibrary.integerClass;
     }
 
     @Specialization
-    protected RubyClass metaClassImmutableString(ImmutableRubyString value, CoreLibrary coreLibrary) {
-        return coreLibrary.stringClass;
+    protected RubyClass metaClassEncoding(RubyEncoding value, CoreLibrary coreLibrary) {
+        return coreLibrary.encodingClass;
     }
 
     @Specialization
@@ -98,8 +87,18 @@ protected RubyClass metaClassRegexp(RubyRegexp value, CoreLibrary coreLibrary) {
     }
 
     @Specialization
-    protected RubyClass metaClassIntRange(RubyIntOrLongRange value, CoreLibrary coreLibrary) {
+    protected RubyClass metaClassRange(RubyIntOrLongRange value, CoreLibrary coreLibrary) {
         return coreLibrary.rangeClass;
     }
 
+    @Specialization
+    protected RubyClass metaClassDouble(double value, CoreLibrary coreLibrary) {
+        return coreLibrary.floatClass;
+    }
+
+    @Specialization
+    protected RubyClass metaClassBignum(RubyBignum value, CoreLibrary coreLibrary) {
+        return coreLibrary.integerClass;
+    }
+
 }

src/main/java/org/truffleruby/language/objects/LogicalClassNode.java

@@ -21,6 +21,7 @@
 import com.oracle.truffle.api.dsl.GenerateUncached;
 import com.oracle.truffle.api.dsl.Specialization;
 
+// Specializations are order by their frequency on railsbench using --engine.SpecializationStatistics
 @GenerateUncached
 @TypeSystemReference(NoImplicitCastsToLong.class)
 public abstract class LogicalClassNode extends RubyBaseNode {
@@ -36,17 +37,17 @@ public static LogicalClassNode getUncached() {
 
     public abstract RubyClass execute(Object value);
 
+    @Specialization
+    protected RubyClass logicalClassObject(RubyDynamicObject object) {
+        return object.getLogicalClass();
+    }
+
     @Specialization(guards = "isPrimitiveOrImmutable(value)")
     protected RubyClass logicalClassImmutable(Object value,
             @Cached ImmutableClassNode immutableClassNode) {
         return immutableClassNode.execute(this, value);
     }
 
-    @Specialization
-    protected RubyClass logicalClassObject(RubyDynamicObject object) {
-        return object.getLogicalClass();
-    }
-
     @InliningCutoff
     @Specialization(guards = "isForeignObject(object)")
     protected RubyClass logicalClassForeign(Object object,

src/main/java/org/truffleruby/language/objects/MetaClassNode.java

@@ -19,6 +19,7 @@
 import com.oracle.truffle.api.dsl.GenerateUncached;
 import com.oracle.truffle.api.dsl.Specialization;
 
+// Specializations are order by their frequency on railsbench using --engine.SpecializationStatistics
 @GenerateUncached
 public abstract class MetaClassNode extends RubyBaseNode {
 
@@ -33,32 +34,29 @@ public static MetaClassNode getUncached() {
 
     public abstract RubyClass execute(Object value);
 
-    @Specialization(guards = "isPrimitiveOrImmutable(value)")
-    protected RubyClass metaClassImmutable(Object value,
-            @Cached ImmutableClassNode immutableClassNode) {
-        return immutableClassNode.execute(this, value);
-    }
-
-    // Cover all RubyDynamicObject cases with cached and uncached
-
     @Specialization(
             guards = { "object == cachedObject", "metaClass.isSingleton" },
             limit = "getIdentityCacheContextLimit()")
-    protected RubyClass singletonClassCached(RubyDynamicObject object,
+    protected RubyClass singleton(RubyDynamicObject object,
             @Cached("object") RubyDynamicObject cachedObject,
             @Cached("object.getMetaClass()") RubyClass metaClass) {
         return metaClass;
     }
 
-    @Specialization(replaces = "singletonClassCached")
-    protected RubyClass metaClassObject(RubyDynamicObject object) {
+    @Specialization(replaces = "singleton")
+    protected RubyClass object(RubyDynamicObject object) {
         return object.getMetaClass();
     }
 
-    // Foreign object
+    @Specialization(guards = "isPrimitiveOrImmutable(value)")
+    protected RubyClass immutable(Object value,
+            @Cached ImmutableClassNode immutableClassNode) {
+        return immutableClassNode.execute(this, value);
+    }
+
     @InliningCutoff
     @Specialization(guards = "isForeignObject(object)")
-    protected RubyClass metaClassForeign(Object object,
+    protected RubyClass foreign(Object object,
             @Cached ForeignClassNode foreignClassNode) {
         return foreignClassNode.execute(object);
     }

src/main/java/org/truffleruby/language/objects/SingletonClassNode.java

@@ -26,6 +26,7 @@
 import com.oracle.truffle.api.dsl.NodeChild;
 import com.oracle.truffle.api.dsl.Specialization;
 
+// Specializations are order by their frequency on railsbench using --engine.SpecializationStatistics
 @GenerateUncached
 @NodeChild(value = "valueNode", type = RubyNode.class)
 public abstract class SingletonClassNode extends RubySourceNode {
@@ -40,6 +41,36 @@ public static SingletonClassNode create() {
 
     public abstract RubyClass executeSingletonClass(Object value);
 
+    @Specialization(
+            // no need to guard on the context, the rubyClass is context-specific
+            guards = { "rubyClass == cachedClass", "cachedSingletonClass != null" },
+            limit = "getIdentityCacheContextLimit()")
+    protected RubyClass singletonClassClassCached(RubyClass rubyClass,
+            @Cached("rubyClass") RubyClass cachedClass,
+            @Cached("getSingletonClassOfClassOrNull(getContext(), cachedClass)") RubyClass cachedSingletonClass) {
+        return cachedSingletonClass;
+    }
+
+    @Specialization(replaces = "singletonClassClassCached")
+    protected RubyClass singletonClassClassUncached(RubyClass rubyClass) {
+        return ClassNodes.getSingletonClassOfClass(getContext(), rubyClass);
+    }
+
+    @Specialization(
+            // no need to guard on the context, the RubyDynamicObject is context-specific
+            guards = { "object == cachedObject", "!isRubyClass(cachedObject)" },
+            limit = "getIdentityCacheContextLimit()")
+    protected RubyClass singletonClassInstanceCached(RubyDynamicObject object,
+            @Cached("object") RubyDynamicObject cachedObject,
+            @Cached("getSingletonClassForInstance(getContext(), object)") RubyClass cachedSingletonClass) {
+        return cachedSingletonClass;
+    }
+
+    @Specialization(guards = "!isRubyClass(object)", replaces = "singletonClassInstanceCached")
+    protected RubyClass singletonClassInstanceUncached(RubyDynamicObject object) {
+        return getSingletonClassForInstance(getContext(), object);
+    }
+
     @Specialization(guards = "value")
     protected RubyClass singletonClassTrue(boolean value) {
         return coreLibrary().trueClass;
@@ -75,36 +106,6 @@ protected RubyClass singletonClassImmutableObject(ImmutableRubyObject value) {
         return noSingletonClass();
     }
 
-    @Specialization(
-            // no need to guard on the context, the rubyClass is context-specific
-            guards = { "rubyClass == cachedClass", "cachedSingletonClass != null" },
-            limit = "getIdentityCacheContextLimit()")
-    protected RubyClass singletonClassClassCached(RubyClass rubyClass,
-            @Cached("rubyClass") RubyClass cachedClass,
-            @Cached("getSingletonClassOfClassOrNull(getContext(), cachedClass)") RubyClass cachedSingletonClass) {
-        return cachedSingletonClass;
-    }
-
-    @Specialization(replaces = "singletonClassClassCached")
-    protected RubyClass singletonClassClassUncached(RubyClass rubyClass) {
-        return ClassNodes.getSingletonClassOfClass(getContext(), rubyClass);
-    }
-
-    @Specialization(
-            // no need to guard on the context, the RubyDynamicObject is context-specific
-            guards = { "object == cachedObject", "!isRubyClass(cachedObject)" },
-            limit = "getIdentityCacheContextLimit()")
-    protected RubyClass singletonClassInstanceCached(RubyDynamicObject object,
-            @Cached("object") RubyDynamicObject cachedObject,
-            @Cached("getSingletonClassForInstance(getContext(), object)") RubyClass cachedSingletonClass) {
-        return cachedSingletonClass;
-    }
-
-    @Specialization(guards = "!isRubyClass(object)", replaces = "singletonClassInstanceCached")
-    protected RubyClass singletonClassInstanceUncached(RubyDynamicObject object) {
-        return getSingletonClassForInstance(getContext(), object);
-    }
-
     private RubyClass noSingletonClass() {
         throw new RaiseException(getContext(), coreExceptions().typeErrorCantDefineSingleton(this));
     }