fixing Warning#warn printing bug

Author: horakivo

CHANGELOG.md

@@ -115,6 +115,7 @@ Bug fixes:
 * Fix `Kernel#sleep` and `Mutex#sleep` for durations smaller than 1 millisecond (#2716, @eregon).
 * Fix `IO#{wait,wait_readable,wait_writable}` with a timeout > INT_MAX seconds (@eregon).
 * Use the compatible encoding for `String#{sub,gsub,index,rindex}` (#2749, @eregon).
+* Fix `Warning#warn` called with category specified is no longer throwing exception (#20446, @horakivo).
 
 Compatibility:
 

spec/ruby/core/warning/warn_spec.rb

@@ -73,6 +73,54 @@ def Warning.warn(msg)
         $VERBOSE = verbose
       end
     end
+
+    it "should print message when category is :deprecated and Warning[:deprecated] is true" do
+      warn_deprecated = Warning[:deprecated]
+      Warning[:deprecated] = true
+      begin
+        -> {
+          warn("foo", category: :deprecated)
+        }.should complain("foo\n")
+      ensure
+        Warning[:deprecated] = warn_deprecated
+      end
+    end
+
+    it "should print message when category is :experimental and Warning[:experimental] is true" do
+      warn_experimental = Warning[:experimental]
+      Warning[:experimental] = true
+      begin
+        -> {
+          warn("foo", category: :experimental)
+        }.should complain("foo\n")
+      ensure
+        Warning[:experimental] = warn_experimental
+      end
+    end
+
+    it "should not print message when category is :deprecated but Warning[:deprecated] is false" do
+      warn_deprecated = Warning[:deprecated]
+      Warning[:deprecated] = false
+      begin
+        -> {
+          warn("foo", category: :deprecated)
+        }.should_not complain
+      ensure
+        Warning[:deprecated] = warn_deprecated
+      end
+    end
+
+    it "should not print message when category is :experimental but Warning[:experimental] is false" do
+      warn_experimental = Warning[:experimental]
+      Warning[:experimental] = false
+      begin
+        -> {
+          warn("foo", category: :experimental)
+        }.should_not complain
+      ensure
+        Warning[:experimental] = warn_experimental
+      end
+    end
   end
 
   ruby_version_is ''...'3.0' do

src/main/java/org/truffleruby/core/CoreLibrary.java

@@ -1048,6 +1048,7 @@ public boolean isTruffleBootMainMethod(SharedMethodInfo info) {
             "/core/truffle/method_operations.rb",
             "/core/method.rb",
             "/core/unbound_method.rb",
+            "/core/truffle/warning_operations.rb",
             "/core/warning.rb",
             "/core/weakmap.rb",
             "/core/tracepoint.rb",

src/main/ruby/truffleruby/core/warning.rb

@@ -16,9 +16,18 @@ def warn(message, category: nil)
     unless message.encoding.ascii_compatible?
       raise Encoding::CompatibilityError, "ASCII incompatible encoding: #{message.encoding}"
     end
+
     unless Primitive.nil?(category)
       Truffle::Type.rb_check_type(category, Symbol)
       Truffle::WarningOperations.check_category(category)
+
+      if category == :deprecated && !Warning[:deprecated]
+        return nil
+      end
+
+      if category == :experimental && !Warning[:experimental]
+        return nil
+      end
     end
 
     $stderr.write message